* [Nouveau] [PATCH] drm/nouveau/iccsense:
[not found] <20230710070505.53916-1-xujianghui@cdjrlc.com>
@ 2023-07-10 7:06 ` sunran001
2023-07-10 9:09 ` Bagas Sanjaya
0 siblings, 1 reply; 4+ messages in thread
From: sunran001 @ 2023-07-10 7:06 UTC (permalink / raw)
To: airlied, daniel; +Cc: nouveau, linux-kernel, dri-devel
Fixed error: 'do not use assignment in if condition'
This patch fixes error: 'do not use assignment in if condition'
in drm/nouveau/iccsense
Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
index 8f0ccd3664eb..2428f3d6e477 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
@@ -322,7 +322,8 @@ int
nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type
type, int inst,
struct nvkm_iccsense **iccsense)
{
- if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL)))
+ *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL);
+ if (!*iccsense)
return -ENOMEM;
INIT_LIST_HEAD(&(*iccsense)->sensors);
INIT_LIST_HEAD(&(*iccsense)->rails);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/iccsense:
2023-07-10 7:06 ` [Nouveau] [PATCH] drm/nouveau/iccsense: sunran001
@ 2023-07-10 9:09 ` Bagas Sanjaya
2023-07-13 9:13 ` Karol Herbst
0 siblings, 1 reply; 4+ messages in thread
From: Bagas Sanjaya @ 2023-07-10 9:09 UTC (permalink / raw)
To: sunran001, airlied, daniel; +Cc: nouveau, linux-kernel, dri-devel
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran001@208suo.com wrote:
> Fixed error: 'do not use assignment in if condition'
>
> This patch fixes error: 'do not use assignment in if condition'
> in drm/nouveau/iccsense
I guess this is checkpatch fix, right?
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
> drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> index 8f0ccd3664eb..2428f3d6e477 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> @@ -322,7 +322,8 @@ int
> nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type type,
> int inst,
> struct nvkm_iccsense **iccsense)
> {
> - if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL)))
> + *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL);
> + if (!*iccsense)
> return -ENOMEM;
> INIT_LIST_HEAD(&(*iccsense)->sensors);
> INIT_LIST_HEAD(&(*iccsense)->rails);
Your patch is corrupted (tabs converted to spaces) because you're using
Roundcube. Please use git-send-mail(1) instead.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/iccsense:
2023-07-10 9:09 ` Bagas Sanjaya
@ 2023-07-13 9:13 ` Karol Herbst
2023-07-13 9:14 ` Karol Herbst
0 siblings, 1 reply; 4+ messages in thread
From: Karol Herbst @ 2023-07-13 9:13 UTC (permalink / raw)
To: Bagas Sanjaya; +Cc: sunran001, nouveau, linux-kernel, dri-devel, daniel
On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran001@208suo.com wrote:
> > Fixed error: 'do not use assignment in if condition'
> >
> > This patch fixes error: 'do not use assignment in if condition'
> > in drm/nouveau/iccsense
>
> I guess this is checkpatch fix, right?
>
> >
> > Signed-off-by: Ran Sun <sunran001@208suo.com>
> > ---
> > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > index 8f0ccd3664eb..2428f3d6e477 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > @@ -322,7 +322,8 @@ int
> > nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type type,
> > int inst,
> > struct nvkm_iccsense **iccsense)
> > {
> > - if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL)))
> > + *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL);
> > + if (!*iccsense)
> > return -ENOMEM;
> > INIT_LIST_HEAD(&(*iccsense)->sensors);
> > INIT_LIST_HEAD(&(*iccsense)->rails);
>
> Your patch is corrupted (tabs converted to spaces) because you're using
> Roundcube. Please use git-send-mail(1) instead.
>
oh right, I didn't notice with the patches I reviewed already here.
Yeah, none of them apply, please use git to send those patches.
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Nouveau] [PATCH] drm/nouveau/iccsense:
2023-07-13 9:13 ` Karol Herbst
@ 2023-07-13 9:14 ` Karol Herbst
0 siblings, 0 replies; 4+ messages in thread
From: Karol Herbst @ 2023-07-13 9:14 UTC (permalink / raw)
To: Bagas Sanjaya; +Cc: sunran001, nouveau, linux-kernel, dri-devel, daniel
On Thu, Jul 13, 2023 at 11:13 AM Karol Herbst <kherbst@redhat.com> wrote:
>
> On Mon, Jul 10, 2023 at 11:10 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> >
> > On Mon, Jul 10, 2023 at 03:06:47PM +0800, sunran001@208suo.com wrote:
> > > Fixed error: 'do not use assignment in if condition'
> > >
> > > This patch fixes error: 'do not use assignment in if condition'
> > > in drm/nouveau/iccsense
> >
> > I guess this is checkpatch fix, right?
> >
> > >
> > > Signed-off-by: Ran Sun <sunran001@208suo.com>
> > > ---
> > > drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > > b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > > index 8f0ccd3664eb..2428f3d6e477 100644
> > > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/iccsense/base.c
> > > @@ -322,7 +322,8 @@ int
> > > nvkm_iccsense_new_(struct nvkm_device *device, enum nvkm_subdev_type type,
> > > int inst,
> > > struct nvkm_iccsense **iccsense)
> > > {
> > > - if (!(*iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL)))
> > > + *iccsense = kzalloc(sizeof(**iccsense), GFP_KERNEL);
> > > + if (!*iccsense)
> > > return -ENOMEM;
> > > INIT_LIST_HEAD(&(*iccsense)->sensors);
> > > INIT_LIST_HEAD(&(*iccsense)->rails);
> >
> > Your patch is corrupted (tabs converted to spaces) because you're using
> > Roundcube. Please use git-send-mail(1) instead.
> >
>
> oh right, I didn't notice with the patches I reviewed already here.
> Yeah, none of them apply, please use git to send those patches.
>
also please send them all together in a single series the next time.
> > Thanks.
> >
> > --
> > An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-13 9:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230710070505.53916-1-xujianghui@cdjrlc.com>
2023-07-10 7:06 ` [Nouveau] [PATCH] drm/nouveau/iccsense: sunran001
2023-07-10 9:09 ` Bagas Sanjaya
2023-07-13 9:13 ` Karol Herbst
2023-07-13 9:14 ` Karol Herbst
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).