From: Alexander Fomichev <fomichev.ru@gmail.com>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: Guo Zhengkui <guozhengkui@vivo.com>, Jon Mason <jdmason@kudzu.us>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>,
Yang Li <yang.lee@linux.alibaba.com>,
Serge Semin <fancer.lancer@gmail.com>,
"open list:NTB DRIVER CORE" <ntb@lists.linux.dev>,
open list <linux-kernel@vger.kernel.org>,
zhengkui_guo@outlook.com
Subject: Re: [PATCH] ntb_perf: fix doubletest cocci warning
Date: Wed, 20 Apr 2022 11:46:28 +0300 [thread overview]
Message-ID: <CAEKnZG4qTOn8mbTNPaaHbkttnfLz9Nc88DpCcm84T32hiPA5uQ@mail.gmail.com> (raw)
In-Reply-To: <7cb4d3be-925f-05bd-78fe-67a69dfee18d@deltatee.com>
Thanks, nice catch.
I'll include it into the next patch version.
Regards,
Alexander.
вт, 19 апр. 2022 г. в 18:50, Logan Gunthorpe <logang@deltatee.com>:
>
>
>
> On 2022-04-19 01:18, Guo Zhengkui wrote:
> > `!data->ops.init` has been repeated triple. The original logic is to
> > check whether `.init`, `.run` and `.clear` callbacks are NULL or not.
> >
> > Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>
>
> This appears to be a patch against Alexander's patch which has not been
> accepted yet. Posting a note on his patch so he fixes it for the next
> posting would be preferable.
>
> Logan
>
> > ---
> > drivers/ntb/test/ntb_perf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> > index c106c3a5097e..dcae4be91365 100644
> > --- a/drivers/ntb/test/ntb_perf.c
> > +++ b/drivers/ntb/test/ntb_perf.c
> > @@ -1451,7 +1451,7 @@ static void perf_ext_lat_work(struct work_struct *work)
> > {
> > struct perf_ext_lat_data *data = to_ext_lat_data(work);
> >
> > - if (!data->ops.init || !data->ops.init || !data->ops.init) {
> > + if (!data->ops.init || !data->ops.run || !data->ops.clear) {
> > struct perf_ctx *perf = data->perf;
> >
> > data->status = -EFAULT;
prev parent reply other threads:[~2022-04-20 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 7:18 [PATCH] ntb_perf: fix doubletest cocci warning Guo Zhengkui
2022-04-19 15:37 ` Dave Jiang
2022-04-19 15:49 ` Logan Gunthorpe
2022-04-20 8:46 ` Alexander Fomichev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEKnZG4qTOn8mbTNPaaHbkttnfLz9Nc88DpCcm84T32hiPA5uQ@mail.gmail.com \
--to=fomichev.ru@gmail.com \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=guozhengkui@vivo.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=ntb@lists.linux.dev \
--cc=yang.lee@linux.alibaba.com \
--cc=zhengkui_guo@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).