Re: [PATCH] ntb_perf: fix doubletest cocci warning

From: Dave Jiang <dave.jiang@intel.com>
To: Guo Zhengkui <guozhengkui@vivo.com>, Jon Mason <jdmason@kudzu.us>,
	Allen Hubbe <allenbh@gmail.com>,
	Yang Li <yang.lee@linux.alibaba.com>,
	Alexander Fomichev <fomichev.ru@gmail.com>,
	Serge Semin <fancer.lancer@gmail.com>,
	"open list:NTB DRIVER CORE" <ntb@lists.linux.dev>,
	open list <linux-kernel@vger.kernel.org>
Cc: zhengkui_guo@outlook.com
Subject: Re: [PATCH] ntb_perf: fix doubletest cocci warning
Date: Tue, 19 Apr 2022 08:37:28 -0700	[thread overview]
Message-ID: <d8240552-acea-0214-a5a3-6bf07ad6b007@intel.com> (raw)
In-Reply-To: <20220419071855.23338-1-guozhengkui@vivo.com>


On 4/19/2022 12:18 AM, Guo Zhengkui wrote:
> `!data->ops.init` has been repeated triple. The original logic is to
> check whether `.init`, `.run` and `.clear` callbacks are NULL or not.
>
> Signed-off-by: Guo Zhengkui <guozhengkui@vivo.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>


> ---
>   drivers/ntb/test/ntb_perf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> index c106c3a5097e..dcae4be91365 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -1451,7 +1451,7 @@ static void perf_ext_lat_work(struct work_struct *work)
>   {
>   	struct perf_ext_lat_data *data = to_ext_lat_data(work);
>   
> -	if (!data->ops.init || !data->ops.init || !data->ops.init) {
> +	if (!data->ops.init || !data->ops.run || !data->ops.clear) {
>   		struct perf_ctx *perf = data->perf;
>   
>   		data->status = -EFAULT;