* [PATCH] fs/ntfs3: Add check for kmemdup
@ 2022-11-23 8:48 Jiasheng Jiang
2022-12-26 15:04 ` Konstantin Komarov
0 siblings, 1 reply; 2+ messages in thread
From: Jiasheng Jiang @ 2022-11-23 8:48 UTC (permalink / raw)
To: almaz.alexandrovich, nathan, ndesaulniers, trix
Cc: ntfs3, linux-kernel, llvm, Jiasheng Jiang
Since the kmemdup may return NULL pointer,
it should be better to add check for the return value
in order to avoid NULL pointer dereference.
Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
fs/ntfs3/fslog.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c
index 0d611a6c5511..eb7cf8a69607 100644
--- a/fs/ntfs3/fslog.c
+++ b/fs/ntfs3/fslog.c
@@ -4277,6 +4277,10 @@ int log_replay(struct ntfs_inode *ni, bool *initialized)
rec_len -= t32;
attr_names = kmemdup(Add2Ptr(lrh, t32), rec_len, GFP_NOFS);
+ if (!attr_names) {
+ err = -ENOMEM;
+ goto out;
+ }
lcb_put(lcb);
lcb = NULL;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/ntfs3: Add check for kmemdup
2022-11-23 8:48 [PATCH] fs/ntfs3: Add check for kmemdup Jiasheng Jiang
@ 2022-12-26 15:04 ` Konstantin Komarov
0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Komarov @ 2022-12-26 15:04 UTC (permalink / raw)
To: Jiasheng Jiang, nathan, ndesaulniers, trix; +Cc: ntfs3, linux-kernel, llvm
On 23.11.2022 12:48, Jiasheng Jiang wrote:
> Since the kmemdup may return NULL pointer,
> it should be better to add check for the return value
> in order to avoid NULL pointer dereference.
>
> Fixes: b46acd6a6a62 ("fs/ntfs3: Add NTFS journal")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> fs/ntfs3/fslog.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/ntfs3/fslog.c b/fs/ntfs3/fslog.c
> index 0d611a6c5511..eb7cf8a69607 100644
> --- a/fs/ntfs3/fslog.c
> +++ b/fs/ntfs3/fslog.c
> @@ -4277,6 +4277,10 @@ int log_replay(struct ntfs_inode *ni, bool *initialized)
> rec_len -= t32;
>
> attr_names = kmemdup(Add2Ptr(lrh, t32), rec_len, GFP_NOFS);
> + if (!attr_names) {
> + err = -ENOMEM;
> + goto out;
> + }
>
> lcb_put(lcb);
> lcb = NULL;
Thank you for your work, applied!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-26 15:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-23 8:48 [PATCH] fs/ntfs3: Add check for kmemdup Jiasheng Jiang
2022-12-26 15:04 ` Konstantin Komarov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).