ntfs3.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH][next] fs/ntfs3: remove duplicated assignment to variable r
@ 2022-07-04 18:53 Colin Ian King
  2022-07-05 13:31 ` Konstantin Komarov
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2022-07-04 18:53 UTC (permalink / raw)
  To: Konstantin Komarov, ntfs3; +Cc: kernel-janitors, linux-kernel

The assignment to variable r is duplicated, the second assignment
is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 fs/ntfs3/run.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ntfs3/run.c b/fs/ntfs3/run.c
index 7609d45a2d72..aba8ab1b9fcb 100644
--- a/fs/ntfs3/run.c
+++ b/fs/ntfs3/run.c
@@ -563,7 +563,6 @@ bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len)
 	e = run->runs + run->count;
 	r = run->runs + index;
 
-	r = run->runs + index;
 	if (vcn > r->vcn)
 		r += 1;
 
-- 
2.35.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] fs/ntfs3: remove duplicated assignment to variable r
  2022-07-04 18:53 [PATCH][next] fs/ntfs3: remove duplicated assignment to variable r Colin Ian King
@ 2022-07-05 13:31 ` Konstantin Komarov
  0 siblings, 0 replies; 2+ messages in thread
From: Konstantin Komarov @ 2022-07-05 13:31 UTC (permalink / raw)
  To: Colin Ian King, ntfs3; +Cc: kernel-janitors, linux-kernel

On 7/4/22 21:53, Colin Ian King wrote:
> The assignment to variable r is duplicated, the second assignment
> is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>   fs/ntfs3/run.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ntfs3/run.c b/fs/ntfs3/run.c
> index 7609d45a2d72..aba8ab1b9fcb 100644
> --- a/fs/ntfs3/run.c
> +++ b/fs/ntfs3/run.c
> @@ -563,7 +563,6 @@ bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len)
>   	e = run->runs + run->count;
>   	r = run->runs + index;
>   
> -	r = run->runs + index;
>   	if (vcn > r->vcn)
>   		r += 1;
>   

Thanks for patch, applied!

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-07-05 13:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 18:53 [PATCH][next] fs/ntfs3: remove duplicated assignment to variable r Colin Ian King
2022-07-05 13:31 ` Konstantin Komarov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).