From: "Qi, Fuli" <qi.fuli@jp.fujitsu.com>
To: 'Masayoshi Mizuma' <msys.mizuma@gmail.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Cc: "Mizuma, Masayoshi" <m.mizuma@jp.fujitsu.com>
Subject: RE: [PATCH] ndctl, monitor: Change the fail log priority to err.
Date: Thu, 2 Aug 2018 11:42:09 +0000 [thread overview]
Message-ID: <0DEDF3B159719A448A49EF0E7B11E3223DA9C824@g01jpexmbkw24> (raw)
In-Reply-To: <20180801185538.27084-1-msys.mizuma@gmail.com>
> -----Original Message-----
> From: Masayoshi Mizuma [mailto:msys.mizuma@gmail.com]
> Sent: Thursday, August 2, 2018 3:56 AM
> To: linux-nvdimm@lists.01.org
> Cc: Masayoshi Mizuma <msys.mizuma@gmail.com>; Qi, Fuli/斉 福利
> <qi.fuli@jp.fujitsu.com>; Mizuma, Masayoshi/水間 理仁 <m.mizuma@jp.fujitsu.com>
> Subject: [PATCH] ndctl, monitor: Change the fail log priority to err.
>
> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
>
> fail() is called if an error happens, but the log priority is debug, so user may
> not notice the error.
> Let's change the priority to err.
>
> Cc: QI Fuli <qi.fuli@jp.fujitsu.com>
> Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com>
> ---
> ndctl/monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ndctl/monitor.c b/ndctl/monitor.c index 84d51c4..68bbf65 100644
> --- a/ndctl/monitor.c
> +++ b/ndctl/monitor.c
> @@ -40,7 +40,7 @@ static int did_fail;
> #define fail(fmt, ...) \
> do { \
> did_fail = 1; \
> - dbg(ctx, "ndctl-%s:%s:%d: " fmt, \
> + err(ctx, "ndctl-%s:%s:%d: " fmt, \
> VERSION, __func__, __LINE__, ##__VA_ARGS__); \ } while (0)
>
Hi Masa,
The debug messages which are from fail() include source code line numbers and function name,
these are useful for developers not typical users. Therefore, we made it a debug level print.
Currently the debug level cannot be outputted is a bug.
I will make a patch for adding [--verbose] option to emit debug messages and changing the log level of some messages.
Thanks,
QI
> --
> 2.18.0
>
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-08-02 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 18:55 [PATCH] ndctl, monitor: Change the fail log priority to err Masayoshi Mizuma
2018-08-02 11:42 ` Qi, Fuli [this message]
2018-08-02 13:10 ` Masayoshi Mizuma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0DEDF3B159719A448A49EF0E7B11E3223DA9C824@g01jpexmbkw24 \
--to=qi.fuli@jp.fujitsu.com \
--cc=linux-nvdimm@lists.01.org \
--cc=m.mizuma@jp.fujitsu.com \
--cc=msys.mizuma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).