* [ndctl PATCH] test, dsm-fail: Cleanup leftover debug
@ 2018-10-13 4:29 Dan Williams
2018-10-15 22:59 ` Verma, Vishal L
0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2018-10-13 4:29 UTC (permalink / raw)
To: linux-nvdimm
Prints from a debug session got committed, delete them.
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
test/dsm-fail.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/test/dsm-fail.c b/test/dsm-fail.c
index 6845f818c8da..6e812aec008f 100644
--- a/test/dsm-fail.c
+++ b/test/dsm-fail.c
@@ -291,48 +291,39 @@ static int do_test(struct ndctl_ctx *ctx, struct ndctl_test *test)
&log_ctx);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
rc = test_dimms_enable(bus, victim, true);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
rc = test_regions_enable(bus, victim, victim_region, true, 2);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
rc = set_dimm_response(DIMM_PATH, ND_CMD_GET_CONFIG_SIZE, 0, &log_ctx);
if (rc)
goto out;
ndctl_region_foreach(bus, region)
ndctl_region_disable_invalidate(region);
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
rc = dimms_disable(bus);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
rc = set_dimm_response(DIMM_PATH, ND_CMD_GET_CONFIG_DATA, -EACCES,
&log_ctx);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
+
rc = test_dimms_enable(bus, victim, false);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
rc = test_regions_enable(bus, victim, victim_region, false, 0);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
rc = set_dimm_response(DIMM_PATH, ND_CMD_GET_CONFIG_DATA, 0, &log_ctx);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
rc = dimms_disable(bus);
if (rc)
goto out;
- fprintf(stderr, "%s:%d\n", __func__, __LINE__);
out:
err = rc;
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ndctl PATCH] test, dsm-fail: Cleanup leftover debug
2018-10-13 4:29 [ndctl PATCH] test, dsm-fail: Cleanup leftover debug Dan Williams
@ 2018-10-15 22:59 ` Verma, Vishal L
0 siblings, 0 replies; 2+ messages in thread
From: Verma, Vishal L @ 2018-10-15 22:59 UTC (permalink / raw)
To: Williams, Dan J, linux-nvdimm
On Fri, 2018-10-12 at 21:29 -0700, Dan Williams wrote:
> Prints from a debug session got committed, delete them.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> test/dsm-fail.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
Looks good, applied.
>
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-15 22:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-13 4:29 [ndctl PATCH] test, dsm-fail: Cleanup leftover debug Dan Williams
2018-10-15 22:59 ` Verma, Vishal L
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).