From: Dave Jiang <dave.jiang@intel.com>
To: vishal.l.verma@intel.com, dan.j.williams@intel.com
Cc: linux-nvdimm@lists.01.org
Subject: [PATCH] ndctl: fix input/output size for Intel firmware update DSM
Date: Thu, 22 Mar 2018 11:26:04 -0700 [thread overview]
Message-ID: <152174316397.12504.9225022827981437244.stgit@djiang5-desk3.ch.intel.com> (raw)
The FW_START DSM should have input/out of 0/8, the code incorrectly
is passing in 4/4. This is causing failure with newer BIOS that check
the input/output parameters more strictly.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
---
ndctl/lib/intel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ndctl/lib/intel.c b/ndctl/lib/intel.c
index 3c4509e4..ba210e1c 100644
--- a/ndctl/lib/intel.c
+++ b/ndctl/lib/intel.c
@@ -449,8 +449,8 @@ static struct ndctl_cmd *intel_dimm_cmd_new_fw_start(struct ndctl_dimm *dimm)
BUILD_ASSERT(sizeof(struct nd_intel_fw_start) == 8);
- cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE,
- sizeof(cmd->intel->start) - 4, 4);
+ cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE, 0,
+ sizeof(cmd->intel->start));
if (!cmd)
return NULL;
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next reply other threads:[~2018-03-22 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 18:26 Dave Jiang [this message]
2018-03-22 18:28 ` [PATCH] ndctl: fix input/output size for Intel firmware update DSM Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152174316397.12504.9225022827981437244.stgit@djiang5-desk3.ch.intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).