From: Dan Williams <dan.j.williams@intel.com>
To: Dave Jiang <dave.jiang@intel.com>
Cc: linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH] ndctl: fix input/output size for Intel firmware update DSM
Date: Thu, 22 Mar 2018 11:28:25 -0700 [thread overview]
Message-ID: <CAPcyv4jBZVQ22f5o-exWLTTkj6iefVTuwijtZK0QptCP02xnYQ@mail.gmail.com> (raw)
In-Reply-To: <152174316397.12504.9225022827981437244.stgit@djiang5-desk3.ch.intel.com>
On Thu, Mar 22, 2018 at 11:26 AM, Dave Jiang <dave.jiang@intel.com> wrote:
> The FW_START DSM should have input/out of 0/8, the code incorrectly
> is passing in 4/4. This is causing failure with newer BIOS that check
> the input/output parameters more strictly.
>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> ---
> ndctl/lib/intel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ndctl/lib/intel.c b/ndctl/lib/intel.c
> index 3c4509e4..ba210e1c 100644
> --- a/ndctl/lib/intel.c
> +++ b/ndctl/lib/intel.c
> @@ -449,8 +449,8 @@ static struct ndctl_cmd *intel_dimm_cmd_new_fw_start(struct ndctl_dimm *dimm)
>
> BUILD_ASSERT(sizeof(struct nd_intel_fw_start) == 8);
>
> - cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE,
> - sizeof(cmd->intel->start) - 4, 4);
> + cmd = alloc_intel_cmd(dimm, ND_INTEL_FW_START_UPDATE, 0,
> + sizeof(cmd->intel->start));
Looks good, applied.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-03-22 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 18:26 [PATCH] ndctl: fix input/output size for Intel firmware update DSM Dave Jiang
2018-03-22 18:28 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4jBZVQ22f5o-exWLTTkj6iefVTuwijtZK0QptCP02xnYQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).