[ndctl PATCH] ndctl: Remove dependency on linker garbage collection

[ndctl PATCH] ndctl: Remove dependency on linker garbage collection

[Dan Williams]

A sub-set of the unit tests are optionally included in the build when
"--enable-test" is specified to the configure script. However, the "ndctl
test" command support code should not be included in the build when
"--enable-test" is not specified. The linker was being helpful and
throwing away the error, because cmd_test() is never called, but we
should not have wasted time compiling and throwing away that file in the
first place.

Reported-by: Nick Clifton <nickc@redhat.com>
Link: https://bugzilla.redhat.com/show_bug.cgi?id=1598961
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 ndctl/Makefile.am |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ndctl/Makefile.am b/ndctl/Makefile.am
index 9d008d52c964..087ddc52418c 100644
--- a/ndctl/Makefile.am
+++ b/ndctl/Makefile.am
@@ -11,7 +11,6 @@ ndctl_SOURCES = ndctl.c \
 		dimm.c \
 		 ../util/log.c \
 		list.c \
-		test.c \
 		../util/json.c \
 		util/json-smart.c \
 		util/json-firmware.c \
@@ -40,7 +39,8 @@ ndctl_SOURCES += ../test/libndctl.c \
 		 ../test/dpa-alloc.c \
 		 ../test/parent-uuid.c \
 		 ../test/multi-pmem.c \
-		 ../test/core.c
+		 ../test/core.c \
+		 test.c
 endif
 
 monitor_config_file = monitor.conf

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm