* [PATCH] tools/testing/nvdimm: Fix missing 'fallthrough' warning
@ 2021-07-30 20:00 Dan Williams
2021-08-04 17:13 ` Jeff Moyer
0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2021-07-30 20:00 UTC (permalink / raw)
To: nvdimm; +Cc: vishal.l.verma
Use "fallthrough;" to address:
tools/testing/nvdimm/test/nfit.c: In function ‘nd_intel_test_finish_query’:
tools/testing/nvdimm/test/nfit.c:436:37: warning: this statement may
fall through [-Wimplicit-fallthrough=]
436 | fw->missed_activate = false;
| ~~~~~~~~~~~~~~~~~~~~^~~~~~~
tools/testing/nvdimm/test/nfit.c:438:9: note: here
438 | case FW_STATE_UPDATED:
| ^~~~
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
tools/testing/nvdimm/test/nfit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
index 54f367cbadae..b1bff5fb0f65 100644
--- a/tools/testing/nvdimm/test/nfit.c
+++ b/tools/testing/nvdimm/test/nfit.c
@@ -434,7 +434,7 @@ static int nd_intel_test_finish_query(struct nfit_test *t,
dev_dbg(dev, "%s: transition out verify\n", __func__);
fw->state = FW_STATE_UPDATED;
fw->missed_activate = false;
- /* fall through */
+ fallthrough;
case FW_STATE_UPDATED:
nd_cmd->status = 0;
/* bogus test version */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/testing/nvdimm: Fix missing 'fallthrough' warning
2021-07-30 20:00 [PATCH] tools/testing/nvdimm: Fix missing 'fallthrough' warning Dan Williams
@ 2021-08-04 17:13 ` Jeff Moyer
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Moyer @ 2021-08-04 17:13 UTC (permalink / raw)
To: Dan Williams; +Cc: nvdimm, vishal.l.verma
Dan Williams <dan.j.williams@intel.com> writes:
> Use "fallthrough;" to address:
>
> tools/testing/nvdimm/test/nfit.c: In function ‘nd_intel_test_finish_query’:
> tools/testing/nvdimm/test/nfit.c:436:37: warning: this statement may
> fall through [-Wimplicit-fallthrough=]
> 436 | fw->missed_activate = false;
> | ~~~~~~~~~~~~~~~~~~~~^~~~~~~
> tools/testing/nvdimm/test/nfit.c:438:9: note: here
> 438 | case FW_STATE_UPDATED:
> | ^~~~
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
> tools/testing/nvdimm/test/nfit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
> index 54f367cbadae..b1bff5fb0f65 100644
> --- a/tools/testing/nvdimm/test/nfit.c
> +++ b/tools/testing/nvdimm/test/nfit.c
> @@ -434,7 +434,7 @@ static int nd_intel_test_finish_query(struct nfit_test *t,
> dev_dbg(dev, "%s: transition out verify\n", __func__);
> fw->state = FW_STATE_UPDATED;
> fw->missed_activate = false;
> - /* fall through */
> + fallthrough;
> case FW_STATE_UPDATED:
> nd_cmd->status = 0;
> /* bogus test version */
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-04 17:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 20:00 [PATCH] tools/testing/nvdimm: Fix missing 'fallthrough' warning Dan Williams
2021-08-04 17:13 ` Jeff Moyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).