* [ndctl PATCH] ndctl, test: skip btt-pad compat test on pre-4K capable kernels
@ 2018-02-23 6:59 Dan Williams
2018-02-23 21:01 ` Ross Zwisler
0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2018-02-23 6:59 UTC (permalink / raw)
To: linux-nvdimm
Prior to the introduction of v1.2 namespace labels it was not possible
to specify a pmem namespace with a 4K sector size. Skip this test when
that namespace creation attempt fails.
Cc: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
test/btt-pad-compat.sh | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/test/btt-pad-compat.sh b/test/btt-pad-compat.sh
index a157c589460e..b2e395de2297 100755
--- a/test/btt-pad-compat.sh
+++ b/test/btt-pad-compat.sh
@@ -136,8 +136,12 @@ copy_xxd_img()
create_oldfmt_ns()
{
- # create null-uuid namespace
+ # create null-uuid namespace, note that this requires a kernel
+ # that supports a raw namespace with a 4K sector size, prior to
+ # v4.13 raw namespaces are limited to 512-byte sector size.
+ rc=77
json=$($ndctl create-namespace -b "$bus" -s 64M -t pmem -m raw -l 4096 -u 00000000-0000-0000-0000-000000000000)
+ rc=1
eval "$(echo "$json" | sed -e "$json2var")"
[ -n "$dev" ] || err "$LINENO" 2
[ -n "$size" ] || err "$LINENO" 2
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ndctl PATCH] ndctl, test: skip btt-pad compat test on pre-4K capable kernels
2018-02-23 6:59 [ndctl PATCH] ndctl, test: skip btt-pad compat test on pre-4K capable kernels Dan Williams
@ 2018-02-23 21:01 ` Ross Zwisler
0 siblings, 0 replies; 2+ messages in thread
From: Ross Zwisler @ 2018-02-23 21:01 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-nvdimm
On Thu, Feb 22, 2018 at 10:59:17PM -0800, Dan Williams wrote:
> Prior to the introduction of v1.2 namespace labels it was not possible
> to specify a pmem namespace with a 4K sector size. Skip this test when
> that namespace creation attempt fails.
>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Sure, seems fine.
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-23 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-23 6:59 [ndctl PATCH] ndctl, test: skip btt-pad compat test on pre-4K capable kernels Dan Williams
2018-02-23 21:01 ` Ross Zwisler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).