nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] filesystem-dax fix for 4.19-rc6
@ 2018-09-30  2:16 Williams, Dan J
  2018-09-30 13:38 ` gregkh
  0 siblings, 1 reply; 2+ messages in thread
From: Williams, Dan J @ 2018-09-30  2:16 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, linux-nvdimm

Hi Greg, please pull from...

  git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/libnvdimm-fixes2-4.19-rc6

...to receive one more urgent fix for 4.19-rc6.

---

The following changes since commit 6bf4ca7fbc85d80446ac01c0d1d77db4d91a6d84:

  Linux 4.19-rc5 (2018-09-23 19:15:18 +0200)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/libnvdimm-fixes2-4.19-rc6

for you to fetch changes up to f52afc93cd018fe6910133a05d44671192d1aeb0:

  dax: Fix deadlock in dax_lock_mapping_entry() (2018-09-27 10:56:15 -0700)

----------------------------------------------------------------
filesystem-dax for 4.19-rc6

Fix a deadlock in the new for 4.19 dax_lock_mapping_entry() routine.

----------------------------------------------------------------
Jan Kara (1):
      dax: Fix deadlock in dax_lock_mapping_entry()

 fs/dax.c | 1 +
 1 file changed, 1 insertion(+)

commit f52afc93cd018fe6910133a05d44671192d1aeb0
Author: Jan Kara <jack@suse.cz>
Date:   Thu Sep 27 13:23:32 2018 +0200

    dax: Fix deadlock in dax_lock_mapping_entry()
    
    When dax_lock_mapping_entry() has to sleep to obtain entry lock, it will
    fail to unlock mapping->i_pages spinlock and thus immediately deadlock
    against itself when retrying to grab the entry lock again. Fix the
    problem by unlocking mapping->i_pages before retrying.
    
    Fixes: c2a7d2a11552 ("filesystem-dax: Introduce dax_lock_mapping_entry()")
    Reported-by: Barret Rhoden <brho@google.com>
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Dan Williams <dan.j.williams@intel.com>

diff --git a/fs/dax.c b/fs/dax.c
index f32d7125ad0f..e4ef8af31aa6 100644
--- a/fs/dax.c
+++ b/fs/dax.c
@@ -447,6 +447,7 @@ bool dax_lock_mapping_entry(struct page *page)
                        xa_unlock_irq(&mapping->i_pages);
                        break;
                } else if (IS_ERR(entry)) {
+                       xa_unlock_irq(&mapping->i_pages);
                        WARN_ON_ONCE(PTR_ERR(entry) != -EAGAIN);
                        continue;
                }
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] filesystem-dax fix for 4.19-rc6
  2018-09-30  2:16 [GIT PULL] filesystem-dax fix for 4.19-rc6 Williams, Dan J
@ 2018-09-30 13:38 ` gregkh
  0 siblings, 0 replies; 2+ messages in thread
From: gregkh @ 2018-09-30 13:38 UTC (permalink / raw)
  To: Williams, Dan J; +Cc: linux-kernel, linux-nvdimm

On Sun, Sep 30, 2018 at 02:16:57AM +0000, Williams, Dan J wrote:
> Hi Greg, please pull from...
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm tags/libnvdimm-fixes2-4.19-rc6
> 
> ...to receive one more urgent fix for 4.19-rc6.

Now pulled, thanks.

greg k-h
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-30 13:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-30  2:16 [GIT PULL] filesystem-dax fix for 4.19-rc6 Williams, Dan J
2018-09-30 13:38 ` gregkh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).