nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [linux-nvdimm:libnvdimm-fixes 2/3] drivers/dax/super.c:325:6: error: redefinition of 'dax_supported'
@ 2020-09-20 23:12 kernel test robot
  2020-09-21  9:53 ` Jan Kara
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-09-20 23:12 UTC (permalink / raw)
  To: Jan Kara; +Cc: kbuild-all, clang-built-linux, linux-nvdimm

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-fixes
head:   d4c5da5049ac27c6ef8f6f98548c3a1ade352d25
commit: e2ec5128254518cae320d5dc631b71b94160f663 [2/3] dm: Call proper helper to determine dax support
config: x86_64-randconfig-a011-20200920 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project f4e554180962aa6bc93678898b6933ea712bde50)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        git checkout e2ec5128254518cae320d5dc631b71b94160f663
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/dax/super.c:325:6: error: redefinition of 'dax_supported'
   bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
        ^
   include/linux/dax.h:162:20: note: previous definition is here
   static inline bool dax_supported(struct dax_device *dax_dev,
                      ^
   drivers/dax/super.c:451:6: warning: no previous prototype for function 'run_dax' [-Wmissing-prototypes]
   void run_dax(struct dax_device *dax_dev)
        ^
   drivers/dax/super.c:451:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void run_dax(struct dax_device *dax_dev)
   ^
   static 
   1 warning and 1 error generated.

# https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/commit/?id=e2ec5128254518cae320d5dc631b71b94160f663
git remote add linux-nvdimm https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
git fetch --no-tags linux-nvdimm libnvdimm-fixes
git checkout e2ec5128254518cae320d5dc631b71b94160f663
vim +/dax_supported +325 drivers/dax/super.c

b0686260fecaa9 Dan Williams 2017-01-26  324  
7bf7eac8d64805 Dan Williams 2019-05-16 @325  bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
7bf7eac8d64805 Dan Williams 2019-05-16  326  		int blocksize, sector_t start, sector_t len)
7bf7eac8d64805 Dan Williams 2019-05-16  327  {
e2ec5128254518 Jan Kara     2020-09-20  328  	if (!dax_dev)
e2ec5128254518 Jan Kara     2020-09-20  329  		return false;
e2ec5128254518 Jan Kara     2020-09-20  330  
7bf7eac8d64805 Dan Williams 2019-05-16  331  	if (!dax_alive(dax_dev))
7bf7eac8d64805 Dan Williams 2019-05-16  332  		return false;
7bf7eac8d64805 Dan Williams 2019-05-16  333  
7bf7eac8d64805 Dan Williams 2019-05-16  334  	return dax_dev->ops->dax_supported(dax_dev, bdev, blocksize, start, len);
7bf7eac8d64805 Dan Williams 2019-05-16  335  }
e2ec5128254518 Jan Kara     2020-09-20  336  EXPORT_SYMBOL_GPL(dax_supported);
7bf7eac8d64805 Dan Williams 2019-05-16  337  

:::::: The code at line 325 was first introduced by commit
:::::: 7bf7eac8d648057519adb6fce1e31458c902212c dax: Arrange for dax_supported check to span multiple devices

:::::: TO: Dan Williams <dan.j.williams@intel.com>
:::::: CC: Dan Williams <dan.j.williams@intel.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply	[flat|nested] 2+ messages in thread
* Re: [linux-nvdimm:libnvdimm-fixes 2/3] drivers/dax/super.c:325:6: error: redefinition of 'dax_supported'
  2020-09-20 23:12 [linux-nvdimm:libnvdimm-fixes 2/3] drivers/dax/super.c:325:6: error: redefinition of 'dax_supported' kernel test robot
@ 2020-09-21  9:53 ` Jan Kara
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2020-09-21  9:53 UTC (permalink / raw)
  To: kernel test robot; +Cc: Jan Kara, kbuild-all, clang-built-linux, linux-nvdimm

[-- Attachment #1: Type: text/plain, Size: 1964 bytes --]

On Mon 21-09-20 07:12:11, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-fixes
> head:   d4c5da5049ac27c6ef8f6f98548c3a1ade352d25
> commit: e2ec5128254518cae320d5dc631b71b94160f663 [2/3] dm: Call proper helper to determine dax support
> config: x86_64-randconfig-a011-20200920 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project f4e554180962aa6bc93678898b6933ea712bde50)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install x86_64 cross compiling tool for clang build
>         # apt-get install binutils-x86-64-linux-gnu
>         git checkout e2ec5128254518cae320d5dc631b71b94160f663
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/dax/super.c:325:6: error: redefinition of 'dax_supported'
>    bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
>         ^
>    include/linux/dax.h:162:20: note: previous definition is here
>    static inline bool dax_supported(struct dax_device *dax_dev,
>                       ^
>    drivers/dax/super.c:451:6: warning: no previous prototype for function 'run_dax' [-Wmissing-prototypes]
>    void run_dax(struct dax_device *dax_dev)
>         ^
>    drivers/dax/super.c:451:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>    void run_dax(struct dax_device *dax_dev)
>    ^
>    static 
>    1 warning and 1 error generated.

Attached patch should fix the build error.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

[-- Attachment #2: 0001-dax-Fix-compilation-for-CONFIG_DAX-CONFIG_FS_DAX.patch --]
[-- Type: text/x-patch, Size: 2388 bytes --]

From c48c9d1ee41ca17561dfd7ec5247b5afc527d40e Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Mon, 21 Sep 2020 11:33:23 +0200
Subject: [PATCH] dax: Fix compilation for CONFIG_DAX && !CONFIG_FS_DAX

dax_supported() is defined whenever CONFIG_DAX is enabled. So dummy
implementation should be defined only in !CONFIG_DAX case, not in
!CONFIG_FS_DAX case.

Fixes: e2ec51282545 ("dm: Call proper helper to determine dax support")
Cc: <stable@vger.kernel.org>
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---
 include/linux/dax.h | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/include/linux/dax.h b/include/linux/dax.h
index 497031392e0a..43b39ab9de1a 100644
--- a/include/linux/dax.h
+++ b/include/linux/dax.h
@@ -58,6 +58,8 @@ static inline void set_dax_synchronous(struct dax_device *dax_dev)
 {
 	__set_dax_synchronous(dax_dev);
 }
+bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
+		int blocksize, sector_t start, sector_t len);
 /*
  * Check if given mapping is supported by the file / underlying device.
  */
@@ -104,6 +106,12 @@ static inline bool dax_synchronous(struct dax_device *dax_dev)
 static inline void set_dax_synchronous(struct dax_device *dax_dev)
 {
 }
+static inline bool dax_supported(struct dax_device *dax_dev,
+		struct block_device *bdev, int blocksize, sector_t start,
+		sector_t len)
+{
+	return false;
+}
 static inline bool daxdev_mapping_supported(struct vm_area_struct *vma,
 				struct dax_device *dax_dev)
 {
@@ -130,8 +138,6 @@ static inline bool generic_fsdax_supported(struct dax_device *dax_dev,
 	return __generic_fsdax_supported(dax_dev, bdev, blocksize, start,
 			sectors);
 }
-bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
-		int blocksize, sector_t start, sector_t len);
 
 static inline void fs_put_dax(struct dax_device *dax_dev)
 {
@@ -159,13 +165,6 @@ static inline bool generic_fsdax_supported(struct dax_device *dax_dev,
 	return false;
 }
 
-static inline bool dax_supported(struct dax_device *dax_dev,
-		struct block_device *bdev, int blocksize, sector_t start,
-		sector_t len)
-{
-	return false;
-}
-
 static inline void fs_put_dax(struct dax_device *dax_dev)
 {
 }
-- 
2.16.4


[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org

^ permalink raw reply related	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-21  9:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-20 23:12 [linux-nvdimm:libnvdimm-fixes 2/3] drivers/dax/super.c:325:6: error: redefinition of 'dax_supported' kernel test robot
2020-09-21  9:53 ` Jan Kara

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).