* simplify gendisk and request_queue allocation for bio based drivers
@ 2021-05-21 5:50 Christoph Hellwig
0 siblings, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2021-05-21 5:50 UTC (permalink / raw)
To: Jens Axboe, Geert Uytterhoeven, Chris Zankel, Max Filippov,
Philipp Reisner, Lars Ellenberg, Jim Paris, Joshua Morris,
Philip Kelleher, Minchan Kim, Nitin Gupta, Matias Bjorling,
Coly Li, Mike Snitzer, Song Liu, Maxim Levitsky, Alex Dubov,
Ulf Hansson, Dan Williams, Vishal Verma, Dave Jiang,
Heiko Carstens, Vasily Gorbik, Christian Borntraeger
Cc: linux-block, dm-devel, linux-m68k, linux-xtensa, drbd-dev,
open list:PS3 PLATFORM SUPPORT, linux-bcache, linux-raid,
linux-mmc, nvdimm, linux-nvme, linux-s390
Hi all,
this series is the first part of cleaning up lifetimes and allocation of
the gendisk and request_queue structure. It adds a new interface to
allocate the disk and queue together for bio based drivers, and a helper
for cleanup/free them when a driver is unloaded or a device is removed.
Together this removes the need to treat the gendisk and request_queue
as separate entities for bio based drivers.
Diffstat:
arch/m68k/emu/nfblock.c | 20 +---
arch/xtensa/platforms/iss/simdisk.c | 29 +------
block/blk-core.c | 1
block/blk.h | 6 -
block/genhd.c | 149 +++++++++++++++++++-----------------
block/partitions/core.c | 19 ++--
drivers/block/brd.c | 94 +++++++---------------
drivers/block/drbd/drbd_main.c | 23 +----
drivers/block/n64cart.c | 8 -
drivers/block/null_blk/main.c | 38 ++++-----
drivers/block/pktcdvd.c | 11 --
drivers/block/ps3vram.c | 31 +------
drivers/block/rsxx/dev.c | 39 +++------
drivers/block/rsxx/rsxx_priv.h | 1
drivers/block/zram/zram_drv.c | 19 ----
drivers/lightnvm/core.c | 24 +----
drivers/md/bcache/super.c | 15 ---
drivers/md/dm.c | 16 +--
drivers/md/md.c | 25 ++----
drivers/memstick/core/ms_block.c | 1
drivers/nvdimm/blk.c | 27 +-----
drivers/nvdimm/btt.c | 25 +-----
drivers/nvdimm/btt.h | 2
drivers/nvdimm/pmem.c | 17 +---
drivers/nvme/host/core.c | 1
drivers/nvme/host/multipath.c | 46 +++--------
drivers/s390/block/dcssblk.c | 26 +-----
drivers/s390/block/xpram.c | 26 ++----
include/linux/blkdev.h | 1
include/linux/genhd.h | 23 +++++
30 files changed, 297 insertions(+), 466 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* simplify gendisk and request_queue allocation for bio based drivers
@ 2021-05-21 5:50 Christoph Hellwig
2021-05-25 22:41 ` Ulf Hansson
2021-06-01 13:48 ` Jens Axboe
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2021-05-21 5:50 UTC (permalink / raw)
To: Jens Axboe, Geert Uytterhoeven, Chris Zankel, Max Filippov,
Philipp Reisner, Lars Ellenberg, Jim Paris, Joshua Morris,
Philip Kelleher, Minchan Kim, Nitin Gupta, Matias Bjorling,
Coly Li, Mike Snitzer, Song Liu, Maxim Levitsky, Alex Dubov,
Ulf Hansson, Dan Williams, Vishal Verma, Dave Jiang,
Heiko Carstens, Vasily Gorbik, Christian Borntraeger
Cc: linux-block, dm-devel, linux-m68k, linux-xtensa, drbd-dev,
linuxppc-dev, linux-bcache, linux-raid, linux-mmc, nvdimm,
linux-nvme, linux-s390
Hi all,
this series is the first part of cleaning up lifetimes and allocation of
the gendisk and request_queue structure. It adds a new interface to
allocate the disk and queue together for bio based drivers, and a helper
for cleanup/free them when a driver is unloaded or a device is removed.
Together this removes the need to treat the gendisk and request_queue
as separate entities for bio based drivers.
Diffstat:
arch/m68k/emu/nfblock.c | 20 +---
arch/xtensa/platforms/iss/simdisk.c | 29 +------
block/blk-core.c | 1
block/blk.h | 6 -
block/genhd.c | 149 +++++++++++++++++++-----------------
block/partitions/core.c | 19 ++--
drivers/block/brd.c | 94 +++++++---------------
drivers/block/drbd/drbd_main.c | 23 +----
drivers/block/n64cart.c | 8 -
drivers/block/null_blk/main.c | 38 ++++-----
drivers/block/pktcdvd.c | 11 --
drivers/block/ps3vram.c | 31 +------
drivers/block/rsxx/dev.c | 39 +++------
drivers/block/rsxx/rsxx_priv.h | 1
drivers/block/zram/zram_drv.c | 19 ----
drivers/lightnvm/core.c | 24 +----
drivers/md/bcache/super.c | 15 ---
drivers/md/dm.c | 16 +--
drivers/md/md.c | 25 ++----
drivers/memstick/core/ms_block.c | 1
drivers/nvdimm/blk.c | 27 +-----
drivers/nvdimm/btt.c | 25 +-----
drivers/nvdimm/btt.h | 2
drivers/nvdimm/pmem.c | 17 +---
drivers/nvme/host/core.c | 1
drivers/nvme/host/multipath.c | 46 +++--------
drivers/s390/block/dcssblk.c | 26 +-----
drivers/s390/block/xpram.c | 26 ++----
include/linux/blkdev.h | 1
include/linux/genhd.h | 23 +++++
30 files changed, 297 insertions(+), 466 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: simplify gendisk and request_queue allocation for bio based drivers
2021-05-21 5:50 Christoph Hellwig
@ 2021-05-25 22:41 ` Ulf Hansson
2021-05-26 4:49 ` Christoph Hellwig
2021-06-01 13:48 ` Jens Axboe
1 sibling, 1 reply; 6+ messages in thread
From: Ulf Hansson @ 2021-05-25 22:41 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Geert Uytterhoeven, Chris Zankel, Max Filippov,
Philipp Reisner, Lars Ellenberg, Jim Paris, Joshua Morris,
Philip Kelleher, Minchan Kim, Nitin Gupta, Matias Bjorling,
Coly Li, Mike Snitzer, Song Liu, Maxim Levitsky, Alex Dubov,
Dan Williams, Vishal Verma, Dave Jiang, Heiko Carstens,
Vasily Gorbik, Christian Borntraeger, linux-block, dm-devel,
linux-m68k, linux-xtensa, drbd-dev, linuxppc-dev, linux-bcache,
linux-raid, linux-mmc, nvdimm, linux-nvme, linux-s390
On Fri, 21 May 2021 at 07:51, Christoph Hellwig <hch@lst.de> wrote:
>
> Hi all,
>
> this series is the first part of cleaning up lifetimes and allocation of
> the gendisk and request_queue structure. It adds a new interface to
> allocate the disk and queue together for bio based drivers, and a helper
> for cleanup/free them when a driver is unloaded or a device is removed.
May I ask what else you have in the pipe for the next steps?
The reason why I ask is that I am looking into some issues related to
lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card
removal.
>
> Together this removes the need to treat the gendisk and request_queue
> as separate entities for bio based drivers.
>
> Diffstat:
> arch/m68k/emu/nfblock.c | 20 +---
> arch/xtensa/platforms/iss/simdisk.c | 29 +------
> block/blk-core.c | 1
> block/blk.h | 6 -
> block/genhd.c | 149 +++++++++++++++++++-----------------
> block/partitions/core.c | 19 ++--
> drivers/block/brd.c | 94 +++++++---------------
> drivers/block/drbd/drbd_main.c | 23 +----
> drivers/block/n64cart.c | 8 -
> drivers/block/null_blk/main.c | 38 ++++-----
> drivers/block/pktcdvd.c | 11 --
> drivers/block/ps3vram.c | 31 +------
> drivers/block/rsxx/dev.c | 39 +++------
> drivers/block/rsxx/rsxx_priv.h | 1
> drivers/block/zram/zram_drv.c | 19 ----
> drivers/lightnvm/core.c | 24 +----
> drivers/md/bcache/super.c | 15 ---
> drivers/md/dm.c | 16 +--
> drivers/md/md.c | 25 ++----
> drivers/memstick/core/ms_block.c | 1
> drivers/nvdimm/blk.c | 27 +-----
> drivers/nvdimm/btt.c | 25 +-----
> drivers/nvdimm/btt.h | 2
> drivers/nvdimm/pmem.c | 17 +---
> drivers/nvme/host/core.c | 1
> drivers/nvme/host/multipath.c | 46 +++--------
> drivers/s390/block/dcssblk.c | 26 +-----
> drivers/s390/block/xpram.c | 26 ++----
> include/linux/blkdev.h | 1
> include/linux/genhd.h | 23 +++++
> 30 files changed, 297 insertions(+), 466 deletions(-)
This looks like a nice cleanup to me. Feel free to add, for the series:
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: simplify gendisk and request_queue allocation for bio based drivers
2021-05-25 22:41 ` Ulf Hansson
@ 2021-05-26 4:49 ` Christoph Hellwig
2021-05-26 8:07 ` Ulf Hansson
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2021-05-26 4:49 UTC (permalink / raw)
To: Ulf Hansson
Cc: Christoph Hellwig, Jens Axboe, Geert Uytterhoeven, Chris Zankel,
Max Filippov, Philipp Reisner, Lars Ellenberg, Jim Paris,
Joshua Morris, Philip Kelleher, Minchan Kim, Nitin Gupta,
Matias Bjorling, Coly Li, Mike Snitzer, Song Liu, Maxim Levitsky,
Alex Dubov, Dan Williams, Vishal Verma, Dave Jiang,
Heiko Carstens, Vasily Gorbik, Christian Borntraeger,
linux-block, dm-devel, linux-m68k, linux-xtensa, drbd-dev,
linuxppc-dev, linux-bcache, linux-raid, linux-mmc, nvdimm,
linux-nvme, linux-s390
On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote:
> On Fri, 21 May 2021 at 07:51, Christoph Hellwig <hch@lst.de> wrote:
> >
> > Hi all,
> >
> > this series is the first part of cleaning up lifetimes and allocation of
> > the gendisk and request_queue structure. It adds a new interface to
> > allocate the disk and queue together for bio based drivers, and a helper
> > for cleanup/free them when a driver is unloaded or a device is removed.
>
> May I ask what else you have in the pipe for the next steps?
>
> The reason why I ask is that I am looking into some issues related to
> lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card
> removal.
In the short run not much more than superficial cleanups. Eventually
I want bio based drivers to not require a separate request_queue, leaving
that purely as a data structure for blk-mq based drivers. But it will
take a while until we get there, so it should not block any fixes.
For hot unplug handling it might be worth to take a look at nvme, as it
is tested a lot for that case.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: simplify gendisk and request_queue allocation for bio based drivers
2021-05-26 4:49 ` Christoph Hellwig
@ 2021-05-26 8:07 ` Ulf Hansson
0 siblings, 0 replies; 6+ messages in thread
From: Ulf Hansson @ 2021-05-26 8:07 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Jens Axboe, Geert Uytterhoeven, Chris Zankel, Max Filippov,
Philipp Reisner, Lars Ellenberg, Jim Paris, Joshua Morris,
Philip Kelleher, Minchan Kim, Nitin Gupta, Matias Bjorling,
Coly Li, Mike Snitzer, Song Liu, Maxim Levitsky, Alex Dubov,
Dan Williams, Vishal Verma, Dave Jiang, Heiko Carstens,
Vasily Gorbik, Christian Borntraeger, linux-block, dm-devel,
linux-m68k, linux-xtensa, drbd-dev, linuxppc-dev, linux-bcache,
linux-raid, linux-mmc, nvdimm, linux-nvme, linux-s390
On Wed, 26 May 2021 at 06:49, Christoph Hellwig <hch@lst.de> wrote:
>
> On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote:
> > On Fri, 21 May 2021 at 07:51, Christoph Hellwig <hch@lst.de> wrote:
> > >
> > > Hi all,
> > >
> > > this series is the first part of cleaning up lifetimes and allocation of
> > > the gendisk and request_queue structure. It adds a new interface to
> > > allocate the disk and queue together for bio based drivers, and a helper
> > > for cleanup/free them when a driver is unloaded or a device is removed.
> >
> > May I ask what else you have in the pipe for the next steps?
> >
> > The reason why I ask is that I am looking into some issues related to
> > lifecycle problems of gendisk/mmc, typically triggered at SD/MMC card
> > removal.
>
> In the short run not much more than superficial cleanups. Eventually
> I want bio based drivers to not require a separate request_queue, leaving
> that purely as a data structure for blk-mq based drivers. But it will
> take a while until we get there, so it should not block any fixes.
Alright, thanks for clarifying.
>
> For hot unplug handling it might be worth to take a look at nvme, as it
> is tested a lot for that case.
Okay, thanks for the hint.
Kind regards
Uffe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: simplify gendisk and request_queue allocation for bio based drivers
2021-05-21 5:50 Christoph Hellwig
2021-05-25 22:41 ` Ulf Hansson
@ 2021-06-01 13:48 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2021-06-01 13:48 UTC (permalink / raw)
To: Christoph Hellwig, Geert Uytterhoeven, Chris Zankel,
Max Filippov, Philipp Reisner, Lars Ellenberg, Jim Paris,
Joshua Morris, Philip Kelleher, Minchan Kim, Nitin Gupta,
Matias Bjorling, Coly Li, Mike Snitzer, Song Liu, Maxim Levitsky,
Alex Dubov, Ulf Hansson, Dan Williams, Vishal Verma, Dave Jiang,
Heiko Carstens, Vasily Gorbik, Christian Borntraeger
Cc: linux-block, dm-devel, linux-m68k, linux-xtensa, drbd-dev,
linuxppc-dev, linux-bcache, linux-raid, linux-mmc, nvdimm,
linux-nvme, linux-s390
On 5/20/21 11:50 PM, Christoph Hellwig wrote:
> Hi all,
>
> this series is the first part of cleaning up lifetimes and allocation of
> the gendisk and request_queue structure. It adds a new interface to
> allocate the disk and queue together for bio based drivers, and a helper
> for cleanup/free them when a driver is unloaded or a device is removed.
>
> Together this removes the need to treat the gendisk and request_queue
> as separate entities for bio based drivers.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-01 13:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-21 5:50 simplify gendisk and request_queue allocation for bio based drivers Christoph Hellwig
2021-05-21 5:50 Christoph Hellwig
2021-05-25 22:41 ` Ulf Hansson
2021-05-26 4:49 ` Christoph Hellwig
2021-05-26 8:07 ` Ulf Hansson
2021-06-01 13:48 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).