From: Taylor Stark <tstark@linux.microsoft.com>
To: dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ira.weiny@intel.com
Cc: nvdimm@lists.linux.dev, apais@microsoft.com,
tyhicks@microsoft.com, jamorris@microsoft.com,
benhill@microsoft.com, sunilmut@microsoft.com,
grahamwo@microsoft.com, tstark@microsoft.com
Subject: [PATCH v2 1/2] virtio-pmem: Support PCI BAR-relative addresses
Date: Thu, 15 Jul 2021 15:35:05 -0700 [thread overview]
Message-ID: <20210715223505.GA29329@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
Update virtio-pmem to allow for the pmem region to be specified in either
guest absolute terms or as a PCI BAR-relative address. This is required
to support virtio-pmem in Hyper-V, since Hyper-V only allows PCI devices
to operate on PCI memory ranges defined via BARs.
Virtio-pmem will check for a shared memory window and use that if found,
else it will fallback to using the guest absolute addresses in
virtio_pmem_config. This was chosen over defining a new feature bit,
since it's similar to how virtio-fs is configured.
Signed-off-by: Taylor Stark <tstark@microsoft.com>
---
drivers/nvdimm/virtio_pmem.c | 21 +++++++++++++++++----
drivers/nvdimm/virtio_pmem.h | 3 +++
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/drivers/nvdimm/virtio_pmem.c b/drivers/nvdimm/virtio_pmem.c
index 726c7354d465..43c1d835a449 100644
--- a/drivers/nvdimm/virtio_pmem.c
+++ b/drivers/nvdimm/virtio_pmem.c
@@ -37,6 +37,8 @@ static int virtio_pmem_probe(struct virtio_device *vdev)
struct virtio_pmem *vpmem;
struct resource res;
int err = 0;
+ bool have_shm_region;
+ struct virtio_shm_region pmem_region;
if (!vdev->config->get) {
dev_err(&vdev->dev, "%s failure: config access disabled\n",
@@ -58,10 +60,21 @@ static int virtio_pmem_probe(struct virtio_device *vdev)
goto out_err;
}
- virtio_cread_le(vpmem->vdev, struct virtio_pmem_config,
- start, &vpmem->start);
- virtio_cread_le(vpmem->vdev, struct virtio_pmem_config,
- size, &vpmem->size);
+ /* Retrieve the pmem device's address and size. It may have been supplied
+ * as a PCI BAR-relative shared memory region, or as a guest absolute address.
+ */
+ have_shm_region = virtio_get_shm_region(vpmem->vdev, &pmem_region,
+ VIRTIO_PMEM_SHMCAP_ID_PMEM_REGION);
+
+ if (have_shm_region) {
+ vpmem->start = pmem_region.addr;
+ vpmem->size = pmem_region.len;
+ } else {
+ virtio_cread_le(vpmem->vdev, struct virtio_pmem_config,
+ start, &vpmem->start);
+ virtio_cread_le(vpmem->vdev, struct virtio_pmem_config,
+ size, &vpmem->size);
+ }
res.start = vpmem->start;
res.end = vpmem->start + vpmem->size - 1;
diff --git a/drivers/nvdimm/virtio_pmem.h b/drivers/nvdimm/virtio_pmem.h
index 0dddefe594c4..62bb564e81cb 100644
--- a/drivers/nvdimm/virtio_pmem.h
+++ b/drivers/nvdimm/virtio_pmem.h
@@ -50,6 +50,9 @@ struct virtio_pmem {
__u64 size;
};
+/* For the id field in virtio_pci_shm_cap */
+#define VIRTIO_PMEM_SHMCAP_ID_PMEM_REGION 0
+
void virtio_pmem_host_ack(struct virtqueue *vq);
int async_pmem_flush(struct nd_region *nd_region, struct bio *bio);
#endif
--
2.32.0
next reply other threads:[~2021-07-15 22:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 22:35 Taylor Stark [this message]
2021-07-19 20:36 ` [PATCH v2 1/2] virtio-pmem: Support PCI BAR-relative addresses Pankaj Gupta
2021-07-20 6:35 ` Taylor Stark
2021-07-20 6:51 ` Pankaj Gupta
2021-07-21 22:08 ` Taylor Stark
2021-07-22 4:40 ` Pankaj Gupta
2021-08-25 0:29 ` Dan Williams
2021-08-25 21:46 ` Taylor Stark
2021-08-25 21:59 ` Dan Williams
2021-07-19 21:17 ` Michael S. Tsirkin
2021-07-20 6:41 ` Taylor Stark
2021-07-20 9:46 ` Michael S. Tsirkin
2021-07-21 21:18 ` Taylor Stark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210715223505.GA29329@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=tstark@linux.microsoft.com \
--cc=apais@microsoft.com \
--cc=benhill@microsoft.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=grahamwo@microsoft.com \
--cc=ira.weiny@intel.com \
--cc=jamorris@microsoft.com \
--cc=nvdimm@lists.linux.dev \
--cc=sunilmut@microsoft.com \
--cc=tstark@microsoft.com \
--cc=tyhicks@microsoft.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).