From: Pankaj Gupta <pankaj.gupta@ionos.com>
To: Taylor Stark <tstark@linux.microsoft.com>
Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Dan Williams <dan.j.williams@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
nvdimm@lists.linux.dev, apais@microsoft.com,
tyhicks@microsoft.com, jamorris@microsoft.com,
benhill@microsoft.com, sunilmut@microsoft.com,
grahamwo@microsoft.com, tstark@microsoft.com,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 1/2] virtio-pmem: Support PCI BAR-relative addresses
Date: Tue, 20 Jul 2021 08:51:04 +0200 [thread overview]
Message-ID: <CALzYo30-fzcQMDVEhKMAGmzXO5hvtd-J6CtavesAUzaQjcpDcg@mail.gmail.com> (raw)
In-Reply-To: <20210720063510.GB8476@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
> > >
> > > - virtio_cread_le(vpmem->vdev, struct virtio_pmem_config,
> > > - start, &vpmem->start);
> > > - virtio_cread_le(vpmem->vdev, struct virtio_pmem_config,
> > > - size, &vpmem->size);
> > > + /* Retrieve the pmem device's address and size. It may have been supplied
> > > + * as a PCI BAR-relative shared memory region, or as a guest absolute address.
> > > + */
> > > + have_shm_region = virtio_get_shm_region(vpmem->vdev, &pmem_region,
> > > + VIRTIO_PMEM_SHMCAP_ID_PMEM_REGION);
> >
> > Current implementation of Virtio pmem device in Qemu does not expose
> > it as PCI BAR.
> > So, can't test it. Just curious if device side implementation is also
> > tested for asynchronous
> > flush case?
> >
> > Thanks,
> > Pankaj
>
> Yes, I tested the async flush case as well. We basically call
> FlushFileBuffers on the backing file, which is Windows' equivalent of
> fsync. I also briefly tested with qemu to ensure that still works with
> the patch.
Thank you for the confirmation. This sounds really good.
I am also getting back to pending items for virtio-pmem.
On a side question: Do you guys have any or plan for Windows guest
implementation
for virtio-pmem?
Thanks,
Pankaj
next prev parent reply other threads:[~2021-07-20 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 22:35 [PATCH v2 1/2] virtio-pmem: Support PCI BAR-relative addresses Taylor Stark
2021-07-19 20:36 ` Pankaj Gupta
2021-07-20 6:35 ` Taylor Stark
2021-07-20 6:51 ` Pankaj Gupta [this message]
2021-07-21 22:08 ` Taylor Stark
2021-07-22 4:40 ` Pankaj Gupta
2021-08-25 0:29 ` Dan Williams
2021-08-25 21:46 ` Taylor Stark
2021-08-25 21:59 ` Dan Williams
2021-07-19 21:17 ` Michael S. Tsirkin
2021-07-20 6:41 ` Taylor Stark
2021-07-20 9:46 ` Michael S. Tsirkin
2021-07-21 21:18 ` Taylor Stark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALzYo30-fzcQMDVEhKMAGmzXO5hvtd-J6CtavesAUzaQjcpDcg@mail.gmail.com \
--to=pankaj.gupta@ionos.com \
--cc=apais@microsoft.com \
--cc=benhill@microsoft.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=grahamwo@microsoft.com \
--cc=ira.weiny@intel.com \
--cc=jamorris@microsoft.com \
--cc=mst@redhat.com \
--cc=nvdimm@lists.linux.dev \
--cc=pankaj.gupta.linux@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=tstark@linux.microsoft.com \
--cc=tstark@microsoft.com \
--cc=tyhicks@microsoft.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).