* [ndctl PATCH] ndctl, bash completion: add completion for update-firmware
@ 2018-02-02 22:52 Vishal Verma
2018-02-02 23:08 ` Dave Jiang
0 siblings, 1 reply; 2+ messages in thread
From: Vishal Verma @ 2018-02-02 22:52 UTC (permalink / raw)
To: linux-nvdimm
Add filename completion for --firmware. dimm completion is already in
place from other commands that use dimms.
Cc: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
contrib/ndctl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/ndctl b/contrib/ndctl
index fb0d421..eeda1c4 100755
--- a/contrib/ndctl
+++ b/contrib/ndctl
@@ -91,7 +91,7 @@ __ndctlcomp()
COMPREPLY=( $( compgen -W "$1" -- "$2" ) )
for cword in "${COMPREPLY[@]}"; do
- if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace|--input|--output|--label-version|--align|--block|--count) ]]; then
+ if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace|--input|--output|--label-version|--align|--block|--count|--firmware) ]]; then
COMPREPLY[$i]="${cword}="
else
COMPREPLY[$i]="${cword} "
@@ -202,6 +202,8 @@ __ndctl_comp_options()
--output)
;&
--input)
+ ;&
+ --firmware)
__ndctl_file_comp "${cur##*=}"
return
;;
--
2.14.3
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [ndctl PATCH] ndctl, bash completion: add completion for update-firmware
2018-02-02 22:52 [ndctl PATCH] ndctl, bash completion: add completion for update-firmware Vishal Verma
@ 2018-02-02 23:08 ` Dave Jiang
0 siblings, 0 replies; 2+ messages in thread
From: Dave Jiang @ 2018-02-02 23:08 UTC (permalink / raw)
To: Vishal Verma, linux-nvdimm
On 02/02/2018 03:52 PM, Vishal Verma wrote:
> Add filename completion for --firmware. dimm completion is already in
> place from other commands that use dimms.
>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
Thanks!
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> contrib/ndctl | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/contrib/ndctl b/contrib/ndctl
> index fb0d421..eeda1c4 100755
> --- a/contrib/ndctl
> +++ b/contrib/ndctl
> @@ -91,7 +91,7 @@ __ndctlcomp()
>
> COMPREPLY=( $( compgen -W "$1" -- "$2" ) )
> for cword in "${COMPREPLY[@]}"; do
> - if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace|--input|--output|--label-version|--align|--block|--count) ]]; then
> + if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace|--input|--output|--label-version|--align|--block|--count|--firmware) ]]; then
> COMPREPLY[$i]="${cword}="
> else
> COMPREPLY[$i]="${cword} "
> @@ -202,6 +202,8 @@ __ndctl_comp_options()
> --output)
> ;&
> --input)
> + ;&
> + --firmware)
> __ndctl_file_comp "${cur##*=}"
> return
> ;;
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-02 23:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-02 22:52 [ndctl PATCH] ndctl, bash completion: add completion for update-firmware Vishal Verma
2018-02-02 23:08 ` Dave Jiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).