From: Dave Hansen <dave.hansen@intel.com>
To: Zhang Yi <yi.z.zhang@linux.intel.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-nvdimm@lists.01.org, pbonzini@redhat.com,
dan.j.williams@intel.com, dave.jiang@intel.com,
yu.c.zhang@intel.com, pagupta@redhat.com, david@redhat.com,
jack@suse.cz, hch@lst.de
Cc: linux-mm@kvack.org, jglisse@redhat.com, yi.z.zhang@intel.com,
rkrcmar@redhat.com
Subject: Re: [PATCH V4 4/4] kvm: add a check if pfn is from NVDIMM pmem.
Date: Thu, 30 Aug 2018 12:07:11 -0700 [thread overview]
Message-ID: <4192066a-79f3-2b3e-386f-c4ec9b6dd8fd@intel.com> (raw)
In-Reply-To: <a4183c0f0adfb6d123599dd306062fd193e83f5a.1534934405.git.yi.z.zhang@linux.intel.com>
On 08/22/2018 03:58 AM, Zhang Yi wrote:
> bool kvm_is_reserved_pfn(kvm_pfn_t pfn)
> {
> - if (pfn_valid(pfn))
> - return PageReserved(pfn_to_page(pfn));
> + struct page *page;
> +
> + if (pfn_valid(pfn)) {
> + page = pfn_to_page(pfn);
> + return PageReserved(page) && !is_dax_page(page);
> + }
This is in desperate need of commenting about what it is doing and why.
The changelog alone doesn't cut it.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-08-30 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 10:55 [PATCH V4 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-08-22 10:55 ` [PATCH V4 1/4] kvm: remove redundant reserved page check Zhang Yi
2018-08-22 10:56 ` [PATCH V4 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-09-19 2:43 ` Pankaj Gupta
2018-08-22 10:56 ` [PATCH V4 3/4] mm: add a function to differentiate the pages is from DAX device memory Zhang Yi
2018-09-19 2:48 ` Pankaj Gupta
2018-08-22 10:58 ` [PATCH V4 4/4] kvm: add a check if pfn is from NVDIMM pmem Zhang Yi
2018-08-29 10:15 ` Pankaj Gupta
2018-08-30 19:23 ` Yi Zhang
2018-08-30 19:07 ` Dave Hansen [this message]
2018-08-31 16:39 ` Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4192066a-79f3-2b3e-386f-c4ec9b6dd8fd@intel.com \
--to=dave.hansen@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yi.z.zhang@intel.com \
--cc=yi.z.zhang@linux.intel.com \
--cc=yu.c.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).