From: Pankaj Gupta <pagupta@redhat.com>
To: Yi Zhang <yi.z.zhang@linux.intel.com>
Cc: jglisse@redhat.com, yu c zhang <yu.c.zhang@intel.com>,
kvm@vger.kernel.org, linux-nvdimm@lists.01.org, jack@suse.cz,
david@redhat.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, rkrcmar@redhat.com, pbonzini@redhat.com,
hch@lst.de, yi z zhang <yi.z.zhang@intel.com>
Subject: Re: [PATCH V5 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio
Date: Tue, 18 Sep 2018 22:43:06 -0400 (EDT) [thread overview]
Message-ID: <900140442.13987264.1537324986294.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180919105505.GA43643@tiger-server>
Hello Yi,
> Any comments?
>
> Hi Pankaj and Paolo,
I am just helping with the review. Paolo & Dan probably will decide.
Thanks,
Pankaj
>
> Can we Queue this to merge list since there no other comments last 2
> weeks?
>
> Regards
> Yi.
>
> On 2018-09-08 at 02:03:02 +0800, Zhang Yi wrote:
> > For device specific memory space, when we move these area of pfn to
> > memory zone, we will set the page reserved flag at that time, some of
> > these reserved for device mmio, and some of these are not, such as
> > NVDIMM pmem.
> >
> > Now, we map these dev_dax or fs_dax pages to kvm for DIMM/NVDIMM
> > backend, since these pages are reserved. the check of
> > kvm_is_reserved_pfn() misconceives those pages as MMIO. Therefor, we
> > introduce 2 page map types, MEMORY_DEVICE_FS_DAX/MEMORY_DEVICE_DEV_DAX,
> > to indentify these pages are from NVDIMM pmem. and let kvm treat these
> > as normal pages.
> >
> > Without this patch, Many operations will be missed due to this
> > mistreatment to pmem pages. For example, a page may not have chance to
> > be unpinned for KVM guest(in kvm_release_pfn_clean); not able to be
> > marked as dirty/accessed(in kvm_set_pfn_dirty/accessed) etc.
> >
> > V1:
> > https://lkml.org/lkml/2018/7/4/91
> >
> > V2:
> > https://lkml.org/lkml/2018/7/10/135
> >
> > V3:
> > https://lkml.org/lkml/2018/8/9/17
> >
> > V4:
> > https://lkml.org/lkml/2018/8/22/17
> >
> > V5:
> > [PATCH V3 1/4] Reviewed-by: David / Acked-by: Pankaj
> > [PATCH V3 2/4] Reviewed-by: Jan
> > [PATCH V3 3/4] Acked-by: Jan
> > [PATCH V3 4/4] Added "Acked-by: Pankaj", Added in-line comments: Dave
> >
> > Zhang Yi (4):
> > kvm: remove redundant reserved page check
> > mm: introduce memory type MEMORY_DEVICE_DEV_DAX
> > mm: add a function to differentiate the pages is from DAX device
> > memory
> > kvm: add a check if pfn is from NVDIMM pmem.
> >
> > drivers/dax/pmem.c | 1 +
> > include/linux/memremap.h | 8 ++++++++
> > include/linux/mm.h | 12 ++++++++++++
> > virt/kvm/kvm_main.c | 24 ++++++++++++++++--------
> > 4 files changed, 37 insertions(+), 8 deletions(-)
> >
> > --
> > 2.7.4
> >
>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
prev parent reply other threads:[~2018-09-19 2:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 18:03 [PATCH V5 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Zhang Yi
2018-09-07 17:04 ` Ahmed S. Darwish
2018-09-18 14:31 ` Yi Zhang
2018-09-07 18:03 ` [PATCH V5 1/4] kvm: remove redundant reserved page check Zhang Yi
2018-09-07 18:03 ` [PATCH V5 2/4] mm: introduce memory type MEMORY_DEVICE_DEV_DAX Zhang Yi
2018-09-07 18:03 ` [PATCH V5 3/4] mm: add a function to differentiate the pages is from DAX device memory Zhang Yi
2018-09-07 18:04 ` [PATCH V5 4/4] kvm: add a check if pfn is from NVDIMM pmem Zhang Yi
2018-09-19 2:53 ` Dan Williams
2018-09-19 7:20 ` David Hildenbrand
2018-09-20 22:49 ` Yi Zhang
2018-09-20 21:19 ` Dan Williams
2018-09-21 22:47 ` Yi Zhang
2018-09-21 14:23 ` David Hildenbrand
2018-09-21 18:17 ` Dan Williams
2018-09-21 19:29 ` David Hildenbrand
2018-10-19 16:33 ` Barret Rhoden
2018-10-22 8:47 ` Yi Zhang
2018-09-19 10:55 ` [PATCH V5 0/4] Fix kvm misconceives NVDIMM pages as reserved mmio Yi Zhang
2018-09-19 2:43 ` Pankaj Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=900140442.13987264.1537324986294.JavaMail.zimbra@redhat.com \
--to=pagupta@redhat.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jglisse@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=yi.z.zhang@intel.com \
--cc=yi.z.zhang@linux.intel.com \
--cc=yu.c.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).