From: Dan Williams <dan.j.williams@intel.com>
To: jmoyer <jmoyer@redhat.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [daxctl PATCH] daxctl: Opt-in to /sys/bus/dax ABI
Date: Wed, 7 Nov 2018 11:54:21 -0800 [thread overview]
Message-ID: <CAPcyv4g1Z2-eykTVE54Sv7xwXk8hy+B9JE4Oc2aQSc0K+qAmbQ@mail.gmail.com> (raw)
In-Reply-To: <x49tvksvfip.fsf@segfault.boston.devel.redhat.com>
On Wed, Nov 7, 2018 at 11:44 AM Jeff Moyer <jmoyer@redhat.com> wrote:
>
> Dan Williams <dan.j.williams@intel.com> writes:
>
> > In support of the kernel's conversion of the dax-subsystem from a
> > 'class' to a 'bus', teach the libdaxctl subsystem-layout-specific code
> > to parse the new layout. The kernel changes do not effect the primary
> > ndctl use case of putting namespaces into 'dax' mode since that uses
> > libnvdimm namespace device relative paths, but it does break 'ndctl list
> > -X' and 'daxctl list'. For that reason the kernel provides a
> > dax_pmem_compat driver to support the old layout and give time for
> > userspace components to switch.
>
> I must've missed this. What kernel commit(s) introduced this change?
Not committed yet, only posted:
https://lore.kernel.org/patchwork/cover/1004684/
> > Installation of the latest libdaxctl package arranges for a daxctl
> > configuration file to be dropped in /etc/modprobe.d. The modprobe
> > configuration blacklists dax_pmem_compat modules and sets the proper
> > alias for the dax_pmem module. The modprobe configuration upgrades the
> > default kernel handling to the /sys/bus/dax scheme.
>
> And what happens when the user boots an old kernel after this new rule
> is put in place?
Just works.
With older kernels there is no such thing as "dax_pmem_compat" and the
default dax_pmem module alias will do the right thing. Newer ndctl /
daxctl understands both ABIs. The only way to cause confusion is to
revert to an older ndctl on a newer kernel *and* leave the override
set to blacklist the compat driver. I.e. you should be able to upgrade
either component kernel or ndctl with no concerns, but would need to
be careful about downgrading ndctl without also removing the override.
I'll check that downgrading via rpm does the right thing.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2018-11-07 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 19:13 [daxctl PATCH] daxctl: Opt-in to /sys/bus/dax ABI Dan Williams
2018-11-07 19:44 ` Jeff Moyer
2018-11-07 19:54 ` Dan Williams [this message]
2018-11-08 19:34 ` Jeff Moyer
2018-11-08 20:56 ` Jeff Moyer
2018-11-08 21:14 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPcyv4g1Z2-eykTVE54Sv7xwXk8hy+B9JE4Oc2aQSc0K+qAmbQ@mail.gmail.com \
--to=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jmoyer@redhat.com \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).