nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: jmoyer <jmoyer@redhat.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
	linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [daxctl PATCH] daxctl: Opt-in to /sys/bus/dax ABI
Date: Thu, 8 Nov 2018 13:14:54 -0800	[thread overview]
Message-ID: <CAPcyv4hq5Z5YtO7MNkx=H34p_fb_U_MKLEb_XNS=BqP=VbnUiQ@mail.gmail.com> (raw)
In-Reply-To: <x49lg63cmp2.fsf@segfault.boston.devel.redhat.com>

On Thu, Nov 8, 2018 at 12:57 PM Jeff Moyer <jmoyer@redhat.com> wrote:
>
> Dan Williams <dan.j.williams@intel.com> writes:
>
> > In support of the kernel's conversion of the dax-subsystem from a
> > 'class' to a 'bus', teach the libdaxctl subsystem-layout-specific code
> > to parse the new layout. The kernel changes do not effect the primary
> > ndctl use case of putting namespaces into 'dax' mode since that uses
> > libnvdimm namespace device relative paths, but it does break 'ndctl list
> > -X' and 'daxctl list'. For that reason the kernel provides a
> > dax_pmem_compat driver to support the old layout and give time for
> > userspace components to switch.
> >
> > Installation of the latest libdaxctl package arranges for a daxctl
> > configuration file to be dropped in /etc/modprobe.d. The modprobe
> > configuration blacklists dax_pmem_compat modules and sets the proper
> > alias for the dax_pmem module. The modprobe configuration upgrades the
> > default kernel handling to the /sys/bus/dax scheme.
>
> OK, one other snafu: pmdk also uses the /sys/class/dax path (see
> src/common/file.c).  Since ndctl isn't the only consumer, we'd have to
> coordinate the class->bus switch among all parties.

Yes, the only way I can see to do this is to whack-a-mole convert
/sys/class/dax users over to libdaxctl. At a minimum I need to
disconnect the opt-in from a package upgrade and make it an explicit
command with a man page explaining the details and consequences.

> Is there a way to just keep the class-based paths working alongside the
> bus interface?

Unfortunately, devices can't have a 'class' and 'bus' association at
the same time because they will collide on the 'subsystem'
designation. The subsystem association is 1:1.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

      reply	other threads:[~2018-11-08 21:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-07 19:13 [daxctl PATCH] daxctl: Opt-in to /sys/bus/dax ABI Dan Williams
2018-11-07 19:44 ` Jeff Moyer
2018-11-07 19:54   ` Dan Williams
2018-11-08 19:34     ` Jeff Moyer
2018-11-08 20:56 ` Jeff Moyer
2018-11-08 21:14   ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPcyv4hq5Z5YtO7MNkx=H34p_fb_U_MKLEb_XNS=BqP=VbnUiQ@mail.gmail.com' \
    --to=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).