* Re: linux-next: Tree for Dec 21 (nvdimm/security.o)
[not found] <20181221193244.3a6ed685@canb.auug.org.au>
@ 2018-12-21 17:08 ` Randy Dunlap
2018-12-21 18:51 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2018-12-21 17:08 UTC (permalink / raw)
To: Stephen Rothwell, Linux Next Mailing List
Cc: Linux Kernel Mailing List, linux-nvdimm
On 12/21/18 12:32 AM, Stephen Rothwell wrote:
> Hi all,
>
> News: there will be no linux-next release until Jan 2. Have a good break.
>
> Changes since 20181220:
>
on x86_64:
ld: drivers/nvdimm/security.o: in function `nvdimm_request_key':
security.c:(.text+0xbe): undefined reference to `key_type_encrypted'
ld: drivers/nvdimm/security.o: in function `nvdimm_lookup_user_key.isra.1':
security.c:(.text+0x1ea): undefined reference to `key_type_encrypted'
Full randconfig file is attached.
--
~Randy
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Dec 21 (nvdimm/security.o)
2018-12-21 17:08 ` linux-next: Tree for Dec 21 (nvdimm/security.o) Randy Dunlap
@ 2018-12-21 18:51 ` Dan Williams
2018-12-21 21:01 ` Dan Williams
0 siblings, 1 reply; 3+ messages in thread
From: Dan Williams @ 2018-12-21 18:51 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-nvdimm
On Fri, Dec 21, 2018 at 10:44 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> On 12/21/18 12:32 AM, Stephen Rothwell wrote:
> > Hi all,
> >
> > News: there will be no linux-next release until Jan 2. Have a good break.
> >
> > Changes since 20181220:
> >
>
> on x86_64:
>
> ld: drivers/nvdimm/security.o: in function `nvdimm_request_key':
> security.c:(.text+0xbe): undefined reference to `key_type_encrypted'
> ld: drivers/nvdimm/security.o: in function `nvdimm_lookup_user_key.isra.1':
> security.c:(.text+0x1ea): undefined reference to `key_type_encrypted'
>
>
> Full randconfig file is attached.
Could you send me that randconfig, offlist is fine.
It seems the "depends on ENCRYPTED_KEYS" I added is not sufficient.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Dec 21 (nvdimm/security.o)
2018-12-21 18:51 ` Dan Williams
@ 2018-12-21 21:01 ` Dan Williams
0 siblings, 0 replies; 3+ messages in thread
From: Dan Williams @ 2018-12-21 21:01 UTC (permalink / raw)
To: Randy Dunlap
Cc: Stephen Rothwell, Linux Next Mailing List,
Linux Kernel Mailing List, linux-nvdimm
On Fri, Dec 21, 2018 at 10:51 AM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Fri, Dec 21, 2018 at 10:44 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > On 12/21/18 12:32 AM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > News: there will be no linux-next release until Jan 2. Have a good break.
> > >
> > > Changes since 20181220:
> > >
> >
> > on x86_64:
> >
> > ld: drivers/nvdimm/security.o: in function `nvdimm_request_key':
> > security.c:(.text+0xbe): undefined reference to `key_type_encrypted'
> > ld: drivers/nvdimm/security.o: in function `nvdimm_lookup_user_key.isra.1':
> > security.c:(.text+0x1ea): undefined reference to `key_type_encrypted'
> >
> >
> > Full randconfig file is attached.
>
> Could you send me that randconfig, offlist is fine.
>
> It seems the "depends on ENCRYPTED_KEYS" I added is not sufficient.
Yup, I overlooked the LIBNVDIMM=y + ENCRYPTED_KEYS=m case.
I folded a fix into the problematic commit and added a Reported-by
credit. The option is now:
config NVDIMM_KEYS
def_bool y
depends on ENCRYPTED_KEYS
depends on (LIBNVDIMM=ENCRYPTED_KEYS) || LIBNVDIMM=m
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-21 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20181221193244.3a6ed685@canb.auug.org.au>
2018-12-21 17:08 ` linux-next: Tree for Dec 21 (nvdimm/security.o) Randy Dunlap
2018-12-21 18:51 ` Dan Williams
2018-12-21 21:01 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).