* [PATCH v2 0/2] virtio-pmem: Support PCI BAR-relative addresses
@ 2021-07-15 22:33 Taylor Stark
2021-08-25 0:35 ` Dan Williams
0 siblings, 1 reply; 4+ messages in thread
From: Taylor Stark @ 2021-07-15 22:33 UTC (permalink / raw)
To: dan.j.williams, vishal.l.verma, dave.jiang, ira.weiny
Cc: nvdimm, apais, tyhicks, jamorris, benhill, sunilmut, grahamwo, tstark
Changes from v1 [1]:
- Fixed a bug where the guest might touch pmem region prior to the
backing file being mapped into the guest's address space.
[1]: https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg23736.html
---
These patches add support to virtio-pmem to allow the pmem region to be
specified in either guest absolute terms or as a PCI BAR-relative address.
This is required to support virtio-pmem in Hyper-V, since Hyper-V only
allows PCI devices to operate on PCI memory ranges defined via BARs.
Taylor Stark (2):
virtio-pmem: Support PCI BAR-relative addresses
virtio-pmem: Set DRIVER_OK status prior to creating pmem region
drivers/nvdimm/virtio_pmem.c | 27 +++++++++++++++++++++++----
drivers/nvdimm/virtio_pmem.h | 3 +++
2 files changed, 26 insertions(+), 4 deletions(-)
base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3
--
2.32.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/2] virtio-pmem: Support PCI BAR-relative addresses
2021-07-15 22:33 [PATCH v2 0/2] virtio-pmem: Support PCI BAR-relative addresses Taylor Stark
@ 2021-08-25 0:35 ` Dan Williams
2021-08-25 21:56 ` Taylor Stark
0 siblings, 1 reply; 4+ messages in thread
From: Dan Williams @ 2021-08-25 0:35 UTC (permalink / raw)
To: Taylor Stark
Cc: Vishal L Verma, Dave Jiang, Weiny, Ira, Linux NVDIMM, apais,
tyhicks, jamorris, benhill, sunilmut, grahamwo, tstark
On Thu, Jul 15, 2021 at 3:34 PM Taylor Stark <tstark@linux.microsoft.com> wrote:
>
> Changes from v1 [1]:
> - Fixed a bug where the guest might touch pmem region prior to the
> backing file being mapped into the guest's address space.
>
> [1]: https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg23736.html
>
> ---
>
> These patches add support to virtio-pmem to allow the pmem region to be
> specified in either guest absolute terms or as a PCI BAR-relative address.
> This is required to support virtio-pmem in Hyper-V, since Hyper-V only
> allows PCI devices to operate on PCI memory ranges defined via BARs.
>
> Taylor Stark (2):
> virtio-pmem: Support PCI BAR-relative addresses
> virtio-pmem: Set DRIVER_OK status prior to creating pmem region
Are these patches still valid? I am only seeing one of them on the list.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/2] virtio-pmem: Support PCI BAR-relative addresses
2021-08-25 0:35 ` Dan Williams
@ 2021-08-25 21:56 ` Taylor Stark
2021-08-25 22:05 ` Dan Williams
0 siblings, 1 reply; 4+ messages in thread
From: Taylor Stark @ 2021-08-25 21:56 UTC (permalink / raw)
To: Dan Williams
Cc: Vishal L Verma, Dave Jiang, Weiny, Ira, Linux NVDIMM, apais,
tyhicks, jamorris, benhill, sunilmut, grahamwo, tstark
On Tue, Aug 24, 2021 at 05:35:48PM -0700, Dan Williams wrote:
> On Thu, Jul 15, 2021 at 3:34 PM Taylor Stark <tstark@linux.microsoft.com> wrote:
> >
> > Changes from v1 [1]:
> > - Fixed a bug where the guest might touch pmem region prior to the
> > backing file being mapped into the guest's address space.
> >
> > [1]: https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg23736.html
> >
> > ---
> >
> > These patches add support to virtio-pmem to allow the pmem region to be
> > specified in either guest absolute terms or as a PCI BAR-relative address.
> > This is required to support virtio-pmem in Hyper-V, since Hyper-V only
> > allows PCI devices to operate on PCI memory ranges defined via BARs.
> >
> > Taylor Stark (2):
> > virtio-pmem: Support PCI BAR-relative addresses
> > virtio-pmem: Set DRIVER_OK status prior to creating pmem region
>
> Are these patches still valid? I am only seeing one of them on the list.
I'd hold off on taking a look for now. I'll need to post a v3 based on some
suggestions while I was updating the virtio-pmem spec. It's a small change
compared to the current patches (adds in a feature bit check). I'll post v3
when the virtio-pmem base spec goes in. More info here:
https://lists.oasis-open.org/archives/virtio-comment/202107/msg00169.html
And yes, I messed up how I sent the patches. First time making linux changes,
so I had some bumps while getting my email properly configured.. :)
Thanks,
Taylor
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/2] virtio-pmem: Support PCI BAR-relative addresses
2021-08-25 21:56 ` Taylor Stark
@ 2021-08-25 22:05 ` Dan Williams
0 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2021-08-25 22:05 UTC (permalink / raw)
To: Taylor Stark
Cc: Vishal L Verma, Dave Jiang, Weiny, Ira, Linux NVDIMM, apais,
tyhicks, jamorris, benhill, sunilmut, grahamwo, tstark
On Wed, Aug 25, 2021 at 2:56 PM Taylor Stark <tstark@linux.microsoft.com> wrote:
>
> On Tue, Aug 24, 2021 at 05:35:48PM -0700, Dan Williams wrote:
> > On Thu, Jul 15, 2021 at 3:34 PM Taylor Stark <tstark@linux.microsoft.com> wrote:
> > >
> > > Changes from v1 [1]:
> > > - Fixed a bug where the guest might touch pmem region prior to the
> > > backing file being mapped into the guest's address space.
> > >
> > > [1]: https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg23736.html
> > >
> > > ---
> > >
> > > These patches add support to virtio-pmem to allow the pmem region to be
> > > specified in either guest absolute terms or as a PCI BAR-relative address.
> > > This is required to support virtio-pmem in Hyper-V, since Hyper-V only
> > > allows PCI devices to operate on PCI memory ranges defined via BARs.
> > >
> > > Taylor Stark (2):
> > > virtio-pmem: Support PCI BAR-relative addresses
> > > virtio-pmem: Set DRIVER_OK status prior to creating pmem region
> >
> > Are these patches still valid? I am only seeing one of them on the list.
>
> I'd hold off on taking a look for now. I'll need to post a v3 based on some
> suggestions while I was updating the virtio-pmem spec. It's a small change
> compared to the current patches (adds in a feature bit check). I'll post v3
> when the virtio-pmem base spec goes in. More info here:
>
> https://lists.oasis-open.org/archives/virtio-comment/202107/msg00169.html
>
> And yes, I messed up how I sent the patches. First time making linux changes,
> so I had some bumps while getting my email properly configured.. :)
No worries, yes it's a pain. It turns out Konstantin is trying to make
that process easier for new contributors:
https://lore.kernel.org/workflows/20210616171813.bwvu6mtl4ltotf7p@nitro.local/
...but I don't think that's up and running yet.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-25 22:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 22:33 [PATCH v2 0/2] virtio-pmem: Support PCI BAR-relative addresses Taylor Stark
2021-08-25 0:35 ` Dan Williams
2021-08-25 21:56 ` Taylor Stark
2021-08-25 22:05 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).