Re: [ndctl PATCH] libndctl.sym: move new interfaces since v59 to a nee section

Re: [ndctl PATCH] libndctl.sym: move new interfaces since v59 to a nee section

[Dan Williams]

On Fri, Mar 9, 2018 at 3:18 PM, Vishal Verma <vishal.l.verma@intel.com> wrote:
> Since we're adding new interfaces, the libndctl 'current' will change to
> '15'. Add a corresponding section in libndctl.sym, and move the new
> symbols to it.
>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

s/nee/new/ in the Subject: line, but other than that:

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

[ndctl PATCH] libndctl.sym: move new interfaces since v59 to a nee section

[Vishal Verma]

Since we're adding new interfaces, the libndctl 'current' will change to
'15'. Add a corresponding section in libndctl.sym, and move the new
symbols to it.

Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 ndctl/lib/libndctl.sym | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/ndctl/lib/libndctl.sym b/ndctl/lib/libndctl.sym
index 6de1e0b..2127661 100644
--- a/ndctl/lib/libndctl.sym
+++ b/ndctl/lib/libndctl.sym
@@ -339,11 +339,15 @@ global:
 	ndctl_cmd_fw_info_get_query_interval;
 	ndctl_cmd_fw_info_get_max_query_time;
 	ndctl_cmd_fw_info_get_run_version;
-	ndctl_cmd_fw_info_get_next_version;
 	ndctl_cmd_fw_start_get_context;
 	ndctl_cmd_fw_fquery_get_fw_rev;
 	ndctl_cmd_fw_xlat_firmware_status;
+} LIBNDCTL_13;
+
+LIBNDCTL_15 {
+global:
+	ndctl_cmd_fw_info_get_next_version;
 	ndctl_dimm_cmd_new_ack_shutdown_count;
 	ndctl_region_get_numa_node;
 	ndctl_dimm_fw_update_supported;
-} LIBNDCTL_13;
+} LIBNDCTL_14;
-- 
2.14.3

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm