nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] libnvdimm, label: Fix sparse warning
@ 2018-10-12  1:54 Dan Williams
  2018-10-12 14:44 ` Alexander Duyck
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2018-10-12  1:54 UTC (permalink / raw)
  To: linux-nvdimm; +Cc: Alexander Duyck, kbuild test robot

The kbuild robot reports:

drivers/nvdimm/label.c:500:32: warning: restricted __le32 degrades to integer

...read 'nslot' into a local u32.

Reported-by: kbuild test robot <lkp@intel.com>
Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/nvdimm/label.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
index 7f03d117824f..750dbaa6ce82 100644
--- a/drivers/nvdimm/label.c
+++ b/drivers/nvdimm/label.c
@@ -424,6 +424,7 @@ int nd_label_data_init(struct nvdimm_drvdata *ndd)
 	struct nd_namespace_index *nsindex;
 	unsigned int i;
 	int rc = 0;
+	u32 nslot;
 
 	if (ndd->data)
 		return 0;
@@ -495,9 +496,10 @@ int nd_label_data_init(struct nvdimm_drvdata *ndd)
 
 	/* Determine starting offset for label data */
 	offset = __le64_to_cpu(nsindex->labeloff);
+	nslot = __le32_to_cpu(nsindex->nslot);
 
 	/* Loop through the free list pulling in any active labels */
-	for (i = 0; i < nsindex->nslot; i++, offset += ndd->nslabel_size) {
+	for (i = 0; i < nslot; i++, offset += ndd->nslabel_size) {
 		size_t label_read_size;
 
 		/* zero out the unused labels */

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libnvdimm, label: Fix sparse warning
  2018-10-12  1:54 [PATCH] libnvdimm, label: Fix sparse warning Dan Williams
@ 2018-10-12 14:44 ` Alexander Duyck
  0 siblings, 0 replies; 2+ messages in thread
From: Alexander Duyck @ 2018-10-12 14:44 UTC (permalink / raw)
  To: Dan Williams, linux-nvdimm; +Cc: kbuild test robot

On 10/11/2018 6:54 PM, Dan Williams wrote:
> The kbuild robot reports:
> 
> drivers/nvdimm/label.c:500:32: warning: restricted __le32 degrades to integer
> 
> ...read 'nslot' into a local u32.
> 
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

The change looks good to me.

Acked-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>

> ---
>   drivers/nvdimm/label.c |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvdimm/label.c b/drivers/nvdimm/label.c
> index 7f03d117824f..750dbaa6ce82 100644
> --- a/drivers/nvdimm/label.c
> +++ b/drivers/nvdimm/label.c
> @@ -424,6 +424,7 @@ int nd_label_data_init(struct nvdimm_drvdata *ndd)
>   	struct nd_namespace_index *nsindex;
>   	unsigned int i;
>   	int rc = 0;
> +	u32 nslot;
>   
>   	if (ndd->data)
>   		return 0;
> @@ -495,9 +496,10 @@ int nd_label_data_init(struct nvdimm_drvdata *ndd)
>   
>   	/* Determine starting offset for label data */
>   	offset = __le64_to_cpu(nsindex->labeloff);
> +	nslot = __le32_to_cpu(nsindex->nslot);
>   
>   	/* Loop through the free list pulling in any active labels */
> -	for (i = 0; i < nsindex->nslot; i++, offset += ndd->nslabel_size) {
> +	for (i = 0; i < nslot; i++, offset += ndd->nslabel_size) {
>   		size_t label_read_size;
>   
>   		/* zero out the unused labels */
> 
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-12 14:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-12  1:54 [PATCH] libnvdimm, label: Fix sparse warning Dan Williams
2018-10-12 14:44 ` Alexander Duyck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).