nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] ndctl, monitor: fix the sevrity of "daemon started" message
@ 2018-10-05  7:01 QI Fuli
  2018-10-05 20:01 ` Verma, Vishal L
  0 siblings, 1 reply; 2+ messages in thread
From: QI Fuli @ 2018-10-05  7:01 UTC (permalink / raw)
  To: linux-nvdimm

The "daemon started" message was printed as an error and this is improper.
This patch is used to chang it to info() meanwhile to chang the default log
level of monitor to "LOG_INFO".

Signed-off-by: QI Fuli <qi.fuli@jp.fujitsu.com>
---
 ndctl/monitor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ndctl/monitor.c b/ndctl/monitor.c
index d29e378..17465bb 100644
--- a/ndctl/monitor.c
+++ b/ndctl/monitor.c
@@ -628,7 +628,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
 	if (monitor.verbose)
 		ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_DEBUG);
 	else
-		ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_NOTICE);
+		ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_INFO);
 
 	rc = read_config_file((struct ndctl_ctx *)ctx, &monitor, &param);
 	if (rc)
@@ -660,7 +660,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
 			err((struct ndctl_ctx *)ctx, "daemon start failed\n");
 			goto out;
 		}
-		err((struct ndctl_ctx *)ctx, "ndctl monitor daemon started\n");
+		info((struct ndctl_ctx *)ctx, "ndctl monitor daemon started\n");
 	}
 
 	if (parse_monitor_event(&monitor, (struct ndctl_ctx *)ctx))
-- 
2.19.0.rc0


_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ndctl, monitor: fix the sevrity of "daemon started" message
  2018-10-05  7:01 [PATCH] ndctl, monitor: fix the sevrity of "daemon started" message QI Fuli
@ 2018-10-05 20:01 ` Verma, Vishal L
  0 siblings, 0 replies; 2+ messages in thread
From: Verma, Vishal L @ 2018-10-05 20:01 UTC (permalink / raw)
  To: linux-nvdimm, qi.fuli


On Fri, 2018-10-05 at 16:01 +0900, QI Fuli wrote:
> The "daemon started" message was printed as an error and this is improper.
> This patch is used to chang it to info() meanwhile to chang the default log
> level of monitor to "LOG_INFO".
> 
> Signed-off-by: QI Fuli <qi.fuli@jp.fujitsu.com>
> ---
>  ndctl/monitor.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Qi! Applied.

> 
> diff --git a/ndctl/monitor.c b/ndctl/monitor.c
> index d29e378..17465bb 100644
> --- a/ndctl/monitor.c
> +++ b/ndctl/monitor.c
> @@ -628,7 +628,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
>  	if (monitor.verbose)
>  		ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_DEBUG);
>  	else
> -		ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_NOTICE);
> +		ndctl_set_log_priority((struct ndctl_ctx *)ctx, LOG_INFO);
>  
>  	rc = read_config_file((struct ndctl_ctx *)ctx, &monitor, &param);
>  	if (rc)
> @@ -660,7 +660,7 @@ int cmd_monitor(int argc, const char **argv, void *ctx)
>  			err((struct ndctl_ctx *)ctx, "daemon start failed\n");
>  			goto out;
>  		}
> -		err((struct ndctl_ctx *)ctx, "ndctl monitor daemon started\n");
> +		info((struct ndctl_ctx *)ctx, "ndctl monitor daemon started\n");
>  	}
>  
>  	if (parse_monitor_event(&monitor, (struct ndctl_ctx *)ctx))

_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-05 20:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-05  7:01 [PATCH] ndctl, monitor: fix the sevrity of "daemon started" message QI Fuli
2018-10-05 20:01 ` Verma, Vishal L

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).