nvdimm.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: "Liu, Jingqi" <jingqi.liu@intel.com>
To: "Verma, Vishal L" <vishal.l.verma@intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>
Subject: Re: [PATCH] ndctl/dimm: Fix to dump namespace indexs and labels
Date: Thu, 8 Jul 2021 14:52:33 +0800	[thread overview]
Message-ID: <cba902d9-820e-93d2-2718-68abc665ce01@intel.com> (raw)
In-Reply-To: <d9d858e2431193f9aacba83f8a792a34486ac900.camel@intel.com>



On 7/8/2021 1:59 PM, Verma, Vishal L wrote:
> On Thu, 2021-07-08 at 09:53 +0800, Liu, Jingqi wrote:
>>>
>>> [..]
>>>>
>>>> diff --git a/ndctl/lib/libndctl.sym b/ndctl/lib/libndctl.sym
>>>> index 0a82616..0ce2bb9 100644
>>>> --- a/ndctl/lib/libndctl.sym
>>>> +++ b/ndctl/lib/libndctl.sym
>>>> @@ -290,6 +290,7 @@ global:
>>>>         ndctl_dimm_validate_labels;
>>>>         ndctl_dimm_init_labels;
>>>>         ndctl_dimm_sizeof_namespace_label;
>>>> +     ndctl_dimm_sizeof_namespace_index;
>>>
>>> This can't go into an 'old' section of the symbol version script - if
>>> you base off the current 'pending' branch, you should see a LIBNDCTL_26
>>> section at the bottom. You can add this there.
>>
>> It's based on the current 'master' branch.
>> I don't see a LIBNDCTL_26 section, just 'LIBNDCTL_25'.
>> How about adding 'ndctl_dimm_sizeof_namespace_index' to LIBNDCTL_25
>> section ?
>>
> No - so once a release happens, that section is 'closed' forever. The
> master branch coincides with the v71 release. That release had added
> new symbols in the LIBNDCTL_25 section, and that section is now done.
> New symbols after v71 need to go in a new section, LIBNDCTL_26.
> 
> The pending branch just happens to have patches that added a new
> symbol, so the new section is already created for you - so if you
> rebase to pending, you can just reuse that. Alternatively, base off
> master, and create a new LIBNDCTL_26 section, and I'll fix up the
> trivial conflict when merging.
> 
> Hope this clarifies things a bit!

Got it.
Thanks your clarification.
The other modifications of this patch are based on the master branch.
So for this file, I'll base off master.
Thank you for fixing up the conflict when merging.

Thanks,
Jingqi
> 
> Thanks,
> -Vishal
> 

  reply	other threads:[~2021-07-08  6:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-09  3:06 Jingqi Liu
2021-06-16  1:31 ` Liu, Jingqi
2021-07-02  4:41 ` Dan Williams
2021-07-08  0:21 ` Verma, Vishal L
2021-07-08  1:53   ` Liu, Jingqi
2021-07-08  5:59     ` Verma, Vishal L
2021-07-08  6:52       ` Liu, Jingqi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-03  1:25 Jingqi Liu
2021-06-07 20:03 ` Dan Williams
2021-06-09  1:27   ` Liu, Jingqi
2021-06-02 12:18 Jingqi Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cba902d9-820e-93d2-2718-68abc665ce01@intel.com \
    --to=jingqi.liu@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=nvdimm@lists.linux.dev \
    --cc=vishal.l.verma@intel.com \
    --subject='Re: [PATCH] ndctl/dimm: Fix to dump namespace indexs and labels' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).