From: Jeff Moyer <jmoyer@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>,
linux-edac@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks
Date: Wed, 20 Feb 2019 14:26:45 -0500 [thread overview]
Message-ID: <x49d0nm2rd6.fsf@segfault.boston.devel.redhat.com> (raw)
In-Reply-To: <20190220191852.GF3447@zn.tnic> (Borislav Petkov's message of "Wed, 20 Feb 2019 20:18:52 +0100")
Borislav Petkov <bp@alien8.de> writes:
> Drop stable@
>
> On Wed, Feb 20, 2019 at 01:59:15PM -0500, Jeff Moyer wrote:
>> Sorry for necroposting. I thought the point of the CEC was to make sure
>> that the other registered decoders only ever saw uncorrected errors.
>
> Ha, good point! You mean drivers/ras/cec.c, right?
Yes.
> If so, then I don't think we've ever talked about connecting CEC with
> NVDIMM and whether that would make sense. Lemme add Dan.
I don't think there's a difference between MCEs for NVDIMMs and normal
DRAM. I'll let Dan confirm or deny that.
>> How do we end up getting called with a correctable error?
>
> Good question. We shouldn't.
>
> So we need to figure out here how exactly should those things interact
> and whether NFIT should get all errors reported or it should put all the
> correctable errors through the decay thing, see the comment at the top
> of drivers/ras/cec.c
>
> Thx for pointing that out Jeff.
Sure, thanks for the quick reply, Boris! Also, thanks for your detailed
commit messages. They really help with understanding the code changes.
Cheers,
Jeff
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2019-02-20 19:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 0:37 [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks Vishal Verma
2018-10-26 0:37 ` [PATCH v3 2/2] nfit, mce: validate the mce->addr before using it Vishal Verma
2018-11-06 14:51 ` Borislav Petkov
2018-11-06 16:20 ` Dan Williams
2018-11-06 17:53 ` Borislav Petkov
2018-11-06 18:02 ` Dan Williams
2018-11-06 18:07 ` Borislav Petkov
2019-02-20 18:59 ` [PATCH v3 1/2] nfit, mce: only handle uncorrectable machine checks Jeff Moyer
2019-02-20 19:18 ` Borislav Petkov
2019-02-20 19:26 ` Jeff Moyer [this message]
2019-02-20 19:39 ` Borislav Petkov
2019-02-20 19:40 ` Dan Williams
2019-02-20 19:47 ` Borislav Petkov
2019-02-21 16:11 ` Jeff Moyer
2019-02-21 17:09 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x49d0nm2rd6.fsf@segfault.boston.devel.redhat.com \
--to=jmoyer@redhat.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).