Re: [tpmdd-devel] [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces

From: Ken Goldman <kgoldman@us.ibm.com>
To: linux-security-module@vger.kernel.org
Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH RFC v2 3/5] tpm: infrastructure for TPM spaces
Date: Sat, 14 Jan 2017 12:53:15 -0500	[thread overview]
Message-ID: <o5dohv$60l$1@blaine.gmane.org> (raw)
In-Reply-To: <20170113162855.dddgsomp7m4c3inc@intel.com>

On 1/13/2017 11:28 AM, Jarkko Sakkinen wrote:

>>> +
>>> +       if (!tpm2_find_cc_attrs(chip, cc, &attrs)) {
>>> +               /* should never happen */
>>> +               dev_err(&chip->dev, "TPM returned a different CC:
>>> 0x%04x\n",
>>> +                       cc);
>>> +               rc = -EFAULT;
>>> +               goto out_err;
>>> +       }

Something is strange here.  Is "CC" command code?

The TPM does not return a command code.  The mapping should use the
command code from the command.

It could be the code is correct - the command code mapped OK in the 
command but then failed in the response.  But the error message is strange.