Re: [Ocfs2-devel] [PATCH v3 4/6] ext4: convert to use i_blockmask() - Al Viro via Ocfs2-devel

From: Al Viro via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: brauner@kernel.org, tytso@mit.edu, agruenba@redhat.com,
	chao@kernel.org, linux-kernel@vger.kernel.org,
	cluster-devel@redhat.com, rpeterso@redhat.com,
	huyue2@coolpad.com, adilger.kernel@dilger.ca,
	jefflexu@linux.alibaba.com, linux-fsdevel@vger.kernel.org,
	xiang@kernel.org, linux-ext4@vger.kernel.org,
	linux-erofs@lists.ozlabs.org, ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH v3 4/6] ext4: convert to use i_blockmask()
Date: Fri, 10 Mar 2023 03:19:40 +0000	[thread overview]
Message-ID: <20230310031940.GE3390869@ZenIV> (raw)
In-Reply-To: <20230309152127.41427-4-frank.li@vivo.com>

On Thu, Mar 09, 2023 at 11:21:25PM +0800, Yangtao Li wrote:
> Use i_blockmask() to simplify code.
> 
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> v3:
> -none
> v2:
> -convert to i_blockmask()
>  fs/ext4/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index d251d705c276..eec36520e5e9 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -2218,7 +2218,7 @@ static int mpage_process_page_bufs(struct mpage_da_data *mpd,
>  {
>  	struct inode *inode = mpd->inode;
>  	int err;
> -	ext4_lblk_t blocks = (i_size_read(inode) + i_blocksize(inode) - 1)
> +	ext4_lblk_t blocks = (i_size_read(inode) + i_blockmask(inode))
>  							>> inode->i_blkbits;

Umm...  That actually asks for DIV_ROUND_UP(i_size_read_inode(), i_blocksize(inode)) -
compiler should bloody well be able to figure out that division by (1 << n) is
shift down by n and it's easier to follow that way...

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel