From: Gao Xiang via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Yangtao Li <frank.li@vivo.com>
Cc: brauner@kernel.org, tytso@mit.edu, agruenba@redhat.com,
chao@kernel.org, linux-kernel@vger.kernel.org,
cluster-devel@redhat.com, rpeterso@redhat.com,
huyue2@coolpad.com, adilger.kernel@dilger.ca,
jefflexu@linux.alibaba.com, linux-fsdevel@vger.kernel.org,
xiang@kernel.org, linux-ext4@vger.kernel.org,
linux-erofs@lists.ozlabs.org, ocfs2-devel@oss.oracle.com
Subject: Re: [Ocfs2-devel] [PATCH v3 2/6] erofs: convert to use i_blockmask()
Date: Fri, 10 Mar 2023 11:47:38 +0800 [thread overview]
Message-ID: <24a46ae8-6e50-2f45-f099-45743bb013c4@linux.alibaba.com> (raw)
In-Reply-To: <2fa31829-03f0-7bfb-a89b-e3917c479733@linux.alibaba.com>
On 2023/3/10 11:42, Gao Xiang wrote:
> Hi Al,
>
> On 2023/3/10 11:15, Al Viro wrote:
>> On Thu, Mar 09, 2023 at 11:21:23PM +0800, Yangtao Li wrote:
>>> Use i_blockmask() to simplify code.
>>
>> Umm... What's the branchpoint for that series? Not the mainline -
>> there we have i_blocksize() open-coded...
>
> Actually Yue Hu sent out a clean-up patch and I applied to -next for
> almost a week and will be upstreamed for 6.3-rc2:
>
> https://lore.kernel.org/r/a238dca1-256f-ae2f-4a33-e54861fe4ffb@kernel.org/T/#t
Sorry this link:
https://lore.kernel.org/r/0261de31-e98b-85cd-80de-96af5a76e15c@linux.alibaba.com
Yangtao's suggestion was to use GENMASK, and I'm not sure it's a good way
since (i_blocksize(inode) - 1) is simple enough, and then it becomes like
this.
Thanks,
Gao Xiang
>
> And then Yangtao would like to wrap this as a new VFS helper, I'm not
> sure why it's necessary since it doesn't save a lot but anyway, I'm open
> to it if VFS could have such new helper.
>
> Thanks,
> Gao Xiang
>
>>
>>> Signed-off-by: Yangtao Li <frank.li@vivo.com>
>>> ---
>>> v3:
>>> -none
>>> v2:
>>> -convert to i_blockmask()
>>> fs/erofs/data.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/erofs/data.c b/fs/erofs/data.c
>>> index 7e8baf56faa5..e9d1869cd4b3 100644
>>> --- a/fs/erofs/data.c
>>> +++ b/fs/erofs/data.c
>>> @@ -380,7 +380,7 @@ static ssize_t erofs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
>>> if (bdev)
>>> blksize_mask = bdev_logical_block_size(bdev) - 1;
>>> else
>>> - blksize_mask = i_blocksize(inode) - 1;
>>> + blksize_mask = i_blockmask(inode);
>>> if ((iocb->ki_pos | iov_iter_count(to) |
>>> iov_iter_alignment(to)) & blksize_mask)
>>> --
>>> 2.25.1
>>>
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
next prev parent reply other threads:[~2023-03-22 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 15:21 [Ocfs2-devel] [PATCH v3 1/6] fs: add i_blockmask() Yangtao Li via Ocfs2-devel
2023-03-09 15:21 ` [Ocfs2-devel] [PATCH v3 2/6] erofs: convert to use i_blockmask() Yangtao Li via Ocfs2-devel
2023-03-10 3:15 ` Al Viro via Ocfs2-devel
2023-03-10 3:42 ` Gao Xiang via Ocfs2-devel
2023-03-10 3:47 ` Gao Xiang via Ocfs2-devel [this message]
2023-03-10 3:51 ` [Ocfs2-devel] " Yangtao Li via Ocfs2-devel
2023-03-10 4:05 ` Al Viro via Ocfs2-devel
2023-03-10 6:50 ` Yangtao Li via Ocfs2-devel
2023-03-09 15:21 ` [Ocfs2-devel] [PATCH v3 3/6] gfs2: " Yangtao Li via Ocfs2-devel
2023-03-09 15:21 ` [Ocfs2-devel] [PATCH v3 4/6] ext4: " Yangtao Li via Ocfs2-devel
2023-03-10 3:19 ` Al Viro via Ocfs2-devel
2023-03-10 3:32 ` Al Viro via Ocfs2-devel
2023-03-09 15:21 ` [Ocfs2-devel] [PATCH v3 5/6] ocfs2: " Yangtao Li via Ocfs2-devel
2023-03-10 3:26 ` Al Viro via Ocfs2-devel
2023-03-09 15:21 ` [Ocfs2-devel] [PATCH v3 6/6] fs/remap_range: " Yangtao Li via Ocfs2-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a46ae8-6e50-2f45-f099-45743bb013c4@linux.alibaba.com \
--to=ocfs2-devel@oss.oracle.com \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=cluster-devel@redhat.com \
--cc=frank.li@vivo.com \
--cc=hsiangkao@linux.alibaba.com \
--cc=huyue2@coolpad.com \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).