* [Ocfs2-devel] [PATCH 1/2] ocfs2: there is no need to log twice in several functions
@ 2020-02-22 1:52 wangyan
2020-02-24 3:00 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: wangyan @ 2020-02-22 1:52 UTC (permalink / raw)
To: ocfs2-devel
There is no need to log twice in several functions.
Signed-off-by: Yan Wang <wangyan122@huawei.com>
Reviewed-by: Jun Piao <piaojun@huawei.com>
---
fs/ocfs2/alloc.c | 1 -
fs/ocfs2/suballoc.c | 5 -----
2 files changed, 6 deletions(-)
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
index 88534eb0e7c2..1e3b06fa4785 100644
--- a/fs/ocfs2/alloc.c
+++ b/fs/ocfs2/alloc.c
@@ -1060,7 +1060,6 @@ static int ocfs2_create_new_meta_bhs(handle_t *handle,
brelse(bhs[i]);
bhs[i] = NULL;
}
- mlog_errno(status);
}
return status;
}
diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
index 939df99d2dec..4836becb7578 100644
--- a/fs/ocfs2/suballoc.c
+++ b/fs/ocfs2/suballoc.c
@@ -2509,9 +2509,6 @@ static int _ocfs2_free_suballoc_bits(handle_t *handle,
bail:
brelse(group_bh);
-
- if (status)
- mlog_errno(status);
return status;
}
@@ -2582,8 +2579,6 @@ static int _ocfs2_free_clusters(handle_t *handle,
num_clusters);
out:
- if (status)
- mlog_errno(status);
return status;
}
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Ocfs2-devel] [PATCH 1/2] ocfs2: there is no need to log twice in several functions
2020-02-22 1:52 [Ocfs2-devel] [PATCH 1/2] ocfs2: there is no need to log twice in several functions wangyan
@ 2020-02-24 3:00 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2020-02-24 3:00 UTC (permalink / raw)
To: ocfs2-devel
On 2020/2/22 09:52, wangyan wrote:
> There is no need to log twice in several functions.
>
> Signed-off-by: Yan Wang <wangyan122@huawei.com>
> Reviewed-by: Jun Piao <piaojun@huawei.com>
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/alloc.c | 1 -
> fs/ocfs2/suballoc.c | 5 -----
> 2 files changed, 6 deletions(-)
>
> diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
> index 88534eb0e7c2..1e3b06fa4785 100644
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
> @@ -1060,7 +1060,6 @@ static int ocfs2_create_new_meta_bhs(handle_t *handle,
> brelse(bhs[i]);
> bhs[i] = NULL;
> }
> - mlog_errno(status);
> }
> return status;
> }
> diff --git a/fs/ocfs2/suballoc.c b/fs/ocfs2/suballoc.c
> index 939df99d2dec..4836becb7578 100644
> --- a/fs/ocfs2/suballoc.c
> +++ b/fs/ocfs2/suballoc.c
> @@ -2509,9 +2509,6 @@ static int _ocfs2_free_suballoc_bits(handle_t *handle,
>
> bail:
> brelse(group_bh);
> -
> - if (status)
> - mlog_errno(status);
> return status;
> }
>
> @@ -2582,8 +2579,6 @@ static int _ocfs2_free_clusters(handle_t *handle,
> num_clusters);
>
> out:
> - if (status)
> - mlog_errno(status);
> return status;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-24 3:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-22 1:52 [Ocfs2-devel] [PATCH 1/2] ocfs2: there is no need to log twice in several functions wangyan
2020-02-24 3:00 ` Joseph Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).