* [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage
@ 2024-02-24 13:50 chengming.zhou
2024-02-25 12:20 ` Joseph Qi
0 siblings, 1 reply; 4+ messages in thread
From: chengming.zhou @ 2024-02-24 13:50 UTC (permalink / raw)
To: mark, jlbec, joseph.qi, brauner, jlayton, keescook
Cc: jack, zhouchengming, azeemshaikh38, ocfs2-devel, linux-kernel,
linux-mm, vbabka, roman.gushchin, Xiongwei.Song, chengming.zhou
From: Chengming Zhou <zhouchengming@bytedance.com>
The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
its usage so we can delete it from slab. No functional change.
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
---
fs/ocfs2/dlmfs/dlmfs.c | 2 +-
fs/ocfs2/super.c | 7 +++----
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/ocfs2/dlmfs/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c
index 85215162c9dd..7fc0e920eda7 100644
--- a/fs/ocfs2/dlmfs/dlmfs.c
+++ b/fs/ocfs2/dlmfs/dlmfs.c
@@ -578,7 +578,7 @@ static int __init init_dlmfs_fs(void)
dlmfs_inode_cache = kmem_cache_create("dlmfs_inode_cache",
sizeof(struct dlmfs_inode_private),
0, (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
- SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+ SLAB_ACCOUNT),
dlmfs_init_once);
if (!dlmfs_inode_cache) {
status = -ENOMEM;
diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c
index 014c22c4d9d9..8aabaed2c1cb 100644
--- a/fs/ocfs2/super.c
+++ b/fs/ocfs2/super.c
@@ -1706,18 +1706,17 @@ static int ocfs2_initialize_mem_caches(void)
sizeof(struct ocfs2_inode_info),
0,
(SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
- SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+ SLAB_ACCOUNT),
ocfs2_inode_init_once);
ocfs2_dquot_cachep = kmem_cache_create("ocfs2_dquot_cache",
sizeof(struct ocfs2_dquot),
0,
- (SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT|
- SLAB_MEM_SPREAD),
+ SLAB_HWCACHE_ALIGN|SLAB_RECLAIM_ACCOUNT,
NULL);
ocfs2_qf_chunk_cachep = kmem_cache_create("ocfs2_qf_chunk_cache",
sizeof(struct ocfs2_quota_chunk),
0,
- (SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD),
+ SLAB_RECLAIM_ACCOUNT,
NULL);
if (!ocfs2_inode_cachep || !ocfs2_dquot_cachep ||
!ocfs2_qf_chunk_cachep) {
--
2.40.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage
2024-02-24 13:50 [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage chengming.zhou
@ 2024-02-25 12:20 ` Joseph Qi
2024-02-25 13:02 ` Chengming Zhou
0 siblings, 1 reply; 4+ messages in thread
From: Joseph Qi @ 2024-02-25 12:20 UTC (permalink / raw)
To: chengming.zhou, mark, jlbec, brauner, jlayton, keescook
Cc: jack, zhouchengming, azeemshaikh38, ocfs2-devel, linux-kernel,
linux-mm, vbabka, roman.gushchin, Xiongwei.Song
On 2/24/24 9:50 PM, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
>
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.
>
If I understand correctly, you are referring the following patch:
https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
But it seems that the above patch is not included in mainline yet.
Or am I missing something?
Joseph
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage
2024-02-25 12:20 ` Joseph Qi
@ 2024-02-25 13:02 ` Chengming Zhou
2024-02-26 1:11 ` Joseph Qi
0 siblings, 1 reply; 4+ messages in thread
From: Chengming Zhou @ 2024-02-25 13:02 UTC (permalink / raw)
To: Joseph Qi, mark, jlbec, brauner, jlayton, keescook
Cc: jack, zhouchengming, azeemshaikh38, ocfs2-devel, linux-kernel,
linux-mm, vbabka, roman.gushchin, Xiongwei.Song
On 2024/2/25 20:20, Joseph Qi wrote:
>
>
> On 2/24/24 9:50 PM, chengming.zhou@linux.dev wrote:
>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>
>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>> its usage so we can delete it from slab. No functional change.
>>
> If I understand correctly, you are referring the following patch:
> https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>
> But it seems that the above patch is not included in mainline yet.
> Or am I missing something?
I realize my commit message should explain more why it's a no-op, my bad.
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed so it became a dead flag as of v6.8-rc1. That series[1]
mark it obsolete to avoid confusion for users. So here we can just
remove all its users, which has no functional changes.
[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
Thanks!
>
> Joseph
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage
2024-02-25 13:02 ` Chengming Zhou
@ 2024-02-26 1:11 ` Joseph Qi
0 siblings, 0 replies; 4+ messages in thread
From: Joseph Qi @ 2024-02-26 1:11 UTC (permalink / raw)
To: Chengming Zhou, mark, jlbec, brauner, jlayton, keescook, akpm
Cc: jack, zhouchengming, azeemshaikh38, ocfs2-devel, linux-kernel,
linux-mm, vbabka, roman.gushchin, Xiongwei.Song
On 2/25/24 9:02 PM, Chengming Zhou wrote:
> On 2024/2/25 20:20, Joseph Qi wrote:
>>
>>
>> On 2/24/24 9:50 PM, chengming.zhou@linux.dev wrote:
>>> From: Chengming Zhou <zhouchengming@bytedance.com>
>>>
>>> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
>>> its usage so we can delete it from slab. No functional change.
>>>
>> If I understand correctly, you are referring the following patch:
>> https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>>
>> But it seems that the above patch is not included in mainline yet.
>> Or am I missing something?
>
> I realize my commit message should explain more why it's a no-op, my bad.
>
> The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
> removed so it became a dead flag as of v6.8-rc1. That series[1]
> mark it obsolete to avoid confusion for users. So here we can just
> remove all its users, which has no functional changes.
>
> [1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/
>
Take more look at v6.8-rc1, I've found the following commit:
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h")
It seems that after this commit, there is no user of 'SLAB_MEM_SPREAD'. So,
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-26 1:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-24 13:50 [PATCH] ocfs2: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-25 12:20 ` Joseph Qi
2024-02-25 13:02 ` Chengming Zhou
2024-02-26 1:11 ` Joseph Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).