oe-kbuild.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH v1 4/4] Enable Driver compilation in crypto Kconfig and Makefile file
Date: Sat, 30 Mar 2024 09:42:43 +0800	[thread overview]
Message-ID: <202403300947.olMzOBG1-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240328182652.3587727-5-pavitrakumarm@vayavyalabs.com>
References: <20240328182652.3587727-5-pavitrakumarm@vayavyalabs.com>
TO: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
TO: herbert@gondor.apana.org.au
TO: linux-crypto@vger.kernel.org
CC: Ruud.Derwig@synopsys.com
CC: manjunath.hadli@vayavyalabs.com
CC: bhoomikak@vayavyalabs.com
CC: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>

Hi Pavitrakumar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 6a8dbd71a70620c42d4fa82509204ba18231f28d]

url:    https://github.com/intel-lab-lkp/linux/commits/Pavitrakumar-M/Add-SPAcc-driver-to-Linux-kernel/20240329-023010
base:   6a8dbd71a70620c42d4fa82509204ba18231f28d
patch link:    https://lore.kernel.org/r/20240328182652.3587727-5-pavitrakumarm%40vayavyalabs.com
patch subject: [PATCH v1 4/4] Enable Driver compilation in crypto Kconfig and Makefile file
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago
config: x86_64-randconfig-104-20240330 (https://download.01.org/0day-ci/archive/20240330/202403300947.olMzOBG1-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202403300947.olMzOBG1-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/crypto/dwc-spacc/spacc_skcipher.c:239:21-25: ERROR: reference preceded by free on line 238
--
>> drivers/crypto/dwc-spacc/spacc_device.c:157:2-9: line 157 is redundant because platform_get_irq() already prints an error
--
>> drivers/crypto/dwc-spacc/spacc_device.c:317:3-8: No need to set .owner here. The core will do it.

vim +239 drivers/crypto/dwc-spacc/spacc_skcipher.c

b37587c90bca57 Pavitrakumar M 2024-03-28  231  
b37587c90bca57 Pavitrakumar M 2024-03-28  232  static void spacc_cipher_cra_exit(struct crypto_tfm *tfm)
b37587c90bca57 Pavitrakumar M 2024-03-28  233  {
b37587c90bca57 Pavitrakumar M 2024-03-28  234  	struct spacc_crypto_ctx *tctx = crypto_tfm_ctx(tfm);
b37587c90bca57 Pavitrakumar M 2024-03-28  235  	struct spacc_priv *priv = dev_get_drvdata(tctx->dev);
b37587c90bca57 Pavitrakumar M 2024-03-28  236  
b37587c90bca57 Pavitrakumar M 2024-03-28  237  	if (tctx->cipher_key) {
b37587c90bca57 Pavitrakumar M 2024-03-28 @238  		kfree(NULL);
b37587c90bca57 Pavitrakumar M 2024-03-28 @239  		tctx->cipher_key = NULL;
b37587c90bca57 Pavitrakumar M 2024-03-28  240  	}
b37587c90bca57 Pavitrakumar M 2024-03-28  241  
b37587c90bca57 Pavitrakumar M 2024-03-28  242  	if (tctx->handle >= 0)
b37587c90bca57 Pavitrakumar M 2024-03-28  243  		spacc_close(&priv->spacc, tctx->handle);
b37587c90bca57 Pavitrakumar M 2024-03-28  244  
b37587c90bca57 Pavitrakumar M 2024-03-28  245  	put_device(tctx->dev);
b37587c90bca57 Pavitrakumar M 2024-03-28  246  }
b37587c90bca57 Pavitrakumar M 2024-03-28  247  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2024-03-30  1:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-30  1:42 kernel test robot [this message]
2024-03-30  6:41 [PATCH v1 4/4] Enable Driver compilation in crypto Kconfig and Makefile file kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202403300947.olMzOBG1-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=julia.lawall@inria.fr \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).