From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: linux-nfc@lists.01.org
Subject: [PATCH v2 10/15] nfc: st-nci: drop unneeded debug prints
Date: Mon, 13 Sep 2021 15:20:30 +0200 [thread overview]
Message-ID: <20210913132035.242870-11-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210913132035.242870-1-krzysztof.kozlowski@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 3226 bytes --]
ftrace is a preferred and standard way to debug entering and exiting
functions so drop useless debug prints.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/nfc/st-nci/i2c.c | 4 ----
drivers/nfc/st-nci/ndlc.c | 4 ----
drivers/nfc/st-nci/se.c | 6 ------
drivers/nfc/st-nci/spi.c | 4 ----
4 files changed, 18 deletions(-)
diff --git a/drivers/nfc/st-nci/i2c.c b/drivers/nfc/st-nci/i2c.c
index ccf6152ebb9f..cbd968f013c7 100644
--- a/drivers/nfc/st-nci/i2c.c
+++ b/drivers/nfc/st-nci/i2c.c
@@ -157,7 +157,6 @@ static int st_nci_i2c_read(struct st_nci_i2c_phy *phy,
static irqreturn_t st_nci_irq_thread_fn(int irq, void *phy_id)
{
struct st_nci_i2c_phy *phy = phy_id;
- struct i2c_client *client;
struct sk_buff *skb = NULL;
int r;
@@ -166,9 +165,6 @@ static irqreturn_t st_nci_irq_thread_fn(int irq, void *phy_id)
return IRQ_NONE;
}
- client = phy->i2c_dev;
- dev_dbg(&client->dev, "IRQ\n");
-
if (phy->ndlc->hard_fault)
return IRQ_HANDLED;
diff --git a/drivers/nfc/st-nci/ndlc.c b/drivers/nfc/st-nci/ndlc.c
index e9dc313b333e..755460a73c0d 100644
--- a/drivers/nfc/st-nci/ndlc.c
+++ b/drivers/nfc/st-nci/ndlc.c
@@ -239,8 +239,6 @@ static void ndlc_t1_timeout(struct timer_list *t)
{
struct llt_ndlc *ndlc = from_timer(ndlc, t, t1_timer);
- pr_debug("\n");
-
schedule_work(&ndlc->sm_work);
}
@@ -248,8 +246,6 @@ static void ndlc_t2_timeout(struct timer_list *t)
{
struct llt_ndlc *ndlc = from_timer(ndlc, t, t2_timer);
- pr_debug("\n");
-
schedule_work(&ndlc->sm_work);
}
diff --git a/drivers/nfc/st-nci/se.c b/drivers/nfc/st-nci/se.c
index 5fd89f72969d..7764b1a4c3cf 100644
--- a/drivers/nfc/st-nci/se.c
+++ b/drivers/nfc/st-nci/se.c
@@ -638,8 +638,6 @@ int st_nci_se_io(struct nci_dev *ndev, u32 se_idx,
{
struct st_nci_info *info = nci_get_drvdata(ndev);
- pr_debug("\n");
-
switch (se_idx) {
case ST_NCI_ESE_HOST_ID:
info->se_info.cb = cb;
@@ -671,8 +669,6 @@ static void st_nci_se_wt_timeout(struct timer_list *t)
u8 param = 0x01;
struct st_nci_info *info = from_timer(info, t, se_info.bwi_timer);
- pr_debug("\n");
-
info->se_info.bwi_active = false;
if (!info->se_info.xch_error) {
@@ -692,8 +688,6 @@ static void st_nci_se_activation_timeout(struct timer_list *t)
struct st_nci_info *info = from_timer(info, t,
se_info.se_active_timer);
- pr_debug("\n");
-
info->se_info.se_active = false;
complete(&info->se_info.req_completion);
diff --git a/drivers/nfc/st-nci/spi.c b/drivers/nfc/st-nci/spi.c
index a620c34790e6..af1f04c306cc 100644
--- a/drivers/nfc/st-nci/spi.c
+++ b/drivers/nfc/st-nci/spi.c
@@ -169,7 +169,6 @@ static int st_nci_spi_read(struct st_nci_spi_phy *phy,
static irqreturn_t st_nci_irq_thread_fn(int irq, void *phy_id)
{
struct st_nci_spi_phy *phy = phy_id;
- struct spi_device *dev;
struct sk_buff *skb = NULL;
int r;
@@ -178,9 +177,6 @@ static irqreturn_t st_nci_irq_thread_fn(int irq, void *phy_id)
return IRQ_NONE;
}
- dev = phy->spi_dev;
- dev_dbg(&dev->dev, "IRQ\n");
-
if (phy->ndlc->hard_fault)
return IRQ_HANDLED;
--
2.30.2
next prev parent reply other threads:[~2021-09-13 13:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 13:20 [PATCH v2 00/15] nfc: minor printk cleanup Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 01/15] nfc: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 02/15] nfc: do not break pr_debug() call into separate lines Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 03/15] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 04/15] nfc: fdp: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 05/15] nfc: pn533: " Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 06/15] nfc: pn533: use dev_err() instead of pr_err() Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 07/15] nfc: pn544: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 08/15] nfc: pn544: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 09/15] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski
2021-09-13 13:20 ` Krzysztof Kozlowski [this message]
2021-09-13 13:20 ` [PATCH v2 11/15] nfc: st21nfca: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 12/15] nfc: trf7970a: " Krzysztof Kozlowski
2021-09-13 16:57 ` Mark Greer
2021-10-07 13:01 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 13/15] nfc: microread: " Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 14/15] nfc: microread: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 15/15] nfc: mrvl: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913132035.242870-11-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).