From: Mark Greer <mgreer@animalcreek.com>
To: linux-nfc@lists.01.org
Subject: Re: [PATCH v2 12/15] nfc: trf7970a: drop unneeded debug prints
Date: Mon, 13 Sep 2021 09:57:57 -0700 [thread overview]
Message-ID: <20210913165757.GA1309751@animalcreek.com> (raw)
In-Reply-To: <20210913132035.242870-13-krzysztof.kozlowski@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]
On Mon, Sep 13, 2021 at 03:20:32PM +0200, Krzysztof Kozlowski wrote:
> ftrace is a preferred and standard way to debug entering and exiting
> functions so drop useless debug prints.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
> drivers/nfc/trf7970a.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c
> index 8890fcd59c39..29ca9c328df2 100644
> --- a/drivers/nfc/trf7970a.c
> +++ b/drivers/nfc/trf7970a.c
> @@ -2170,8 +2170,6 @@ static int trf7970a_suspend(struct device *dev)
> struct spi_device *spi = to_spi_device(dev);
> struct trf7970a *trf = spi_get_drvdata(spi);
>
> - dev_dbg(dev, "Suspend\n");
> -
> mutex_lock(&trf->lock);
>
> trf7970a_shutdown(trf);
> @@ -2187,8 +2185,6 @@ static int trf7970a_resume(struct device *dev)
> struct trf7970a *trf = spi_get_drvdata(spi);
> int ret;
>
> - dev_dbg(dev, "Resume\n");
> -
> mutex_lock(&trf->lock);
>
> ret = trf7970a_startup(trf);
> @@ -2206,8 +2202,6 @@ static int trf7970a_pm_runtime_suspend(struct device *dev)
> struct trf7970a *trf = spi_get_drvdata(spi);
> int ret;
>
> - dev_dbg(dev, "Runtime suspend\n");
> -
> mutex_lock(&trf->lock);
>
> ret = trf7970a_power_down(trf);
> @@ -2223,8 +2217,6 @@ static int trf7970a_pm_runtime_resume(struct device *dev)
> struct trf7970a *trf = spi_get_drvdata(spi);
> int ret;
>
> - dev_dbg(dev, "Runtime resume\n");
> -
> ret = trf7970a_power_up(trf);
> if (!ret)
> pm_runtime_mark_last_busy(dev);
> --
> 2.30.2
Acked-by: Mark Greer <mgreer@animalcreek.com>
next prev parent reply other threads:[~2021-09-13 16:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 13:20 [PATCH v2 00/15] nfc: minor printk cleanup Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 01/15] nfc: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 02/15] nfc: do not break pr_debug() call into separate lines Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 03/15] nfc: nci: replace GPLv2 boilerplate with SPDX Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 04/15] nfc: fdp: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 05/15] nfc: pn533: " Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 06/15] nfc: pn533: use dev_err() instead of pr_err() Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 07/15] nfc: pn544: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 08/15] nfc: pn544: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 09/15] nfc: s3fwrn5: simplify dereferencing pointer to struct device Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 10/15] nfc: st-nci: drop unneeded debug prints Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 11/15] nfc: st21nfca: " Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 12/15] nfc: trf7970a: " Krzysztof Kozlowski
2021-09-13 16:57 ` Mark Greer [this message]
2021-10-07 13:01 ` Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 13/15] nfc: microread: " Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 14/15] nfc: microread: drop unneeded memory allocation fail messages Krzysztof Kozlowski
2021-09-13 13:20 ` [PATCH v2 15/15] nfc: mrvl: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210913165757.GA1309751@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=linux-nfc@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).