[neard][PATCH 1/4] include: include endian.h to fix missing __BYTE

oe-linux-nfc.lists.linux.dev archive mirror
 help / color / mirror / Atom feed

* [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch
@ 2021-11-07 17:26 Krzysztof Kozlowski
  2021-11-07 17:26 ` [neard][PATCH 2/4] ci: add Ubuntu Impish (21.10) Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-07 17:26 UTC (permalink / raw)
  To: linux-nfc

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Code should pull explicitly headers for necessary symbols instead of
relying on dependencies.  Lack of endian.h caused build failures on
Debian Stretch:

    In file included from tools/nfctool/ndef-decode.c:28:0:
    include/near/types.h:43:5: error: "__BYTE_ORDER" is not defined [-Werror=undef]
     #if __BYTE_ORDER == __LITTLE_ENDIAN

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 include/types.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/types.h b/include/types.h
index c4a8d6a31886..1dd8de530d58 100644
--- a/include/types.h
+++ b/include/types.h
@@ -23,6 +23,7 @@
 #define __NEAR_TYPES_H
 
 #include <byteswap.h>
+#include <endian.h>
 
 #define near_get_unaligned(ptr)			\
 ({						\
-- 
2.32.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [neard][PATCH 2/4] ci: add Ubuntu Impish (21.10)
  2021-11-07 17:26 [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch Krzysztof Kozlowski
@ 2021-11-07 17:26 ` Krzysztof Kozlowski
  2021-11-07 17:26 ` [neard][PATCH 3/4] ci: add Debian Buster and Stretch Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-07 17:26 UTC (permalink / raw)
  To: linux-nfc

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

Build on newest Ubuntu 21.10.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .github/workflows/ci.yml | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 734969325692..5540ad2ebc39 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -31,6 +31,7 @@ jobs:
           - fedora:latest
           - fedora:33
           - fedora:32
+          - ubuntu:impish
           - ubuntu:hirsute
           - ubuntu:focal
           - ubuntu:bionic
@@ -97,6 +98,20 @@ jobs:
             variant: sanitizers
 
           # Ubuntu 32-bit builds
+          - container: "ubuntu:impish"
+            arch: i386
+            compiler: gcc -m32
+            cross_compile: i686-linux-gnu
+            mode: maintainer
+            variant: i386
+
+          - container: "ubuntu:impish"
+            arch: i386
+            compiler: gcc -m32
+            cross_compile: i686-linux-gnu
+            mode: no-maintainer
+            variant: i386
+
           - container: "ubuntu:hirsute"
             arch: i386
             compiler: gcc -m32
@@ -126,6 +141,12 @@ jobs:
             variant: i386
 
           # Ubuntu GCC sanitizer builds
+          - container: "ubuntu:impish"
+            arch: x86-64
+            compiler: gcc
+            mode: maintainer
+            variant: sanitizers
+
           - container: "ubuntu:hirsute"
             arch: x86-64
             compiler: gcc
-- 
2.32.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [neard][PATCH 3/4] ci: add Debian Buster and Stretch
  2021-11-07 17:26 [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch Krzysztof Kozlowski
  2021-11-07 17:26 ` [neard][PATCH 2/4] ci: add Ubuntu Impish (21.10) Krzysztof Kozlowski
@ 2021-11-07 17:26 ` Krzysztof Kozlowski
  2021-11-07 17:26 ` [neard][PATCH 4/4] ci: add Debian Testing for i386 and cross compile Krzysztof Kozlowski
  2021-11-11 10:46 ` [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-07 17:26 UTC (permalink / raw)
  To: linux-nfc

[-- Attachment #1: Type: text/plain, Size: 2411 bytes --]

Add older releases of Debian: Buster and Stretch.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .github/workflows/ci.yml | 39 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 38 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 5540ad2ebc39..aed8c089351d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -26,6 +26,9 @@ jobs:
           - archlinux:latest
           - debian:testing
           - debian:stable
+          - debian:bullseye
+          - debian:buster
+          - debian:stretch
           # Fails on configure on GCC and clang (process restrictions?)
           # - fedora:rawhide
           - fedora:latest
@@ -55,6 +58,34 @@ jobs:
             mode: no-maintainer
             variant: i386
 
+          - container: "debian:buster"
+            arch: i386
+            compiler: gcc -m32
+            cross_compile: i686-linux-gnu
+            mode: maintainer
+            variant: i386
+
+          - container: "debian:buster"
+            arch: i386
+            compiler: gcc -m32
+            cross_compile: i686-linux-gnu
+            mode: no-maintainer
+            variant: i386
+
+          - container: "debian:stretch"
+            arch: i386
+            compiler: gcc -m32
+            cross_compile: i686-linux-gnu
+            mode: maintainer
+            variant: i386
+
+          - container: "debian:stretch"
+            arch: i386
+            compiler: gcc -m32
+            cross_compile: i686-linux-gnu
+            mode: no-maintainer
+            variant: i386
+
           # Debian cross compilation builds
           - container: "debian:stable"
             arch: armel
@@ -85,13 +116,19 @@ jobs:
             variant: cross-compile
 
           # Debian GCC sanitizer builds
+          - container: "debian:testing"
+            arch: x86-64
+            compiler: gcc
+            mode: maintainer
+            variant: sanitizers
+
           - container: "debian:stable"
             arch: x86-64
             compiler: gcc
             mode: maintainer
             variant: sanitizers
 
-          - container: "debian:testing"
+          - container: "debian:buster"
             arch: x86-64
             compiler: gcc
             mode: maintainer
-- 
2.32.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [neard][PATCH 4/4] ci: add Debian Testing for i386 and cross compile
  2021-11-07 17:26 [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch Krzysztof Kozlowski
  2021-11-07 17:26 ` [neard][PATCH 2/4] ci: add Ubuntu Impish (21.10) Krzysztof Kozlowski
  2021-11-07 17:26 ` [neard][PATCH 3/4] ci: add Debian Buster and Stretch Krzysztof Kozlowski
@ 2021-11-07 17:26 ` Krzysztof Kozlowski
  2021-11-11 10:46 ` [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-07 17:26 UTC (permalink / raw)
  To: linux-nfc

[-- Attachment #1: Type: text/plain, Size: 2211 bytes --]

Build also Debian Testing on i386 and cross compile configurations.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
 .github/workflows/ci.yml | 42 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index aed8c089351d..2e1ad40debb9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -44,6 +44,20 @@ jobs:
         variant: [""]
         include:
           # Debian 32-bit builds
+          - container: "debian:testing"
+            arch: i386
+            compiler: gcc -m32
+            cross_compile: i686-linux-gnu
+            mode: maintainer
+            variant: i386
+
+          - container: "debian:testing"
+            arch: i386
+            compiler: gcc -m32
+            cross_compile: i686-linux-gnu
+            mode: no-maintainer
+            variant: i386
+
           - container: "debian:stable"
             arch: i386
             compiler: gcc -m32
@@ -87,6 +101,34 @@ jobs:
             variant: i386
 
           # Debian cross compilation builds
+          - container: "debian:testing"
+            arch: armel
+            compiler: arm-linux-gnueabi-gcc
+            cross_compile: arm-linux-gnueabi
+            mode: maintainer
+            variant: cross-compile
+
+          - container: "debian:testing"
+            arch: arm64
+            compiler: aarch64-linux-gnu-gcc
+            cross_compile: aarch64-linux-gnu
+            mode: maintainer
+            variant: cross-compile
+
+          - container: "debian:testing"
+            arch: ppc64el
+            compiler: powerpc64le-linux-gnu-gcc
+            cross_compile: powerpc64le-linux-gnu
+            mode: maintainer
+            variant: cross-compile
+
+          - container: "debian:testing"
+            arch: s390x
+            compiler: s390x-linux-gnu-gcc
+            cross_compile: s390x-linux-gnu
+            mode: maintainer
+            variant: cross-compile
+
           - container: "debian:stable"
             arch: armel
             compiler: arm-linux-gnueabi-gcc
-- 
2.32.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch
  2021-11-07 17:26 [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2021-11-07 17:26 ` [neard][PATCH 4/4] ci: add Debian Testing for i386 and cross compile Krzysztof Kozlowski
@ 2021-11-11 10:46 ` Krzysztof Kozlowski
  3 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-11 10:46 UTC (permalink / raw)
  To: linux-nfc

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On 07/11/2021 18:26, Krzysztof Kozlowski wrote:
> Code should pull explicitly headers for necessary symbols instead of
> relying on dependencies.  Lack of endian.h caused build failures on
> Debian Stretch:
> 
>     In file included from tools/nfctool/ndef-decode.c:28:0:
>     include/near/types.h:43:5: error: "__BYTE_ORDER" is not defined [-Werror=undef]
>      #if __BYTE_ORDER == __LITTLE_ENDIAN
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---
>  include/types.h | 1 +
>  1 file changed, 1 insertion(+)
> 

Applied.


Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-11 10:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-07 17:26 [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch Krzysztof Kozlowski
2021-11-07 17:26 ` [neard][PATCH 2/4] ci: add Ubuntu Impish (21.10) Krzysztof Kozlowski
2021-11-07 17:26 ` [neard][PATCH 3/4] ci: add Debian Buster and Stretch Krzysztof Kozlowski
2021-11-07 17:26 ` [neard][PATCH 4/4] ci: add Debian Testing for i386 and cross compile Krzysztof Kozlowski
2021-11-11 10:46 ` [neard][PATCH 1/4] include: include endian.h to fix missing __BYTE_ORDER definition on Debian Stretch Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).