* Re: [PATCH 00/12] nfc: constify, continued (part 2)
[not found] <162755820704.26856.6157999905884570707.git-patchwork-notify@kernel.org>
@ 2021-07-29 11:35 ` Krzysztof Kozlowski
2021-07-29 11:58 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-29 11:35 UTC (permalink / raw)
To: linux-nfc
[-- Attachment #1: Type: text/plain, Size: 2156 bytes --]
On 29/07/2021 13:30, patchwork-bot+netdevbpf(a)kernel.org wrote:
> Hello:
>
> This series was applied to netdev/net-next.git (refs/heads/master):
>
> On Thu, 29 Jul 2021 12:40:10 +0200 you wrote:
>> Hi,
>>
>> On top of:
>> nfc: constify pointed data
>> https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski(a)canonical.com/
>>
>> Best regards,
>> Krzysztof
>>
>> [...]
>
> Here is the summary with links:
> - [01/12] nfc: constify passed nfc_dev
> https://git.kernel.org/netdev/net-next/c/dd8987a394c0
> - [02/12] nfc: mei_phy: constify buffer passed to mei_nfc_send()
> https://git.kernel.org/netdev/net-next/c/894a6e158633
> - [03/12] nfc: port100: constify several pointers
> https://git.kernel.org/netdev/net-next/c/9a4af01c35a5
> - [04/12] nfc: trf7970a: constify several pointers
> https://git.kernel.org/netdev/net-next/c/ea050c5ee74a
> - [05/12] nfc: virtual_ncidev: constify pointer to nfc_dev
> https://git.kernel.org/netdev/net-next/c/83428dbbac51
> - [06/12] nfc: nfcsim: constify drvdata (struct nfcsim)
> https://git.kernel.org/netdev/net-next/c/582fdc98adc8
> - [07/12] nfc: fdp: drop unneeded cast for printing firmware size in dev_dbg()
> https://git.kernel.org/netdev/net-next/c/6c755b1d2511
> - [08/12] nfc: fdp: use unsigned int as loop iterator
> https://git.kernel.org/netdev/net-next/c/c3e26b6dc1b4
> - [09/12] nfc: fdp: constify several pointers
> https://git.kernel.org/netdev/net-next/c/3d463dd5023b
> - [10/12] nfc: microread: constify several pointers
> https://git.kernel.org/netdev/net-next/c/a751449f8b47
> - [11/12] nfc: mrvl: constify several pointers
> https://git.kernel.org/netdev/net-next/c/fe53159fe3e0
Oh, folks, too fast :)
Sorry for the mess, but the patch 11/12 has one const which is wrong
(I sent an email for it) and this should be on top of my
previous set:
https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski(a)canonical.com/
which I think you did not take in.
I am not sure if it compiles cleanly without the one above.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 00/12] nfc: constify, continued (part 2)
2021-07-29 11:35 ` [PATCH 00/12] nfc: constify, continued (part 2) Krzysztof Kozlowski
@ 2021-07-29 11:58 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-29 11:58 UTC (permalink / raw)
To: linux-nfc
[-- Attachment #1: Type: text/plain, Size: 2766 bytes --]
On 29/07/2021 13:35, Krzysztof Kozlowski wrote:
> On 29/07/2021 13:30, patchwork-bot+netdevbpf(a)kernel.org wrote:
>> Hello:
>>
>> This series was applied to netdev/net-next.git (refs/heads/master):
>>
>> On Thu, 29 Jul 2021 12:40:10 +0200 you wrote:
>>> Hi,
>>>
>>> On top of:
>>> nfc: constify pointed data
>>> https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski(a)canonical.com/
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>> [...]
>>
>> Here is the summary with links:
>> - [01/12] nfc: constify passed nfc_dev
>> https://git.kernel.org/netdev/net-next/c/dd8987a394c0
>> - [02/12] nfc: mei_phy: constify buffer passed to mei_nfc_send()
>> https://git.kernel.org/netdev/net-next/c/894a6e158633
>> - [03/12] nfc: port100: constify several pointers
>> https://git.kernel.org/netdev/net-next/c/9a4af01c35a5
>> - [04/12] nfc: trf7970a: constify several pointers
>> https://git.kernel.org/netdev/net-next/c/ea050c5ee74a
>> - [05/12] nfc: virtual_ncidev: constify pointer to nfc_dev
>> https://git.kernel.org/netdev/net-next/c/83428dbbac51
>> - [06/12] nfc: nfcsim: constify drvdata (struct nfcsim)
>> https://git.kernel.org/netdev/net-next/c/582fdc98adc8
>> - [07/12] nfc: fdp: drop unneeded cast for printing firmware size in dev_dbg()
>> https://git.kernel.org/netdev/net-next/c/6c755b1d2511
>> - [08/12] nfc: fdp: use unsigned int as loop iterator
>> https://git.kernel.org/netdev/net-next/c/c3e26b6dc1b4
>> - [09/12] nfc: fdp: constify several pointers
>> https://git.kernel.org/netdev/net-next/c/3d463dd5023b
>> - [10/12] nfc: microread: constify several pointers
>> https://git.kernel.org/netdev/net-next/c/a751449f8b47
>> - [11/12] nfc: mrvl: constify several pointers
>> https://git.kernel.org/netdev/net-next/c/fe53159fe3e0
>
> Oh, folks, too fast :)
>
> Sorry for the mess, but the patch 11/12 has one const which is wrong
> (I sent an email for it) and this should be on top of my
> previous set:
> https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski(a)canonical.com/
> which I think you did not take in.
>
> I am not sure if it compiles cleanly without the one above.
Hi David,
This fails because of missing patchset above:
../drivers/nfc/fdp/fdp.c: In function ‘fdp_nci_set_production_data’:
../drivers/nfc/fdp/fdp.c:116:60: warning: passing argument 4 of
‘nci_prop_cmd’ discards ‘const’ qualifier from pointer target type
[-Wdiscarded-qualifiers]
116 | return nci_prop_cmd(ndev, NCI_OP_PROP_SET_PDATA_OID, len, data);
It also has one issue in patch 11/12. Can you drop this from
net-dev/master? I can send a v2 of both patchsets combined.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 00/12] nfc: constify, continued (part 2)
@ 2021-07-29 10:40 Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2021-07-29 10:40 UTC (permalink / raw)
To: linux-nfc
[-- Attachment #1: Type: text/plain, Size: 1761 bytes --]
Hi,
On top of:
nfc: constify pointed data
https://lore.kernel.org/lkml/20210726145224.146006-1-krzysztof.kozlowski(a)canonical.com/
Best regards,
Krzysztof
Krzysztof Kozlowski (12):
nfc: constify passed nfc_dev
nfc: mei_phy: constify buffer passed to mei_nfc_send()
nfc: port100: constify several pointers
nfc: trf7970a: constify several pointers
nfc: virtual_ncidev: constify pointer to nfc_dev
nfc: nfcsim: constify drvdata (struct nfcsim)
nfc: fdp: drop unneeded cast for printing firmware size in dev_dbg()
nfc: fdp: use unsigned int as loop iterator
nfc: fdp: constify several pointers
nfc: microread: constify several pointers
nfc: mrvl: constify several pointers
nfc: mrvl: constify static nfcmrvl_if_ops
drivers/nfc/fdp/fdp.c | 27 +++++++++++-----------
drivers/nfc/fdp/fdp.h | 2 +-
drivers/nfc/fdp/i2c.c | 6 ++---
drivers/nfc/mei_phy.c | 2 +-
drivers/nfc/microread/i2c.c | 2 +-
drivers/nfc/microread/microread.c | 4 ++--
drivers/nfc/microread/microread.h | 2 +-
drivers/nfc/nfcmrvl/fw_dnld.c | 16 +++++++------
drivers/nfc/nfcmrvl/i2c.c | 4 ++--
drivers/nfc/nfcmrvl/main.c | 4 ++--
drivers/nfc/nfcmrvl/nfcmrvl.h | 6 ++---
drivers/nfc/nfcmrvl/spi.c | 6 ++---
drivers/nfc/nfcmrvl/uart.c | 4 ++--
drivers/nfc/nfcmrvl/usb.c | 2 +-
drivers/nfc/nfcsim.c | 2 +-
drivers/nfc/port100.c | 37 +++++++++++++++++--------------
drivers/nfc/trf7970a.c | 17 +++++++-------
drivers/nfc/virtual_ncidev.c | 2 +-
include/net/nfc/nfc.h | 4 ++--
19 files changed, 78 insertions(+), 71 deletions(-)
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-29 11:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <162755820704.26856.6157999905884570707.git-patchwork-notify@kernel.org>
2021-07-29 11:35 ` [PATCH 00/12] nfc: constify, continued (part 2) Krzysztof Kozlowski
2021-07-29 11:58 ` Krzysztof Kozlowski
2021-07-29 10:40 Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).