From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH 2/3] radio-settings: Add handling of dual mode technology preference
Date: Tue, 01 Jun 2021 10:53:40 -0500 [thread overview]
Message-ID: <7701b2b8-fca3-c82d-22e9-aa4aa4e866fc@gmail.com> (raw)
In-Reply-To: <20210531114932.68629-2-sean@geanix.com>
[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]
Hi Sean,
On 5/31/21 6:49 AM, Sean Nyekjaer wrote:
> Allow setting of "lte,gsm" mode,
> for modems that doesn't support ANY mode.
> ---
> src/radio-settings.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/src/radio-settings.c b/src/radio-settings.c
> index 7283aa98..e2e5f33b 100644
> --- a/src/radio-settings.c
> +++ b/src/radio-settings.c
> @@ -79,6 +79,9 @@ static const char *radio_access_mode_to_string(enum ofono_radio_access_mode m)
> if (m == (OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_UMTS))
> return "lte,umts";
>
> + if (m = (OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_GSM))
I think you meant '==' here, so I fixed that.
> + return "lte,gsm";
> +
> return NULL;
> }
>
> @@ -104,6 +107,9 @@ static gboolean radio_access_mode_from_string(const char *str,
> } else if (g_str_equal(str, "lte,umts")) {
> *mode = OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_UMTS;
> return TRUE;
> + } else if (g_str_equal(str, "lte,gsm")) {
> + *mode = OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_GSM;
> + return TRUE;
> }
>
> return FALSE;
>
All three patches applied, thanks.
Regards,
-Denis
parent reply other threads:[~2021-06-01 15:53 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210531114932.68629-2-sean@geanix.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7701b2b8-fca3-c82d-22e9-aa4aa4e866fc@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).