Re: [PATCH 2/3] radio-settings: Add handling of dual mode technology preference

Re: [PATCH 2/3] radio-settings: Add handling of dual mode technology preference

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1225 bytes --]

Hi Sean,

On 5/31/21 6:49 AM, Sean Nyekjaer wrote:
> Allow setting of "lte,gsm" mode,
> for modems that doesn't support ANY mode.
> ---
>   src/radio-settings.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/src/radio-settings.c b/src/radio-settings.c
> index 7283aa98..e2e5f33b 100644
> --- a/src/radio-settings.c
> +++ b/src/radio-settings.c
> @@ -79,6 +79,9 @@ static const char *radio_access_mode_to_string(enum ofono_radio_access_mode m)
>   	if (m == (OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_UMTS))
>   		return "lte,umts";
>   
> +	if (m = (OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_GSM))

I think you meant '==' here, so I fixed that.

> +		return "lte,gsm";
> +
>   	return NULL;
>   }
>   
> @@ -104,6 +107,9 @@ static gboolean radio_access_mode_from_string(const char *str,
>   	} else if (g_str_equal(str, "lte,umts")) {
>   		*mode = OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_UMTS;
>   		return TRUE;
> +	} else if (g_str_equal(str, "lte,gsm")) {
> +		*mode = OFONO_RADIO_ACCESS_MODE_LTE|OFONO_RADIO_ACCESS_MODE_GSM;
> +		return TRUE;
>   	}
>   
>   	return FALSE;
> 

All three patches applied, thanks.

Regards,
-Denis