From: Stephen Boyd <sboyd@kernel.org>
To: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Michael Turquette <mturquette@baylibre.com>,
vijaykhemka@fb.com, chyishian.jiang@gmail.com,
linux-clk@vger.kernel.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-aspeed@lists.ozlabs.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH v2] clk: aspeed: Mark lclk (LPC) and espiclk (eSPI) as critical
Date: Tue, 04 Dec 2018 12:54:34 -0800 [thread overview]
Message-ID: <154395687459.88331.13570416457347078441@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CACPK8XcwMMoxG6vhDhUU8RYGABx7rtBoxJvp2yDhHeD-PemdqA@mail.gmail.com>
Quoting Joel Stanley (2018-12-04 12:51:43)
> Hi Jae,
>
> On Wed, 5 Dec 2018 at 05:20, Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> wrote:
> >
> > These interfaces are used by host to talk to BMC, and the clock
> > source is from the host, usually from PCH. So this commit marks
> > the lclk as critical to make it able to be enabled. Also, it marks
> > espiclk too because eSPI is sharing the same interface with LPC.
>
> While this is true on the platform you have in mind, on other
> platforms this is not the case. They do not use eSPI, and LCLK is
> enabled by the driver that is used to configure LPC
> (drivers/misc/aspeed-lpc-ctrl.c):
>
> lpc_ctrl: lpc-ctrl@0 {
> compatible = "aspeed,ast2400-lpc-ctrl";
> reg = <0x0 0x80>;
> clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
> }
>
> I wonder if we need a device tree binding to describe which clocks are critical.
A binding to describe critical clks has been rejected in the past. I
don't think we need to have it here either? More information on why
things are being marked critical will be helpful to see if we need to
re-open that discussion again.
>
> Stephen, please don't merge this patch yet.
>
Sure.
next prev parent reply other threads:[~2018-12-04 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 18:50 [PATCH v2] clk: aspeed: Mark lclk (LPC) and espiclk (eSPI) as critical Jae Hyun Yoo
2018-12-04 20:50 ` Stephen Boyd
2018-12-04 20:51 ` Joel Stanley
2018-12-04 20:54 ` Stephen Boyd [this message]
2018-12-05 15:04 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154395687459.88331.13570416457347078441@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=andrew@aj.id.au \
--cc=chyishian.jiang@gmail.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=stable@vger.kernel.org \
--cc=vijaykhemka@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).