archive mirror
 help / color / mirror / Atom feed
From: Jae Hyun Yoo <>
To: Stephen Boyd <>, Joel Stanley <>
Cc:, Andrew Jeffery <>,
	OpenBMC Maillist <>,
	Michael Turquette <>,, "# 3.4.x" <>,,,
	Linux ARM <>
Subject: Re: [PATCH v2] clk: aspeed: Mark lclk (LPC) and espiclk (eSPI) as critical
Date: Wed, 5 Dec 2018 09:04:30 -0600	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 12/4/2018 2:54 PM, Stephen Boyd wrote:
> Quoting Joel Stanley (2018-12-04 12:51:43)
>> Hi Jae,
>> On Wed, 5 Dec 2018 at 05:20, Jae Hyun Yoo <> wrote:
>>> These interfaces are used by host to talk to BMC, and the clock
>>> source is from the host, usually from PCH. So this commit marks
>>> the lclk as critical to make it able to be enabled. Also, it marks
>>> espiclk too because eSPI is sharing the same interface with LPC.
>> While this is true on the platform you have in mind, on other
>> platforms this is not the case. They do not use eSPI, and LCLK is
>> enabled by the driver that is used to configure LPC
>> (drivers/misc/aspeed-lpc-ctrl.c):
>>   lpc_ctrl: lpc-ctrl@0 {
>>       compatible = "aspeed,ast2400-lpc-ctrl";
>>       reg = <0x0 0x80>;
>>       clocks = <&syscon ASPEED_CLK_GATE_LCLK>;
>>   }
>> I wonder if we need a device tree binding to describe which clocks are critical.
> A binding to describe critical clks has been rejected in the past. I
> don't think we need to have it here either? More information on why
> things are being marked critical will be helpful to see if we need to
> re-open that discussion again.
>> Stephen, please don't merge this patch yet.
> Sure.

Hi Stephen and Joel,

Thanks for blocking this patch. We checked that LCLK gate can be opened
by enabling lpc-ctrl node without using this change. Please drop this


      reply	other threads:[~2018-12-05 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 18:50 Jae Hyun Yoo
2018-12-04 20:50 ` Stephen Boyd
2018-12-04 20:51 ` Joel Stanley
2018-12-04 20:54   ` Stephen Boyd
2018-12-05 15:04     ` Jae Hyun Yoo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v2] clk: aspeed: Mark lclk (LPC) and espiclk (eSPI) as critical' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).