* [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support
@ 2022-07-17 12:11 Tomer Maimon
2022-07-17 12:11 ` [PATCH v1 1/2] dt-bindings: ipmi: Add npcm845 compatible Tomer Maimon
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Tomer Maimon @ 2022-07-17 12:11 UTC (permalink / raw)
To: avifishman70, tali.perry1, joel, venture, yuenn, benjaminfair,
jic23, minyard, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, openbmc, Tomer Maimon, openipmi-developer, linux-kernel
This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
KCS NPCM driver.
The NPCM KCS driver tested on NPCM845 evaluation board.
Tomer Maimon (2):
dt-bindings: ipmi: Add npcm845 compatible
char: ipmi: modify NPCM KCS configuration
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
drivers/char/ipmi/Kconfig | 6 +++---
2 files changed, 6 insertions(+), 5 deletions(-)
--
2.33.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v1 1/2] dt-bindings: ipmi: Add npcm845 compatible
2022-07-17 12:11 [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support Tomer Maimon
@ 2022-07-17 12:11 ` Tomer Maimon
2022-07-17 12:11 ` [PATCH v1 2/2] char: ipmi: modify NPCM KCS configuration Tomer Maimon
2022-07-18 12:51 ` [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support Corey Minyard
2 siblings, 0 replies; 9+ messages in thread
From: Tomer Maimon @ 2022-07-17 12:11 UTC (permalink / raw)
To: avifishman70, tali.perry1, joel, venture, yuenn, benjaminfair,
jic23, minyard, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, openbmc, Tomer Maimon, openipmi-developer, linux-kernel
Add a compatible string for Nuvoton BMC NPCM845 KCS and modify NPCM KCS
description to support all NPCM BMC SoC.
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
index 352f5e9c759b..cbc10a68ddef 100644
--- a/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
+++ b/Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt
@@ -1,12 +1,13 @@
-* Nuvoton NPCM7xx KCS (Keyboard Controller Style) IPMI interface
+* Nuvoton NPCM KCS (Keyboard Controller Style) IPMI interface
-The Nuvoton SOCs (NPCM7xx) are commonly used as BMCs
+The Nuvoton SOCs (NPCM) are commonly used as BMCs
(Baseboard Management Controllers) and the KCS interface can be
used to perform in-band IPMI communication with their host.
Required properties:
- compatible : should be one of
"nuvoton,npcm750-kcs-bmc"
+ "nuvoton,npcm845-kcs-bmc"
- interrupts : interrupt generated by the controller
- kcs_chan : The KCS channel number in the controller
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v1 2/2] char: ipmi: modify NPCM KCS configuration
2022-07-17 12:11 [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support Tomer Maimon
2022-07-17 12:11 ` [PATCH v1 1/2] dt-bindings: ipmi: Add npcm845 compatible Tomer Maimon
@ 2022-07-17 12:11 ` Tomer Maimon
2022-07-18 12:51 ` [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support Corey Minyard
2 siblings, 0 replies; 9+ messages in thread
From: Tomer Maimon @ 2022-07-17 12:11 UTC (permalink / raw)
To: avifishman70, tali.perry1, joel, venture, yuenn, benjaminfair,
jic23, minyard, robh+dt, krzysztof.kozlowski+dt
Cc: devicetree, openbmc, Tomer Maimon, openipmi-developer, linux-kernel
Modify NPCM IPMI KCS configuration to support all NPCM BMC SoC.
Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
---
drivers/char/ipmi/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig
index b061e6b513ed..39565cf74b2c 100644
--- a/drivers/char/ipmi/Kconfig
+++ b/drivers/char/ipmi/Kconfig
@@ -119,13 +119,13 @@ config ASPEED_KCS_IPMI_BMC
provides the access of KCS IO space for BMC side.
config NPCM7XX_KCS_IPMI_BMC
- depends on ARCH_NPCM7XX || COMPILE_TEST
+ depends on ARCH_NPCM || COMPILE_TEST
select IPMI_KCS_BMC
select REGMAP_MMIO
- tristate "NPCM7xx KCS IPMI BMC driver"
+ tristate "NPCM KCS IPMI BMC driver"
help
Provides a driver for the KCS (Keyboard Controller Style) IPMI
- interface found on Nuvoton NPCM7xx SOCs.
+ interface found on Nuvoton NPCM SOCs.
The driver implements the BMC side of the KCS contorller, it
provides the access of KCS IO space for BMC side.
--
2.33.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support
2022-07-17 12:11 [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support Tomer Maimon
2022-07-17 12:11 ` [PATCH v1 1/2] dt-bindings: ipmi: Add npcm845 compatible Tomer Maimon
2022-07-17 12:11 ` [PATCH v1 2/2] char: ipmi: modify NPCM KCS configuration Tomer Maimon
@ 2022-07-18 12:51 ` Corey Minyard
2022-07-26 19:41 ` Tomer Maimon
2 siblings, 1 reply; 9+ messages in thread
From: Corey Minyard @ 2022-07-18 12:51 UTC (permalink / raw)
To: Tomer Maimon
Cc: devicetree, benjaminfair, avifishman70, venture, openbmc,
linux-kernel, tali.perry1, robh+dt, joel, krzysztof.kozlowski+dt,
openipmi-developer, jic23
On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> KCS NPCM driver.
>
> The NPCM KCS driver tested on NPCM845 evaluation board.
This seems reasonable, I've pulled it into my tree. If anyone has any
issues with this, please respond.
-corey
>
> Tomer Maimon (2):
> dt-bindings: ipmi: Add npcm845 compatible
> char: ipmi: modify NPCM KCS configuration
>
> Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> drivers/char/ipmi/Kconfig | 6 +++---
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> --
> 2.33.0
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support
2022-07-18 12:51 ` [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support Corey Minyard
@ 2022-07-26 19:41 ` Tomer Maimon
2022-07-26 19:47 ` Corey Minyard
0 siblings, 1 reply; 9+ messages in thread
From: Tomer Maimon @ 2022-07-26 19:41 UTC (permalink / raw)
To: minyard
Cc: devicetree, Benjamin Fair, Avi Fishman, Patrick Venture,
OpenBMC Maillist, Linux Kernel Mailing List, Tali Perry,
Rob Herring, Joel Stanley, Krzysztof Kozlowski,
openipmi-developer, Jonathan Cameron
Hi Corey,
On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
>
> On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > KCS NPCM driver.
> >
> > The NPCM KCS driver tested on NPCM845 evaluation board.
>
> This seems reasonable, I've pulled it into my tree. If anyone has any
> issues with this, please respond.
>
> -corey
>
> >
> > Tomer Maimon (2):
> > dt-bindings: ipmi: Add npcm845 compatible
> > char: ipmi: modify NPCM KCS configuration
> >
> > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > drivers/char/ipmi/Kconfig | 6 +++---
> > 2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > --
> > 2.33.0
> >
Sorry but I need to do a little fix in the document file.
Can I do it or have you already applied the patches?
Thanks,
Tomer
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support
2022-07-26 19:41 ` Tomer Maimon
@ 2022-07-26 19:47 ` Corey Minyard
2022-07-27 5:39 ` Tomer Maimon
0 siblings, 1 reply; 9+ messages in thread
From: Corey Minyard @ 2022-07-26 19:47 UTC (permalink / raw)
To: Tomer Maimon
Cc: devicetree, Benjamin Fair, Avi Fishman, Patrick Venture,
OpenBMC Maillist, Linux Kernel Mailing List, Tali Perry,
Rob Herring, Joel Stanley, Krzysztof Kozlowski,
openipmi-developer, Jonathan Cameron
On Tue, Jul 26, 2022 at 10:41:38PM +0300, Tomer Maimon wrote:
> Hi Corey,
>
>
> On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
> >
> > On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > > KCS NPCM driver.
> > >
> > > The NPCM KCS driver tested on NPCM845 evaluation board.
> >
> > This seems reasonable, I've pulled it into my tree. If anyone has any
> > issues with this, please respond.
> >
> > -corey
> >
> > >
> > > Tomer Maimon (2):
> > > dt-bindings: ipmi: Add npcm845 compatible
> > > char: ipmi: modify NPCM KCS configuration
> > >
> > > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > > drivers/char/ipmi/Kconfig | 6 +++---
> > > 2 files changed, 6 insertions(+), 5 deletions(-)
> > >
> > > --
> > > 2.33.0
> > >
>
> Sorry but I need to do a little fix in the document file.
>
> Can I do it or have you already applied the patches?
At this point I'd prefer a patch on top of what is there. 5.19 isn't
released yet, so the window isn't open, but that will happen soon and I
don't want to rebase at this point.
-corey
>
> Thanks,
>
> Tomer
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support
2022-07-26 19:47 ` Corey Minyard
@ 2022-07-27 5:39 ` Tomer Maimon
2022-07-27 15:47 ` Corey Minyard
0 siblings, 1 reply; 9+ messages in thread
From: Tomer Maimon @ 2022-07-27 5:39 UTC (permalink / raw)
To: minyard
Cc: devicetree, Benjamin Fair, Avi Fishman, Patrick Venture,
OpenBMC Maillist, Linux Kernel Mailing List, Tali Perry,
Rob Herring, Joel Stanley, Krzysztof Kozlowski,
openipmi-developer, Jonathan Cameron
Hi Corey,
On Tue, 26 Jul 2022 at 22:47, Corey Minyard <minyard@acm.org> wrote:
>
> On Tue, Jul 26, 2022 at 10:41:38PM +0300, Tomer Maimon wrote:
> > Hi Corey,
> >
> >
> > On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
> > >
> > > On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > > > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > > > KCS NPCM driver.
> > > >
> > > > The NPCM KCS driver tested on NPCM845 evaluation board.
> > >
> > > This seems reasonable, I've pulled it into my tree. If anyone has any
> > > issues with this, please respond.
> > >
> > > -corey
> > >
> > > >
> > > > Tomer Maimon (2):
> > > > dt-bindings: ipmi: Add npcm845 compatible
> > > > char: ipmi: modify NPCM KCS configuration
> > > >
> > > > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > > > drivers/char/ipmi/Kconfig | 6 +++---
> > > > 2 files changed, 6 insertions(+), 5 deletions(-)
> > > >
> > > > --
> > > > 2.33.0
> > > >
> >
> > Sorry but I need to do a little fix in the document file.
> >
> > Can I do it or have you already applied the patches?
>
> At this point I'd prefer a patch on top of what is there. 5.19 isn't
> released yet, so the window isn't open, but that will happen soon and I
> don't want to rebase at this point.
O.K. thanks,
I will wait until 5.19 is released and then I will send the patch.
>
> -corey
>
> >
> > Thanks,
> >
> > Tomer
Best regards,
Tomer
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support
2022-07-27 5:39 ` Tomer Maimon
@ 2022-07-27 15:47 ` Corey Minyard
2022-08-04 14:57 ` Tomer Maimon
0 siblings, 1 reply; 9+ messages in thread
From: Corey Minyard @ 2022-07-27 15:47 UTC (permalink / raw)
To: Tomer Maimon
Cc: devicetree, Benjamin Fair, Avi Fishman, Patrick Venture,
OpenBMC Maillist, Linux Kernel Mailing List, Tali Perry,
Rob Herring, Joel Stanley, Krzysztof Kozlowski,
openipmi-developer, Jonathan Cameron
On Wed, Jul 27, 2022 at 08:39:08AM +0300, Tomer Maimon wrote:
> Hi Corey,
>
> On Tue, 26 Jul 2022 at 22:47, Corey Minyard <minyard@acm.org> wrote:
> >
> > On Tue, Jul 26, 2022 at 10:41:38PM +0300, Tomer Maimon wrote:
> > > Hi Corey,
> > >
> > >
> > > On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
> > > >
> > > > On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > > > > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > > > > KCS NPCM driver.
> > > > >
> > > > > The NPCM KCS driver tested on NPCM845 evaluation board.
> > > >
> > > > This seems reasonable, I've pulled it into my tree. If anyone has any
> > > > issues with this, please respond.
> > > >
> > > > -corey
> > > >
> > > > >
> > > > > Tomer Maimon (2):
> > > > > dt-bindings: ipmi: Add npcm845 compatible
> > > > > char: ipmi: modify NPCM KCS configuration
> > > > >
> > > > > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > > > > drivers/char/ipmi/Kconfig | 6 +++---
> > > > > 2 files changed, 6 insertions(+), 5 deletions(-)
> > > > >
> > > > > --
> > > > > 2.33.0
> > > > >
> > >
> > > Sorry but I need to do a little fix in the document file.
> > >
> > > Can I do it or have you already applied the patches?
> >
> > At this point I'd prefer a patch on top of what is there. 5.19 isn't
> > released yet, so the window isn't open, but that will happen soon and I
> > don't want to rebase at this point.
> O.K. thanks,
> I will wait until 5.19 is released and then I will send the patch.
Oh, sorry I wasn't clear. You can send it now, I just don't want to
rebase what I have already. Just a new patch on top of it, and I'll get
it in to 5.19.
-corey
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support
2022-07-27 15:47 ` Corey Minyard
@ 2022-08-04 14:57 ` Tomer Maimon
0 siblings, 0 replies; 9+ messages in thread
From: Tomer Maimon @ 2022-08-04 14:57 UTC (permalink / raw)
To: minyard
Cc: devicetree, Benjamin Fair, Avi Fishman, Patrick Venture,
OpenBMC Maillist, Linux Kernel Mailing List, Tali Perry,
Rob Herring, Joel Stanley, Krzysztof Kozlowski,
openipmi-developer, Jonathan Cameron
Hi Corey,
Sorry, miss this email...
On Wed, 27 Jul 2022 at 18:47, Corey Minyard <minyard@acm.org> wrote:
>
> On Wed, Jul 27, 2022 at 08:39:08AM +0300, Tomer Maimon wrote:
> > Hi Corey,
> >
> > On Tue, 26 Jul 2022 at 22:47, Corey Minyard <minyard@acm.org> wrote:
> > >
> > > On Tue, Jul 26, 2022 at 10:41:38PM +0300, Tomer Maimon wrote:
> > > > Hi Corey,
> > > >
> > > >
> > > > On Mon, 18 Jul 2022 at 15:51, Corey Minyard <minyard@acm.org> wrote:
> > > > >
> > > > > On Sun, Jul 17, 2022 at 03:11:22PM +0300, Tomer Maimon wrote:
> > > > > > This patch set adds Arbel NPCM8XX Keyboard Controller Style (KCS) support to
> > > > > > KCS NPCM driver.
> > > > > >
> > > > > > The NPCM KCS driver tested on NPCM845 evaluation board.
> > > > >
> > > > > This seems reasonable, I've pulled it into my tree. If anyone has any
> > > > > issues with this, please respond.
> > > > >
> > > > > -corey
> > > > >
> > > > > >
> > > > > > Tomer Maimon (2):
> > > > > > dt-bindings: ipmi: Add npcm845 compatible
> > > > > > char: ipmi: modify NPCM KCS configuration
> > > > > >
> > > > > > Documentation/devicetree/bindings/ipmi/npcm7xx-kcs-bmc.txt | 5 +++--
> > > > > > drivers/char/ipmi/Kconfig | 6 +++---
> > > > > > 2 files changed, 6 insertions(+), 5 deletions(-)
> > > > > >
> > > > > > --
> > > > > > 2.33.0
> > > > > >
> > > >
> > > > Sorry but I need to do a little fix in the document file.
> > > >
> > > > Can I do it or have you already applied the patches?
> > >
> > > At this point I'd prefer a patch on top of what is there. 5.19 isn't
> > > released yet, so the window isn't open, but that will happen soon and I
> > > don't want to rebase at this point.
> > O.K. thanks,
> > I will wait until 5.19 is released and then I will send the patch.
>
> Oh, sorry I wasn't clear. You can send it now, I just don't want to
> rebase what I have already. Just a new patch on top of it, and I'll get
> it in to 5.19.
>
> -corey
Sent a patch now.
Best regards,
Tomer
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-08-04 14:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-17 12:11 [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support Tomer Maimon
2022-07-17 12:11 ` [PATCH v1 1/2] dt-bindings: ipmi: Add npcm845 compatible Tomer Maimon
2022-07-17 12:11 ` [PATCH v1 2/2] char: ipmi: modify NPCM KCS configuration Tomer Maimon
2022-07-18 12:51 ` [PATCH v1 0/2] char: ipmi: kcs: add Arbel NPCM8XX support Corey Minyard
2022-07-26 19:41 ` Tomer Maimon
2022-07-26 19:47 ` Corey Minyard
2022-07-27 5:39 ` Tomer Maimon
2022-07-27 15:47 ` Corey Minyard
2022-08-04 14:57 ` Tomer Maimon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).