* [PATCH] soc: nuvoton: Fix Kconfig
@ 2023-02-12 11:31 Jonathan Neuschäfer
2023-02-12 11:46 ` Geert Uytterhoeven
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Neuschäfer @ 2023-02-12 11:31 UTC (permalink / raw)
To: openbmc
Cc: Paul Menzel, Geert Uytterhoeven, Jonathan Neuschäfer,
linux-kernel, Joel Stanley
Unfortunately, version 5 of the Nuvoton WPCM450 SoC driver was applied
to bmc.git, which misses a few fixes that were in version 6.
This patch adds the missing fixes:
- Add a menu "Nuvoton SoC drivers" to make it easier to add other
Nuvoton SoC drivers later on
- select CONFIG_REGMAP from CONFIG_WPCM450_SOC
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450")
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
drivers/soc/nuvoton/Kconfig | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig
index df46182088ec2..2167d3d739d84 100644
--- a/drivers/soc/nuvoton/Kconfig
+++ b/drivers/soc/nuvoton/Kconfig
@@ -1,11 +1,17 @@
# SPDX-License-Identifier: GPL-2.0
-menuconfig WPCM450_SOC
+menu "Nuvoton SoC drivers"
+ depends on ARCH_NPCM || COMPILE_TEST
+
+config WPCM450_SOC
tristate "Nuvoton WPCM450 SoC driver"
default y if ARCH_WPCM450
select SOC_BUS
+ select REGMAP
help
Say Y here to compile the SoC information driver for Nuvoton
WPCM450 SoCs.
This driver provides information such as the SoC model and
revision.
+
+endmenu
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: nuvoton: Fix Kconfig
2023-02-12 11:31 [PATCH] soc: nuvoton: Fix Kconfig Jonathan Neuschäfer
@ 2023-02-12 11:46 ` Geert Uytterhoeven
0 siblings, 0 replies; 2+ messages in thread
From: Geert Uytterhoeven @ 2023-02-12 11:46 UTC (permalink / raw)
To: Jonathan Neuschäfer; +Cc: Paul Menzel, openbmc, Joel Stanley, linux-kernel
Hi Jonathan,
On Sun, Feb 12, 2023 at 12:31 PM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> Unfortunately, version 5 of the Nuvoton WPCM450 SoC driver was applied
> to bmc.git, which misses a few fixes that were in version 6.
>
> This patch adds the missing fixes:
Thanks for your patch!
> - Add a menu "Nuvoton SoC drivers" to make it easier to add other
> Nuvoton SoC drivers later on
... and to prevent asking about the Nuvoton WPCM450 SoC driver when
configuring a kernel without support for Nuvoton SoCs.
> - select CONFIG_REGMAP from CONFIG_WPCM450_SOC
Please include why this is needed.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fixes: 77b8c67b5637 ("soc: nuvoton: Add SoC info driver for WPCM450")
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
> drivers/soc/nuvoton/Kconfig | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/nuvoton/Kconfig b/drivers/soc/nuvoton/Kconfig
> index df46182088ec2..2167d3d739d84 100644
> --- a/drivers/soc/nuvoton/Kconfig
> +++ b/drivers/soc/nuvoton/Kconfig
> @@ -1,11 +1,17 @@
> # SPDX-License-Identifier: GPL-2.0
> -menuconfig WPCM450_SOC
> +menu "Nuvoton SoC drivers"
> + depends on ARCH_NPCM || COMPILE_TEST
> +
> +config WPCM450_SOC
> tristate "Nuvoton WPCM450 SoC driver"
> default y if ARCH_WPCM450
> select SOC_BUS
> + select REGMAP
> help
> Say Y here to compile the SoC information driver for Nuvoton
> WPCM450 SoCs.
>
> This driver provides information such as the SoC model and
> revision.
> +
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-12 11:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-12 11:31 [PATCH] soc: nuvoton: Fix Kconfig Jonathan Neuschäfer
2023-02-12 11:46 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).