openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 17/24] kbuild, pinctrl: nuvoton: npcm7xx: remove MODULE_LICENSE in non-modules
       [not found] <20230217141059.392471-1-nick.alcock@oracle.com>
@ 2023-02-17 14:10 ` Nick Alcock
  0 siblings, 0 replies; only message in thread
From: Nick Alcock @ 2023-02-17 14:10 UTC (permalink / raw)
  To: mcgrof
  Cc: Hitomi Hasegawa, Tomer Maimon, Avi Fishman, Linus Walleij,
	linux-kernel, Tali Perry, linux-gpio, openbmc, linux-modules

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Avi Fishman <avifishman70@gmail.com>
Cc: Tomer Maimon <tmaimon77@gmail.com>
Cc: Tali Perry <tali.perry1@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: openbmc@lists.ozlabs.org
Cc: linux-gpio@vger.kernel.org
---
 drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
index ff5bcea172e8..4e12b3768d65 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
@@ -2046,7 +2046,6 @@ static int __init npcm7xx_pinctrl_register(void)
 }
 arch_initcall(npcm7xx_pinctrl_register);
 
-MODULE_LICENSE("GPL v2");
 MODULE_AUTHOR("jordan_hargrave@dell.com");
 MODULE_AUTHOR("tomer.maimon@nuvoton.com");
 MODULE_DESCRIPTION("Nuvoton NPCM7XX Pinctrl and GPIO driver");
-- 
2.39.1.268.g9de2f9a303


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-19  7:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230217141059.392471-1-nick.alcock@oracle.com>
2023-02-17 14:10 ` [PATCH 17/24] kbuild, pinctrl: nuvoton: npcm7xx: remove MODULE_LICENSE in non-modules Nick Alcock

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).