* Re: [PATCH v2 10/13] pinctrl: meson: Enable COMPILE_TEST
[not found] ` <20220329152926.50958-11-andriy.shevchenko@linux.intel.com>
@ 2022-03-29 16:10 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2022-03-29 16:10 UTC (permalink / raw)
To: Andy Shevchenko, Qianggui Song, Krzysztof Kozlowski,
Fabien Dessenne, linux-gpio, linux-arm-kernel, linux-amlogic,
linux-kernel, openbmc, linux-renesas-soc, linux-samsung-soc,
linux-stm32
Cc: Andrew Lunn, Tomer Maimon, Geert Uytterhoeven,
Martin Blumenstingl, Kevin Hilman, Linus Walleij, Tomasz Figa,
Tali Perry, Avi Fishman, Alexandre Torgue, Bartosz Golaszewski,
Benjamin Fair, Sylwester Nawrocki, Patrick Venture,
Philipp Zabel, Alim Akhtar, Sebastian Hesselbarth,
Gregory Clement, Maxime Coquelin, Jerome Brunet
On 29/03/2022 17:29, Andy Shevchenko wrote:
> Enable COMPILE_TEST for a better test coverage.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pinctrl/meson/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/meson/Kconfig b/drivers/pinctrl/meson/Kconfig
> index d1955c65b4b6..64fb9e074ac6 100644
> --- a/drivers/pinctrl/meson/Kconfig
> +++ b/drivers/pinctrl/meson/Kconfig
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0-only
> menuconfig PINCTRL_MESON
> tristate "Amlogic SoC pinctrl drivers"
> - depends on ARCH_MESON
> + depends on ARCH_MESON || COMPILE_TEST
> depends on OF
> default y
> select PINMUX
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 09/13] pinctrl: meson: Rename REG_* to MREG_*
[not found] ` <20220329152926.50958-10-andriy.shevchenko@linux.intel.com>
@ 2022-03-29 16:13 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2022-03-29 16:13 UTC (permalink / raw)
To: Andy Shevchenko, Qianggui Song, Krzysztof Kozlowski,
Fabien Dessenne, linux-gpio, linux-arm-kernel, linux-amlogic,
linux-kernel, openbmc, linux-renesas-soc, linux-samsung-soc,
linux-stm32
Cc: Andrew Lunn, Tomer Maimon, Geert Uytterhoeven,
Martin Blumenstingl, Kevin Hilman, Linus Walleij, Tomasz Figa,
Tali Perry, Avi Fishman, Alexandre Torgue, Bartosz Golaszewski,
Benjamin Fair, Sylwester Nawrocki, Patrick Venture,
Philipp Zabel, Alim Akhtar, Sebastian Hesselbarth,
Gregory Clement, Maxime Coquelin, Jerome Brunet
On 29/03/2022 17:29, Andy Shevchenko wrote:
> Rename REG_* to MREG_* as a prerequisite for enabling COMPILE_TEST.
What error do you hit ?
MREG_ is rather ugly, something like PINCONF_REG_ or more simpler MESON_REG_ would be more appropriate.
Neil
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pinctrl/meson/pinctrl-meson.c | 24 ++++++++++++------------
> drivers/pinctrl/meson/pinctrl-meson.h | 24 ++++++++++++------------
> 2 files changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.c b/drivers/pinctrl/meson/pinctrl-meson.c
> index 49851444a6e3..64da61ba2bb9 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson.c
> @@ -218,13 +218,13 @@ static int meson_pinconf_set_output(struct meson_pinctrl *pc,
> unsigned int pin,
> bool out)
> {
> - return meson_pinconf_set_gpio_bit(pc, pin, REG_DIR, !out);
> + return meson_pinconf_set_gpio_bit(pc, pin, MREG_DIR, !out);
> }
>
> static int meson_pinconf_get_output(struct meson_pinctrl *pc,
> unsigned int pin)
> {
> - int ret = meson_pinconf_get_gpio_bit(pc, pin, REG_DIR);
> + int ret = meson_pinconf_get_gpio_bit(pc, pin, MREG_DIR);
>
> if (ret < 0)
> return ret;
> @@ -236,13 +236,13 @@ static int meson_pinconf_set_drive(struct meson_pinctrl *pc,
> unsigned int pin,
> bool high)
> {
> - return meson_pinconf_set_gpio_bit(pc, pin, REG_OUT, high);
> + return meson_pinconf_set_gpio_bit(pc, pin, MREG_OUT, high);
> }
>
> static int meson_pinconf_get_drive(struct meson_pinctrl *pc,
> unsigned int pin)
> {
> - return meson_pinconf_get_gpio_bit(pc, pin, REG_OUT);
> + return meson_pinconf_get_gpio_bit(pc, pin, MREG_OUT);
> }
>
> static int meson_pinconf_set_output_drive(struct meson_pinctrl *pc,
> @@ -269,7 +269,7 @@ static int meson_pinconf_disable_bias(struct meson_pinctrl *pc,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_PULLEN, ®, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULLEN, ®, &bit);
> ret = regmap_update_bits(pc->reg_pullen, reg, BIT(bit), 0);
> if (ret)
> return ret;
> @@ -288,7 +288,7 @@ static int meson_pinconf_enable_bias(struct meson_pinctrl *pc, unsigned int pin,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_PULL, ®, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULL, ®, &bit);
> if (pull_up)
> val = BIT(bit);
>
> @@ -296,7 +296,7 @@ static int meson_pinconf_enable_bias(struct meson_pinctrl *pc, unsigned int pin,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_PULLEN, ®, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULLEN, ®, &bit);
> ret = regmap_update_bits(pc->reg_pullen, reg, BIT(bit), BIT(bit));
> if (ret)
> return ret;
> @@ -321,7 +321,7 @@ static int meson_pinconf_set_drive_strength(struct meson_pinctrl *pc,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_DS, ®, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_DS, ®, &bit);
>
> if (drive_strength_ua <= 500) {
> ds_val = MESON_PINCONF_DRV_500UA;
> @@ -407,7 +407,7 @@ static int meson_pinconf_get_pull(struct meson_pinctrl *pc, unsigned int pin)
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_PULLEN, ®, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULLEN, ®, &bit);
>
> ret = regmap_read(pc->reg_pullen, reg, &val);
> if (ret)
> @@ -416,7 +416,7 @@ static int meson_pinconf_get_pull(struct meson_pinctrl *pc, unsigned int pin)
> if (!(val & BIT(bit))) {
> conf = PIN_CONFIG_BIAS_DISABLE;
> } else {
> - meson_calc_reg_and_bit(bank, pin, REG_PULL, ®, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_PULL, ®, &bit);
>
> ret = regmap_read(pc->reg_pull, reg, &val);
> if (ret)
> @@ -447,7 +447,7 @@ static int meson_pinconf_get_drive_strength(struct meson_pinctrl *pc,
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, pin, REG_DS, ®, &bit);
> + meson_calc_reg_and_bit(bank, pin, MREG_DS, ®, &bit);
>
> ret = regmap_read(pc->reg_ds, reg, &val);
> if (ret)
> @@ -595,7 +595,7 @@ static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio)
> if (ret)
> return ret;
>
> - meson_calc_reg_and_bit(bank, gpio, REG_IN, ®, &bit);
> + meson_calc_reg_and_bit(bank, gpio, MREG_IN, ®, &bit);
> regmap_read(pc->reg_gpio, reg, &val);
>
> return !!(val & BIT(bit));
> diff --git a/drivers/pinctrl/meson/pinctrl-meson.h b/drivers/pinctrl/meson/pinctrl-meson.h
> index ff5372e0a475..c00d9ad27843 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson.h
> +++ b/drivers/pinctrl/meson/pinctrl-meson.h
> @@ -63,12 +63,12 @@ struct meson_reg_desc {
> * enum meson_reg_type - type of registers encoded in @meson_reg_desc
> */
> enum meson_reg_type {
> - REG_PULLEN,
> - REG_PULL,
> - REG_DIR,
> - REG_OUT,
> - REG_IN,
> - REG_DS,
> + MREG_PULLEN,
> + MREG_PULL,
> + MREG_DIR,
> + MREG_OUT,
> + MREG_IN,
> + MREG_DS,
> NUM_REG,
> };
>
> @@ -150,12 +150,12 @@ struct meson_pinctrl {
> .irq_first = fi, \
> .irq_last = li, \
> .regs = { \
> - [REG_PULLEN] = { per, peb }, \
> - [REG_PULL] = { pr, pb }, \
> - [REG_DIR] = { dr, db }, \
> - [REG_OUT] = { or, ob }, \
> - [REG_IN] = { ir, ib }, \
> - [REG_DS] = { dsr, dsb }, \
> + [MREG_PULLEN] = { per, peb }, \
> + [MREG_PULL] = { pr, pb }, \
> + [MREG_DIR] = { dr, db }, \
> + [MREG_OUT] = { or, ob }, \
> + [MREG_IN] = { ir, ib }, \
> + [MREG_DS] = { dsr, dsb }, \
> }, \
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-30 3:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220329152926.50958-1-andriy.shevchenko@linux.intel.com>
[not found] ` <20220329152926.50958-11-andriy.shevchenko@linux.intel.com>
2022-03-29 16:10 ` [PATCH v2 10/13] pinctrl: meson: Enable COMPILE_TEST Neil Armstrong
[not found] ` <20220329152926.50958-10-andriy.shevchenko@linux.intel.com>
2022-03-29 16:13 ` [PATCH v2 09/13] pinctrl: meson: Rename REG_* to MREG_* Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).