openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* USB Gadget Vendor ID
@ 2019-04-12 15:17 Adriana Kobylak
  2019-04-12 15:24 ` Eddie James
  0 siblings, 1 reply; 4+ messages in thread
From: Adriana Kobylak @ 2019-04-12 15:17 UTC (permalink / raw)
  To: eajames, openbmc

Hi Eddie,

I have a script to initialize the USB gadget for Virtual Media and there 
was a comment that the Vendor ID should be provided by the Linux 
Foundation - 
https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .

In your ikvm script you use a Vendor ID with the comment "Linux 
Foundation" - 
https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18

Is this an ID that came from the LF, and if so could I use it in my 
script?

As a side question, were there any discussions about the serial number 
value in the ikvm script? I have a similar hard-coded value for the 
virtual media one but there were questions in the review about how 
useful could it be having a non-generated value and to have it removed 
instead.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: USB Gadget Vendor ID
  2019-04-12 15:17 USB Gadget Vendor ID Adriana Kobylak
@ 2019-04-12 15:24 ` Eddie James
  2019-04-12 15:52   ` Adriana Kobylak
  0 siblings, 1 reply; 4+ messages in thread
From: Eddie James @ 2019-04-12 15:24 UTC (permalink / raw)
  To: Adriana Kobylak, openbmc


On 4/12/19 10:17 AM, Adriana Kobylak wrote:
> Hi Eddie,
>
> I have a script to initialize the USB gadget for Virtual Media and 
> there was a comment that the Vendor ID should be provided by the Linux 
> Foundation - 
> https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .
>
> In your ikvm script you use a Vendor ID with the comment "Linux 
> Foundation" - 
> https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18
>
> Is this an ID that came from the LF, and if so could I use it in my 
> script?


Hi,

Since OpenBMC is a LF project, I just used their vendor ID... and I just 
invented a serial number. This might not be the proper way to do it... 
Since the devices are virtual, I'm not sure anyone will care though?


>
> As a side question, were there any discussions about the serial number 
> value in the ikvm script? I have a similar hard-coded value for the 
> virtual media one but there were questions in the review about how 
> useful could it be having a non-generated value and to have it removed 
> instead.


I think there were similar comments about the serial number but in the 
end it was decided to worry about it later I think.

Thanks, Eddie

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: USB Gadget Vendor ID
  2019-04-12 15:24 ` Eddie James
@ 2019-04-12 15:52   ` Adriana Kobylak
  2019-04-12 16:43     ` Eddie James
  0 siblings, 1 reply; 4+ messages in thread
From: Adriana Kobylak @ 2019-04-12 15:52 UTC (permalink / raw)
  To: Eddie James; +Cc: openbmc

On 2019-04-12 10:24, Eddie James wrote:
> On 4/12/19 10:17 AM, Adriana Kobylak wrote:
>> Hi Eddie,
>> 
>> I have a script to initialize the USB gadget for Virtual Media and 
>> there was a comment that the Vendor ID should be provided by the Linux 
>> Foundation - 
>> https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .
>> 
>> In your ikvm script you use a Vendor ID with the comment "Linux 
>> Foundation" - 
>> https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18
>> 
>> Is this an ID that came from the LF, and if so could I use it in my 
>> script?
> 
> 
> Hi,
> 
> Since OpenBMC is a LF project, I just used their vendor ID... and I
> just invented a serial number. This might not be the proper way to do
> it... Since the devices are virtual, I'm not sure anyone will care
> though?
> 
> 
Thanks that helps. Forgot to ask about the the product id (echo 0x0104 > 
idProduct # Multifunction Composite Gadget), is it also a LF number or 
documented somewhere?

>> 
>> As a side question, were there any discussions about the serial number 
>> value in the ikvm script? I have a similar hard-coded value for the 
>> virtual media one but there were questions in the review about how 
>> useful could it be having a non-generated value and to have it removed 
>> instead.
> 
> 
> I think there were similar comments about the serial number but in the
> end it was decided to worry about it later I think.
> 
> Thanks, Eddie

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: USB Gadget Vendor ID
  2019-04-12 15:52   ` Adriana Kobylak
@ 2019-04-12 16:43     ` Eddie James
  0 siblings, 0 replies; 4+ messages in thread
From: Eddie James @ 2019-04-12 16:43 UTC (permalink / raw)
  To: Adriana Kobylak; +Cc: openbmc


On 4/12/19 10:52 AM, Adriana Kobylak wrote:
> On 2019-04-12 10:24, Eddie James wrote:
>> On 4/12/19 10:17 AM, Adriana Kobylak wrote:
>>> Hi Eddie,
>>>
>>> I have a script to initialize the USB gadget for Virtual Media and 
>>> there was a comment that the Vendor ID should be provided by the 
>>> Linux Foundation - 
>>> https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/17494 .
>>>
>>> In your ikvm script you use a Vendor ID with the comment "Linux 
>>> Foundation" - 
>>> https://github.com/openbmc/obmc-ikvm/blob/fb6a8e1e727a8ece5eb0350d3962dd3056a6f608/create_usbhid.sh#L18
>>>
>>> Is this an ID that came from the LF, and if so could I use it in my 
>>> script?
>>
>>
>> Hi,
>>
>> Since OpenBMC is a LF project, I just used their vendor ID... and I
>> just invented a serial number. This might not be the proper way to do
>> it... Since the devices are virtual, I'm not sure anyone will care
>> though?
>>
>>
> Thanks that helps. Forgot to ask about the the product id (echo 0x0104 
> > idProduct # Multifunction Composite Gadget), is it also a LF number 
> or documented somewhere?


Yes, here's the list I was using: http://www.linux-usb.org/usb.ids


>
>>>
>>> As a side question, were there any discussions about the serial 
>>> number value in the ikvm script? I have a similar hard-coded value 
>>> for the virtual media one but there were questions in the review 
>>> about how useful could it be having a non-generated value and to 
>>> have it removed instead.
>>
>>
>> I think there were similar comments about the serial number but in the
>> end it was decided to worry about it later I think.
>>
>> Thanks, Eddie
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-12 16:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-12 15:17 USB Gadget Vendor ID Adriana Kobylak
2019-04-12 15:24 ` Eddie James
2019-04-12 15:52   ` Adriana Kobylak
2019-04-12 16:43     ` Eddie James

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).