From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Zev Weiss" <zev@bewilderbeest.net>, "Joel Stanley" <joel@jms.id.au>
Cc: - <devicetree@vger.kernel.org>,
linux-aspeed@lists.ozlabs.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Lubomir Rintel <lkundrak@v3.sk>, Rob Herring <robh+dt@kernel.org>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] dt-bindings: serial: 8250: add aspeed, lpc-address and aspeed,sirq
Date: Fri, 02 Apr 2021 11:44:39 +1030 [thread overview]
Message-ID: <639f957f-a0d7-4a06-8598-90da0e17820b@beta.fastmail.com> (raw)
In-Reply-To: <20210402004716.15961-5-zev@bewilderbeest.net>
On Fri, 2 Apr 2021, at 11:17, Zev Weiss wrote:
> These correspond to the existing lpc_address, sirq, and sirq_polarity
> sysfs attributes; the second element of aspeed,sirq provides a
> replacement for the deprecated aspeed,sirq-polarity-sense property.
>
> Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
> ---
> .../devicetree/bindings/serial/8250.yaml | 27 ++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml
> b/Documentation/devicetree/bindings/serial/8250.yaml
> index 491b9297432d..a6e01f9b745f 100644
> --- a/Documentation/devicetree/bindings/serial/8250.yaml
> +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> @@ -12,8 +12,13 @@ maintainers:
> allOf:
> - $ref: /schemas/serial.yaml#
> - if:
> - required:
> - - aspeed,sirq-polarity-sense
> + anyOf:
> + - required:
> + - aspeed,lpc-address
Why not aspeed,lpc-io-reg like the KCS binding?
There are some things we can do to improve it, but we shouldn't go and invent something different. I prefer aspeed,lpc-io-reg because it's name derives from the generic 'reg' property as does it's behaviour (if you assume a related `#size-cells = 0`).
> + - required:
> + - aspeed,sirq
Why not aspeed,lpc-interrupts like the KCS binding?
The generic IRQ property is 'interrupts', so like aspeed,lpc-io-reg the interrupts proposal for KCS follows in name and form. I'm hiding it behind the aspeed vendor prefix for now while I'm not satisfied that I understand the requirements of non-aspeed parts. Similarly, I added the lpc prefix because we don't tend to describe the host devicetree in the BMC devicetree (and so there's no parent interrupt controller that we can reference via a phandle) and we need a way to differentiate from the local interrupts property.
I don't see a reason for either of them to differ from what we already have for KCS, and I don't see any reason to continue the sysfs naming scheme in the binding.
Eventually I want to distil an LPC peripheral binding schema from what we've developed for the peripherals supported by aspeed and nuvoton SoCs.
Cheers,
Andrew
> + - required:
> + - aspeed,sirq-polarity-sense
> then:
> properties:
> compatible:
> @@ -190,6 +195,20 @@ properties:
> applicable to aspeed,ast2500-vuart.
> deprecated: true
>
> + aspeed,lpc-address:
> + $ref: '/schemas/types.yaml#/definitions/uint32'
> + description: |
> + The VUART LPC address. Only applicable to aspeed,ast2500-vuart.
> +
> + aspeed,sirq:
> + $ref: "/schemas/types.yaml#/definitions/uint32-array"
> + minItems: 2
> + maxItems: 2
> + description: |
> + A 2-cell property describing the VUART SIRQ number and SIRQ
> + polarity (IRQ_TYPE_LEVEL_LOW or IRQ_TYPE_LEVEL_HIGH). Only
> + applicable to aspeed,ast2500-vuart.
> +
> required:
> - reg
> - interrupts
> @@ -221,6 +240,7 @@ examples:
> };
> - |
> #include <dt-bindings/clock/aspeed-clock.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> serial@1e787000 {
> compatible = "aspeed,ast2500-vuart";
> reg = <0x1e787000 0x40>;
> @@ -228,7 +248,8 @@ examples:
> interrupts = <8>;
> clocks = <&syscon ASPEED_CLK_APB>;
> no-loopback-test;
> - aspeed,sirq-polarity-sense = <&syscon 0x70 25>;
> + aspeed,lpc-address = <0x3f8>;
> + aspeed,sirq = <4 IRQ_TYPE_LEVEL_LOW>;
> };
>
> ...
> --
> 2.31.1
>
>
next prev parent reply other threads:[~2021-04-02 1:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 0:47 [PATCH v3 0/4] aspeed-vuart: generalized DT properties Zev Weiss
2021-04-02 0:47 ` [PATCH v3 1/4] dt-bindings: serial: 8250: deprecate aspeed, sirq-polarity-sense Zev Weiss
2021-04-02 0:47 ` [PATCH v3 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code Zev Weiss
2021-04-02 0:47 ` [PATCH v3 3/4] drivers/tty/serial/8250: add aspeed, lpc-address and aspeed, sirq DT properties Zev Weiss
2021-04-02 0:47 ` [PATCH v3 4/4] dt-bindings: serial: 8250: add aspeed, lpc-address and aspeed, sirq Zev Weiss
2021-04-02 1:14 ` Andrew Jeffery [this message]
2021-04-02 1:19 ` [PATCH v3 4/4] dt-bindings: serial: 8250: add aspeed, lpc-address and aspeed,sirq Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639f957f-a0d7-4a06-8598-90da0e17820b@beta.fastmail.com \
--to=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).