From: Zev Weiss <email@example.com>
To: Andrew Jeffery <firstname.lastname@example.org>
Cc: - <email@example.com>,
Greg Kroah-Hartman <firstname.lastname@example.org>,
Lubomir Rintel <email@example.com>, Rob Herring <firstname.lastname@example.org>,
Subject: Re: [PATCH v3 4/4] dt-bindings: serial: 8250: add aspeed, lpc-address and aspeed,sirq
Date: Thu, 1 Apr 2021 20:19:47 -0500 [thread overview]
Message-ID: <YGZxM31x0All76gm@hatter.bewilderbeest.net> (raw)
On Thu, Apr 01, 2021 at 08:14:39PM CDT, Andrew Jeffery wrote:
>On Fri, 2 Apr 2021, at 11:17, Zev Weiss wrote:
>> These correspond to the existing lpc_address, sirq, and sirq_polarity
>> sysfs attributes; the second element of aspeed,sirq provides a
>> replacement for the deprecated aspeed,sirq-polarity-sense property.
>> Signed-off-by: Zev Weiss <email@example.com>
>> .../devicetree/bindings/serial/8250.yaml | 27 ++++++++++++++++---
>> 1 file changed, 24 insertions(+), 3 deletions(-)
>> diff --git a/Documentation/devicetree/bindings/serial/8250.yaml
>> index 491b9297432d..a6e01f9b745f 100644
>> --- a/Documentation/devicetree/bindings/serial/8250.yaml
>> +++ b/Documentation/devicetree/bindings/serial/8250.yaml
>> @@ -12,8 +12,13 @@ maintainers:
>> - $ref: /schemas/serial.yaml#
>> - if:
>> - required:
>> - - aspeed,sirq-polarity-sense
>> + anyOf:
>> + - required:
>> + - aspeed,lpc-address
>Why not aspeed,lpc-io-reg like the KCS binding?
>There are some things we can do to improve it, but we shouldn't go and invent something different. I prefer aspeed,lpc-io-reg because it's name derives from the generic 'reg' property as does it's behaviour (if you assume a related `#size-cells = 0`).
>> + - required:
>> + - aspeed,sirq
>Why not aspeed,lpc-interrupts like the KCS binding?
>The generic IRQ property is 'interrupts', so like aspeed,lpc-io-reg the interrupts proposal for KCS follows in name and form. I'm hiding it behind the aspeed vendor prefix for now while I'm not satisfied that I understand the requirements of non-aspeed parts. Similarly, I added the lpc prefix because we don't tend to describe the host devicetree in the BMC devicetree (and so there's no parent interrupt controller that we can reference via a phandle) and we need a way to differentiate from the local interrupts property.
>I don't see a reason for either of them to differ from what we already have for KCS, and I don't see any reason to continue the sysfs naming scheme in the binding.
Ah, OK -- I was aiming for consistency with the existing vuart sysfs
attributes, but if that's not a worthwhile concern I'm fine with
aspeed,lpc-io-reg & aspeed,lpc-interrupts.
prev parent reply other threads:[~2021-04-02 1:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 0:47 [PATCH v3 0/4] aspeed-vuart: generalized DT properties Zev Weiss
2021-04-02 0:47 ` [PATCH v3 1/4] dt-bindings: serial: 8250: deprecate aspeed, sirq-polarity-sense Zev Weiss
2021-04-02 0:47 ` [PATCH v3 2/4] drivers/tty/serial/8250: refactor sirq and lpc address setting code Zev Weiss
2021-04-02 0:47 ` [PATCH v3 3/4] drivers/tty/serial/8250: add aspeed, lpc-address and aspeed, sirq DT properties Zev Weiss
2021-04-02 0:47 ` [PATCH v3 4/4] dt-bindings: serial: 8250: add aspeed, lpc-address and aspeed, sirq Zev Weiss
2021-04-02 1:14 ` [PATCH v3 4/4] dt-bindings: serial: 8250: add aspeed, lpc-address and aspeed,sirq Andrew Jeffery
2021-04-02 1:19 ` Zev Weiss [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).